From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
orson.zhai@spreadtrum.com, gregkh@linuxfoundation.org,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, catalin.marinas@arm.com,
Chunyan Zhang <chunyan.zhang@spreadtrum.com>
Subject: Re: [PATCH 4/5] sprd_serial: switch comptible string to sc-uart
Date: Thu, 16 Feb 2017 14:31:38 +0100 [thread overview]
Message-ID: <1761969.45NG6Q1Iyc@wuerfel> (raw)
In-Reply-To: <1487063952-7113-5-git-send-email-chunyan.zhang@spreadtrum.com>
On Tuesday, February 14, 2017 5:19:11 PM CET Chunyan Zhang wrote:
> static const struct of_device_id serial_ids[] = {
> - {.compatible = "sprd,sc9836-uart",},
> + {.compatible = "sprd,sc-uart",},
> {}
We really need this to be specific, in case Spreadtrum ever
makes a slightly different UART that is not 100% compatible
with this one. Also, you can't remove the string you already have,
only add to it.
Normally when you have a new chip that is compatible with one
we already have a driver for, we mark the device as compatible
with the old one and avoid having to change the driver, e.g.
compatible = "sprd,sc9995-uart", "sprd,sc9836-uart";
This way, the driver could later be changed to handle anything
that is compatible with sc9995 differently from sc9836, but
by default it would match the original string.
Arnd
next prev parent reply other threads:[~2017-02-16 13:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 9:19 [PATCH 0/5] Add Spreadtrum SP9860G support Chunyan Zhang
2017-02-14 9:19 ` [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang
[not found] ` <1487063952-7113-2-git-send-email-chunyan.zhang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>
2017-02-14 15:57 ` Mark Rutland
2017-02-16 7:57 ` Chunyan Zhang
2017-02-14 16:44 ` Sudeep Holla
2017-02-17 7:28 ` Chunyan Zhang
[not found] ` <20170217072839.GA8767-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>
2017-02-17 10:28 ` Sudeep Holla
2017-02-20 9:37 ` Chunyan Zhang
[not found] ` <20170220093750.GA9600-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>
2017-02-20 10:47 ` Sudeep Holla
[not found] ` <c28ee4e9-9abe-c019-2439-f9cb239b67e9-5wv7dgnIgG8@public.gmane.org>
2017-02-20 12:56 ` Chunyan Zhang
2017-02-14 9:19 ` [PATCH 2/5] Documentation: sprd: Add bindings for SP9860G Chunyan Zhang
2017-02-14 9:19 ` [PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart Chunyan Zhang
[not found] ` <1487063952-7113-4-git-send-email-chunyan.zhang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org>
2017-02-14 17:02 ` Rob Herring
2017-02-14 9:19 ` [PATCH 4/5] sprd_serial: switch comptible string to sc-uart Chunyan Zhang
2017-02-16 13:31 ` Arnd Bergmann [this message]
2017-02-17 7:35 ` Chunyan Zhang
2017-02-14 9:19 ` [PATCH 5/5] serial: sprd: adjust TIMEOUT to a big value Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1761969.45NG6Q1Iyc@wuerfel \
--to=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=chunyan.zhang@spreadtrum.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orson.zhai@spreadtrum.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).