Devicetree
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Haibo Chen <haibo.chen@nxp.com>
Cc: Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org,  linux-spi@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>,
	 imx@lists.linux.dev, devicetree@vger.kernel.org,
	Han Xu <han.xu@nxp.com>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: spi: Document imx94 xspi
Date: Mon, 03 Nov 2025 22:26:08 -0600	[thread overview]
Message-ID: <176223036803.847185.12615558425940080887.robh@kernel.org> (raw)
In-Reply-To: <20251104-xspi-v1-1-1502847ade40@nxp.com>


On Tue, 04 Nov 2025 11:07:36 +0800, Haibo Chen wrote:
> Document imx94 xspi that supports interface to serial flash
> supporting following features:
> 
> - Single-bit SPI, Dual SPI, Quad SPI and Octal SPI.
> - Single Data Rate or Double Data Rate modes.
> - Direct memory mapping of all AHB memory accesses to the
>   chip system memory space.
> - Multi-master AHB accesses with priority.
> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
>  .../devicetree/bindings/spi/spi-nxp-xspi.yaml      | 84 ++++++++++++++++++++++
>  MAINTAINERS                                        |  8 +++
>  2 files changed, 92 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/spi/spi-nxp-xspi.example.dtb: /example-0/soc/spi@42b90000: failed to match any schema with compatible: ['nxp,imx943-xspi']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251104-xspi-v1-1-1502847ade40@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-11-04  4:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04  3:07 [PATCH 0/2] Add support for NXP XSPI Haibo Chen
2025-11-04  3:07 ` [PATCH 1/2] dt-bindings: spi: Document imx94 xspi Haibo Chen
2025-11-04  4:26   ` Rob Herring (Arm) [this message]
2025-11-04  4:48     ` Bough Chen
2025-11-04  7:39   ` Krzysztof Kozlowski
2025-11-04 17:02   ` Frank Li
2025-11-04  3:07 ` [PATCH 2/2] spi: add driver for NXP XSPI controller Haibo Chen
2025-11-04 18:08   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176223036803.847185.12615558425940080887.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=haibo.chen@nxp.com \
    --cc=han.xu@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox