From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
Kukjin Kim <kgene@kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH 1/2] ARM: dts: Enable RTC node in exynos4.dtsi file
Date: Wed, 13 Nov 2013 12:52:05 +0100 [thread overview]
Message-ID: <1764307.sx88zLt93L@amdc1032> (raw)
In-Reply-To: <528353F7.4050004@samsung.com>
Hi,
On Wednesday, November 13, 2013 11:27:03 AM Sylwester Nawrocki wrote:
> On 13/11/13 09:08, Tomasz Figa wrote:
> >> As was discussed earlier too, status field of DT node is not supposed
> >> > to be used for
> >> > keeping an IP enabled or disabled. That should be done via the kernel
> >> > config. The DT status
> >> > is mostly to indicate the hardware status of the IP on the SoC/board.
> >> > If the node fully defines the hardware,
> >> > then it should be kept enabled by default unless such enabling causes
> >> > some issues with other IPs due to
> >> > pin sharing conflicts, etc. In the above case the node completely
> >> > defines the hardware and hence there is no
> >> > reason to keep it disabled.
> >
> > That's correct. (Unless I'm missing some board specific dependency of RTC.
> > If so, please correct me.)
>
> I don't really like this argument. Why not allow the firmware to decide
> which devices are relevant and should be handled by the kernel ?
> And since we are aiming at single kernel config, if I understand things
> correctly, I can't see anything else than dts that could hold the machine
> *configuration*.
>
> So let's not make all stuff enabled by default, that's not something we
> want on those mobile device SoCs. We should not be making fine system
> tuning more difficult than necessary.
>
> I'm with Kukjin on this matter and would prefer patches like the $subject
> patch not be merged.
I generally agree with Sylwester and Kukjin that devices should not be
enabled by default in dtsi files. However in a particular case of RTC
support there should be an exception from the generic rule and RTC
should be enabled for all EXYNOS boards (we have RTC driver config
option already enabled in our exynos_defconfig and we are also already
enabling RTC device explicitly in EXYNOS5250 dtsi file).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2013-11-13 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1382438215-13215-1-git-send-email-sachin.kamat@linaro.org>
2013-11-12 11:01 ` [PATCH 1/2] ARM: dts: Enable RTC node in exynos4.dtsi file Kukjin Kim
2013-11-13 3:31 ` Sachin Kamat
2013-11-13 8:08 ` Tomasz Figa
2013-11-13 10:27 ` Sylwester Nawrocki
2013-11-13 11:52 ` Bartlomiej Zolnierkiewicz [this message]
2013-11-13 12:21 ` Tomasz Figa
2013-12-10 9:07 ` Sachin Kamat
2013-12-18 15:55 ` Tomasz Figa
2013-12-20 21:48 ` Kukjin Kim
2013-12-20 22:07 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1764307.sx88zLt93L@amdc1032 \
--to=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox