* [PATCH] dt-bindings: remoteproc: qcom,adsp: Re-add cx-supply
@ 2025-12-07 10:35 Luca Weiss
2025-12-08 16:33 ` Konrad Dybcio
2025-12-09 21:19 ` Rob Herring (Arm)
0 siblings, 2 replies; 4+ messages in thread
From: Luca Weiss @ 2025-12-07 10:35 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Dmitry Baryshkov
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel, Luca Weiss
Some boards (e.g. sdm845-samsung-starqltechn) provide a cx-supply
reference for the SLPI PAS.
The Linux driver unconditionally tries getting "cx" and "px" supplies,
so it actually is used.
Fixes: 3d447dcdae53 ("dt-bindings: remoteproc: qcom,adsp: Make msm8974 use CX as power domain")
Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
There's literally one board using this upstream, judging from that I'm
not sure this is a misuse of cx-supply or what exactly. An alternative
to this patch is of course removing the usage in
sdm845-samsung-starqltechn, but as it stands right now the patch under
"Fixes" introduces a dtbs_check warning.
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
index 137f95028313..bde138716873 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
@@ -32,6 +32,9 @@ properties:
reg:
maxItems: 1
+ cx-supply:
+ description: Phandle to the CX regulator
+
px-supply:
description: Phandle to the PX regulator
---
base-commit: 37bb2e7217b01404e2abf9d90d8e5705a5603b52
change-id: 20251207-adsp-cx-fixup-442882486ec5
Best regards,
--
Luca Weiss <luca@lucaweiss.eu>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: remoteproc: qcom,adsp: Re-add cx-supply
2025-12-07 10:35 [PATCH] dt-bindings: remoteproc: qcom,adsp: Re-add cx-supply Luca Weiss
@ 2025-12-08 16:33 ` Konrad Dybcio
2025-12-11 14:41 ` Dzmitry Sankouski
2025-12-09 21:19 ` Rob Herring (Arm)
1 sibling, 1 reply; 4+ messages in thread
From: Konrad Dybcio @ 2025-12-08 16:33 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Dmitry Baryshkov, Dzmitry Sankouski
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel
On 12/7/25 11:35 AM, Luca Weiss wrote:
> Some boards (e.g. sdm845-samsung-starqltechn) provide a cx-supply
> reference for the SLPI PAS.
>
> The Linux driver unconditionally tries getting "cx" and "px" supplies,
> so it actually is used.
>
> Fixes: 3d447dcdae53 ("dt-bindings: remoteproc: qcom,adsp: Make msm8974 use CX as power domain")
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
> There's literally one board using this upstream, judging from that I'm
> not sure this is a misuse of cx-supply or what exactly. An alternative
> to this patch is of course removing the usage in
> sdm845-samsung-starqltechn, but as it stands right now the patch under
> "Fixes" introduces a dtbs_check warning.
FWIW that's likely a hack (because IIUC it needs to power up some
regulator for the sensor devices to work) but that's "fine"
I don't know if there's a better way to handle it though.. I think it's
a board design "issue", since the DSP has access to some GPIOs but it
seems like that wasn't utilized
I'm open to suggestions
+Dzmitry-the-starqltechn-submitter
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: remoteproc: qcom,adsp: Re-add cx-supply
2025-12-08 16:33 ` Konrad Dybcio
@ 2025-12-11 14:41 ` Dzmitry Sankouski
0 siblings, 0 replies; 4+ messages in thread
From: Dzmitry Sankouski @ 2025-12-11 14:41 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Luca Weiss, Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Dmitry Baryshkov, ~postmarketos/upstreaming, phone-devel,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
пн, 8 дек. 2025 г. в 19:33, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>:
>
> On 12/7/25 11:35 AM, Luca Weiss wrote:
> > Some boards (e.g. sdm845-samsung-starqltechn) provide a cx-supply
> > reference for the SLPI PAS.
> >
> > The Linux driver unconditionally tries getting "cx" and "px" supplies,
> > so it actually is used.
> >
> > Fixes: 3d447dcdae53 ("dt-bindings: remoteproc: qcom,adsp: Make msm8974 use CX as power domain")
> > Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> > ---
> > There's literally one board using this upstream, judging from that I'm
> > not sure this is a misuse of cx-supply or what exactly. An alternative
> > to this patch is of course removing the usage in
> > sdm845-samsung-starqltechn, but as it stands right now the patch under
> > "Fixes" introduces a dtbs_check warning.
>
> FWIW that's likely a hack (because IIUC it needs to power up some
> regulator for the sensor devices to work) but that's "fine"
>
I confirm this probably powers up devices, because firmware boots fine
without cx-supply.
--
Best regards,
Dzmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: remoteproc: qcom,adsp: Re-add cx-supply
2025-12-07 10:35 [PATCH] dt-bindings: remoteproc: qcom,adsp: Re-add cx-supply Luca Weiss
2025-12-08 16:33 ` Konrad Dybcio
@ 2025-12-09 21:19 ` Rob Herring (Arm)
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-12-09 21:19 UTC (permalink / raw)
To: Luca Weiss
Cc: devicetree, Bjorn Andersson, Conor Dooley, Dmitry Baryshkov,
Mathieu Poirier, phone-devel, linux-kernel, Krzysztof Kozlowski,
linux-remoteproc, linux-arm-msm, Manivannan Sadhasivam,
~postmarketos/upstreaming
On Sun, 07 Dec 2025 19:35:35 +0900, Luca Weiss wrote:
> Some boards (e.g. sdm845-samsung-starqltechn) provide a cx-supply
> reference for the SLPI PAS.
>
> The Linux driver unconditionally tries getting "cx" and "px" supplies,
> so it actually is used.
>
> Fixes: 3d447dcdae53 ("dt-bindings: remoteproc: qcom,adsp: Make msm8974 use CX as power domain")
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
> There's literally one board using this upstream, judging from that I'm
> not sure this is a misuse of cx-supply or what exactly. An alternative
> to this patch is of course removing the usage in
> sdm845-samsung-starqltechn, but as it stands right now the patch under
> "Fixes" introduces a dtbs_check warning.
> ---
> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-11 14:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-07 10:35 [PATCH] dt-bindings: remoteproc: qcom,adsp: Re-add cx-supply Luca Weiss
2025-12-08 16:33 ` Konrad Dybcio
2025-12-11 14:41 ` Dzmitry Sankouski
2025-12-09 21:19 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).