devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Richard Acayan <mailingradian@gmail.com>
Cc: linux-arm-msm@vger.kernel.org,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	 Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	 Robert Mader <robert.mader@collabora.com>,
	 Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org,  linux-media@vger.kernel.org,
	Tianshu Qiu <tian.shu.qiu@intel.com>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH v4 1/5] dt-bindings: media: i2c: Add Sony IMX355
Date: Wed, 10 Dec 2025 21:26:45 -0600	[thread overview]
Message-ID: <176542360577.3870756.16103619361508957186.robh@kernel.org> (raw)
In-Reply-To: <20251211014846.16602-2-mailingradian@gmail.com>


On Wed, 10 Dec 2025 20:48:42 -0500, Richard Acayan wrote:
> The IMX355 camera sensor is a camera sensor that can be found as the
> front camera in some smartphones, such as the Pixel 3, Pixel 3 XL, Pixel
> 3a, and Pixel 3a XL. It already has a driver, but needs support for
> device tree. Document the IMX355 to support defining it in device tree.
> 
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
>  .../bindings/media/i2c/sony,imx355.yaml       | 119 ++++++++++++++++++
>  1 file changed, 119 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml: properties:port:properties:endpoint: 'anyOf' conditional failed, one must be fixed:
	'data-lanes' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
	'type' was expected
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20251211014846.16602-2-mailingradian@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2025-12-11  3:26 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-11  1:48 [PATCH v4 0/5] media: i2c: IMX355 for the Pixel 3a Richard Acayan
2025-12-11  1:48 ` [PATCH v4 1/5] dt-bindings: media: i2c: Add Sony IMX355 Richard Acayan
2025-12-11  3:12   ` Krzysztof Kozlowski
2025-12-11  3:26   ` Rob Herring (Arm) [this message]
2025-12-11  5:02   ` Krzysztof Kozlowski
2025-12-12  0:23     ` Richard Acayan
2025-12-11  5:05   ` Krzysztof Kozlowski
2025-12-11  9:35   ` Vladimir Zapolskiy
2025-12-11 11:02   ` Vladimir Zapolskiy
2025-12-13 21:50     ` Richard Acayan
2025-12-13 21:52       ` Richard Acayan
2025-12-11  1:48 ` [PATCH v4 2/5] media: i2c: imx355: Support devicetree and power management Richard Acayan
2025-12-11  9:37   ` David Heidelberg
2025-12-11 11:00   ` Vladimir Zapolskiy
2025-12-12  1:43   ` Krzysztof Kozlowski
2025-12-12  1:45     ` Krzysztof Kozlowski
2025-12-12  1:49   ` Bryan O'Donoghue
2025-12-11  1:48 ` [PATCH v4 3/5] arm64: dts: qcom: sdm670: remove camss endpoint nodes Richard Acayan
2025-12-11 10:46   ` Vladimir Zapolskiy
2025-12-12  1:39   ` Bryan O'Donoghue
2025-12-11  1:48 ` [PATCH v4 4/5] arm64: dts: qcom: sdm670: add camera mclk pins Richard Acayan
2025-12-11 10:47   ` Vladimir Zapolskiy
2025-12-12  1:40   ` Bryan O'Donoghue
2025-12-13 11:01   ` David Heidelberg
2025-12-11  1:48 ` [PATCH v4 5/5] arm64: dts: qcom: sdm670-google-sargo: add imx355 front camera Richard Acayan
2025-12-11  5:16   ` Dmitry Baryshkov
2025-12-12  0:41     ` Richard Acayan
2025-12-12  1:45       ` Bryan O'Donoghue
2025-12-12  2:19         ` Richard Acayan
2025-12-12  2:20           ` Bryan O'Donoghue
2025-12-12 19:22       ` Dmitry Baryshkov
2025-12-11 10:49   ` Vladimir Zapolskiy
2025-12-12 22:41   ` David Heidelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176542360577.3870756.16103619361508957186.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mailingradian@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robert.mader@collabora.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tian.shu.qiu@intel.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).