Re: [PATCH 09/17] ARM: dts: Add missing iss node and binding for omap4

[Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>]

Hi Tony,

Thank you for the patch.

On Tuesday, 29 August 2017 00:19:10 EEST Tony Lindgren wrote:
> On omap4 we're missing the iss node with it's related "ti,hwmods"
> property that the SoC interconnect code needs.
> 
> Note that this will only show up as a bug with "doesn't have
> mpu register target base" boot errors when the legacy platform
> data is removed.
> 
> Cc: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
> Cc: Mauro Carvalho Chehab <mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Sakari Ailus <sakari.ailus-X3B1VOXEql0@public.gmane.org>
> Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/media/ti-iss.txt | 32 +++++++++++++++++++
>  arch/arm/boot/dts/omap4.dtsi                       |  7 +++++
>  2 files changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/ti-iss.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/ti-iss.txt
> b/Documentation/devicetree/bindings/media/ti-iss.txt new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/ti-iss.txt
> @@ -0,0 +1,32 @@
> +Texas Instruments Imaging Subsystem (ISS) binding
> +
> +ISS is used for cameras on Texas Instruments SoCs.
> +
> +
> +Required properties:
> +
> +compatible: Shall be one of the following:
> +	    "ti,omap4-iss"
> +
> +reg: Shall contain the device instance IO range
> +
> +interrupts: Shall contain the device instance interrupt
> +
> +
> +Optional properties:
> +
> +reg-names: Shall contain the IO range names if multiple IO
> +	   ranges are used by the SoC
> +
> +ti,hwmods: Shall contain the TI interconnect module name if needed
> +	   by the SoC

This isn't enough. The ISS isn't a stand-alone IP core, it is connected to 
external devices and those connections must be modelled in DT similarly to the 
OMAP3 ISP.

> +Example:
> +
> +	iss: iss@52000000 {
> +		compatible = "ti,omap4-iss";
> +		reg = <0x52000000 0x1000000>;
> +		interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> +		ti,hwmods = "iss";
> +	};
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -649,6 +649,13 @@
>  			#iommu-cells = <0>;
>  		};
> 
> +		iss: iss@52000000 {
> +			compatible = "ti,omap4-iss";
> +			reg = <0x52000000 0x1000000>;
> +			interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> +			ti,hwmods = "iss";
> +		};
> +
>  		mmu_ipu: mmu@55082000 {
>  			compatible = "ti,omap4-iommu";
>  			reg = <0x55082000 0x100>;


-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html