Devicetree
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: ASHISH YADAV <ashishyadav78@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Ashish Yadav <ashish.yadav@infineon.com>,
	 Guenter Roeck <linux@roeck-us.net>,
	linux-hwmon@vger.kernel.org,  devicetree@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon/pmbus: Add Infineon XDP720
Date: Mon, 30 Mar 2026 06:51:01 -0500	[thread overview]
Message-ID: <177487146147.2070608.2849563543220120287.robh@kernel.org> (raw)
In-Reply-To: <20260330102345.37065-2-Ashish.Yadav@infineon.com>


On Mon, 30 Mar 2026 15:53:44 +0530, ASHISH YADAV wrote:
> From: Ashish Yadav <ashish.yadav@infineon.com>
> 
> Add documentation for the device tree binding of the XDP720 eFuse.
> 
> Signed-off-by: Ashish Yadav <ashish.yadav@infineon.com>
> ---
> 
> This patch introduces a YAML schema describing the required and optional
> properties for the XDP720 eFuse device node. It includes details on the
> compatible string, register mapping, and rimon-micro-ohms(RIMON).
> 
> The RIMON resistance is installed between the Imon pin and the ground
> reference.
> ---
>  .../bindings/hwmon/pmbus/infineon,xdp720.yaml | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp720.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp720.yaml: properties:infineon,rimon-micro-ohms: '$ref' should not be valid under {'const': '$ref'}
	hint: Standard unit suffix properties don't need a type $ref
	from schema $id: http://devicetree.org/meta-schemas/core.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp720.yaml: properties:infineon,rimon-micro-ohms: '$ref' should not be valid under {'const': '$ref'}
	hint: Standard unit suffix properties don't need a type $ref
	from schema $id: http://devicetree.org/meta-schemas/core.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp720.example.dtb: hwmon@11 (infineon,xdp720): infineon,rimon-micro-ohms: 1098000000 is not of type 'array'
	from schema $id: http://devicetree.org/schemas/property-units.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp720.example.dtb: hwmon@11 (infineon,xdp720): infineon,rimon-micro-ohms: 1098000000 is not of type 'array'
	from schema $id: http://devicetree.org/schemas/property-units.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260330102345.37065-2-Ashish.Yadav@infineon.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2026-03-30 11:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30 10:23 [PATCH 0/2] Add support for Infineon Digital eFuse XDP720 ASHISH YADAV
2026-03-30 10:23 ` [PATCH 1/2] dt-bindings: hwmon/pmbus: Add Infineon XDP720 ASHISH YADAV
2026-03-30 11:51   ` Rob Herring (Arm) [this message]
2026-04-02 13:40     ` ashish yadav
2026-03-30 10:23 ` [PATCH 2/2] hwmon:(pmbus/xdp720) Add support for efuse xdp720 ASHISH YADAV
2026-03-30 16:25 ` [PATCH 0/2] Add support for Infineon Digital eFuse XDP720 Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177487146147.2070608.2849563543220120287.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=ashish.yadav@infineon.com \
    --cc=ashishyadav78@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox