From: "Rob Herring (Arm)" <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Linus Walleij <linusw@kernel.org>,
linux-kernel@vger.kernel.org,
Prathamesh Shete <pshete@nvidia.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: nvidia,tegra234: Add missing required block
Date: Mon, 13 Apr 2026 12:17:45 -0500 [thread overview]
Message-ID: <177610066469.3066647.8560667150226878953.robh@kernel.org> (raw)
In-Reply-To: <20260410111047.309798-3-krzysztof.kozlowski@oss.qualcomm.com>
On Fri, 10 Apr 2026 13:10:48 +0200, Krzysztof Kozlowski wrote:
> Binding should require 'reg' property, because address space cannot be
> missing in the hardware and is already needed by the Linux drivers.
> Require also 'compatible' by convention, although it is not strictly
> necessary.
>
> Fixes: 857982138b79 ("dt-bindings: pinctrl: Document Tegra234 pin controllers")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> .../bindings/pinctrl/nvidia,tegra234-pinmux-aon.yaml | 4 ++++
> .../devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml | 4 ++++
> 2 files changed, 8 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
prev parent reply other threads:[~2026-04-13 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 11:10 [PATCH 1/2] dt-bindings: pinctrl: nvidia,tegra234: Add missing required block Krzysztof Kozlowski
2026-04-10 11:10 ` [PATCH 2/2] dt-bindings: pinctrl: nvidia,tegra234: Correctly use additionalProperties Krzysztof Kozlowski
2026-04-13 17:18 ` Rob Herring (Arm)
2026-04-13 17:17 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177610066469.3066647.8560667150226878953.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox