From: "Rob Herring (Arm)" <robh@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>, Abel Vesa <abelvesa@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-msm@vger.kernel.org,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
Conor Dooley <conor+dt@kernel.org>,
linux-clk@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/6] dt-bindings: clock: qcom: sm8650-gcc: Add missing power-domains property
Date: Fri, 24 Apr 2026 05:46:25 -0500 [thread overview]
Message-ID: <177702758111.3345072.2051838665194424641.robh@kernel.org> (raw)
In-Reply-To: <20260424-topic-sm8x50-tie-gcc-to-cx-v1-3-4b6e09d532ce@linaro.org>
On Fri, 24 Apr 2026 11:07:57 +0200, Neil Armstrong wrote:
> In order for the GCC votes on the GDSCs it provides to be propagated
> to CX, CX needs to be declared as power domain of the GCC.
>
> Document the missing power-domains property to that purpose.
>
> Fixes: b69d932154dc ("dt-bindings: clock: qcom: document the SM8650 General Clock Controller")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sm8650-gcc.example.dtb: clock-controller@100000 (qcom,sm8650-gcc): 'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/clock/qcom,sm8650-gcc.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260424-topic-sm8x50-tie-gcc-to-cx-v1-3-4b6e09d532ce@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-04-24 10:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 9:07 [PATCH 0/6] arm64: dts: qcom: sm8[456]50: Add missing CX power domain to GCC Neil Armstrong
2026-04-24 9:07 ` [PATCH 1/6] dt-bindings: clock: qcom: gcc-sm8450: Add missing power-domains property Neil Armstrong
2026-04-24 10:46 ` Rob Herring (Arm)
2026-04-24 9:07 ` [PATCH 2/6] dt-bindings: clock: qcom: sm8550-gcc: " Neil Armstrong
2026-04-24 10:46 ` Rob Herring (Arm)
2026-04-24 9:07 ` [PATCH 3/6] dt-bindings: clock: qcom: sm8650-gcc: " Neil Armstrong
2026-04-24 10:46 ` Rob Herring (Arm) [this message]
2026-04-24 9:07 ` [PATCH 4/6] arm64: dts: qcom: sm8450: Add missing CX power domain to GCC Neil Armstrong
2026-04-24 9:57 ` Konrad Dybcio
2026-04-24 10:31 ` Abel Vesa
2026-04-24 9:07 ` [PATCH 5/6] arm64: dts: qcom: sm8550: " Neil Armstrong
2026-04-24 9:58 ` Konrad Dybcio
2026-04-24 10:31 ` Abel Vesa
2026-04-24 9:08 ` [PATCH 6/6] arm64: dts: qcom: sm8650: " Neil Armstrong
2026-04-24 10:31 ` Abel Vesa
2026-04-27 10:19 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177702758111.3345072.2051838665194424641.robh@kernel.org \
--to=robh@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_saipraka@quicinc.com \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox