From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ultrarisc.com (unknown [218.76.62.146]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D58BE1A682C; Wed, 29 Apr 2026 00:57:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=218.76.62.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777424224; cv=none; b=kXcAEwavPbJRMmB18mCXksImR4oPYpDqyMW228HR0MNK6/KkXNjskjpoQlXGI0/hSKkWjKKdHkSDfw+GhGq/PDo9KCoXadIGnWCSIUxqUZXZg1ZrTzYg13cTtrzmallP6Q3dMCN4G+zksBGkG4tzxFLthwKb1i6DMC1/egqp2Jg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777424224; c=relaxed/simple; bh=4czbswj4ht+A87lTkdcd08crGu9AEPernCdFv5ThrwI=; h=MIME-Version:Content-Type:Subject:From:To:Cc:In-Reply-To: References:Date:Message-Id; b=YGqiAGsOQtpUb5sWA8QwWDz0RtuocTl4biZfBr4dwldb/XWlfZqIzQWEn1KMwUbc0/fUAaKqzk4veISy6KV2OBL64Cn1ssCw/RYA0KqSaj1sBj76RuW04oS8lIDl0AWvkj+skmmuNSw/ffnwdKgWoycFXdjU7p1EiTNak5oQPoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ultrarisc.com; spf=pass smtp.mailfrom=ultrarisc.com; dkim=pass (1024-bit key) header.d=ultrarisc.com header.i=@ultrarisc.com header.b=lkwrEdAV; arc=none smtp.client-ip=218.76.62.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ultrarisc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ultrarisc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ultrarisc.com header.i=@ultrarisc.com header.b="lkwrEdAV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarisc.com; s=dkim; h=Received:MIME-Version:Content-Type: Content-Transfer-Encoding:Subject:From:To:Cc:In-Reply-To: References:Date:Message-Id; bh=KMl/DXyKt0CwRNL4eOdNzXil5p4m9/51p alhvFtb1Jk=; b=lkwrEdAVJ3T33HJmbKZ8FbOsYr7gxijC3om73VoICJecU+gRD fx6AIw2ycIdUDBYNXaLyQ2bRPVd0KLT3Z3E6+lBXo6dRo4dVHC2lYtPvlTPqpab/ Xc2PogI4t7kkANU6nXW37oGq8rMsEIW1Qjg16K1szgulRBnMlkPHaPJEvY= Received: from [127.0.0.1] (unknown [192.168.100.1]) by localhost.localdomain (Coremail) with SMTP id AQAAfwA3cUJ5V_Fp_B4DAA--.1799S2; Wed, 29 Apr 2026 08:57:29 +0800 (CST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v5 2/4] serial: 8250_dw: build Renesas RZN1 CPR value from DW_UART_CPR_* definitions From: Jia Wang To: Andy Shevchenko Cc: Jia Wang , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Greg Kroah-Hartman , Jiri Slaby , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , LKML , linux-serial , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org In-Reply-To: References: <20260428-ultrarisc-serial-v5-0-97de63b1e3eb@ultrarisc.com> <20260428-ultrarisc-serial-v5-2-97de63b1e3eb@ultrarisc.com> <23c80500-f2c1-0eb3-f640-00f7b108059b@linux.intel.com> <177736726936.2886867.7725295920724488690.b4-reply@b4> Date: Wed, 29 Apr 2026 08:56:45 +0800 Message-Id: <177742420562.3222151.9689419292413018986.b4-reply@b4> X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1777424206; l=1149; i=wangjia@ultrarisc.com; s=20260309; h=from:subject:message-id; bh=4czbswj4ht+A87lTkdcd08crGu9AEPernCdFv5ThrwI=; b=aleoixAjfRCIOq4JvlJdssuNfQRSsaLUgal5WrjqOTgcvlwjcpvsyS6aVVeeZSRyDQLO2GjPq FHF8Ra0GbLxDxcUS8OtHSaYRbFpqmV2H9q6SyPpx0Vc/piOJ0/gNUHC X-Developer-Key: i=wangjia@ultrarisc.com; a=ed25519; pk=XvYkrelqJIIzobY7j+nIg8rsfv5kzaOzuc1UPhd087U= X-CM-TRANSID:AQAAfwA3cUJ5V_Fp_B4DAA--.1799S2 X-Coremail-Antispam: 1UD129KBjvdXoW7XrykAF4fZr1rur18uF4fAFb_yoWDZrX_Ar W0kr4kua1kC39Fvw4DK3sIkws0krW7Zw4YqryrWF12kr9rX3s8Xwn5uasYgFnav3yIkr92 93WYqryF9F4qgjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJ3UbIYCTnIWIevJa73UjIFyTuYvj4RJUUUUUUUU X-CM-SenderInfo: pzdqwylld63zxwud2x1vfou0bp/1tbiAQAKEWnti78ACwA6sb On 2026-04-28 13:58 +0300, Andy Shevchenko wrote: > On Tue, Apr 28, 2026 at 05:07:49PM +0800, Jia Wang wrote: > > On 2026-04-28 11:41 +0300, Ilpo Järvinen wrote: > > > On Tue, 28 Apr 2026, Andy Shevchenko wrote: > > > > On Tue, Apr 28, 2026 at 01:26:27PM +0800, Jia Wang wrote: > > ... > > > > #define DW_UART_CPR_FIFO_MODE_FROM_SIZE(size) \ > > > ({ \ > > > typeof (size) __size = size; \ > > > \ > > > static_assert(IS_ALIGNED((__size), 16)); \ > > > static_assert(__size <= DW_UART_CPR_FIFO_MODE_MAX); \ > > > \ > > > FIELD_PREP_CONST(DW_UART_CPR_FIFO_MODE, __size / 16); \ > > > }) > > > > Thanks. I tried that approach, but the statement-expression form does > > not work in this case because the helper is used in static initializers. > > So I'll keep it as a plain expression macro for now, and just rework it > > into a cleaner multi-line form. > > Still you can move FIELD_PREP_CONST() into it. > Right, I'll move FIELD_PREP_CONST() in. By the way, does your Reviewed-by still hold? > -- > With Best Regards, > Andy Shevchenko > > > Best Regards, Jia Wang