Re: [PATCH 01/13] dt-bindings: iio: adc: add mt6323 PMIC AUXADC

Krzysztof Kozlowski
2026-05-06T13:08:16Z

On 06/05/2026 12:59, Roman Vivchar wrote:
> On Wednesday, May 6th, 2026 at 10:56 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
>> On 04/05/2026 20:24, Roman Vivchar via B4 Relay wrote:
>>> From: Roman Vivchar <rva333@protonmail.com>
>>>
>>> The MediaTek mt6323 PMIC includes an AUXADC used for battery voltage,
>>> temperature, and other internal measurements.
>>>
>
> ...
>
>>> +
>>> +properties:
>>> + compatible:
>>> + const: mediatek,mt6323-auxadc
>>> +
>>> + "#io-channel-cells":
>>> + const: 1
>>> +
>>> +required:
>>> + - compatible
>>> + - "#io-channel-cells"
>>
>>
>> This is heavily incomplete node... or unnecessarily split. Why it cannot
>> be part of parent binding? Or even parent node?
>>
>
> The MediaTek mt6359 AUXADC also has a very similar binding. The mt6323
> cannot be merged there because it has a different hardware.

I did not propose that, but since you are mentioning it: it is 100% the
same, so I do not understand why it cannot be merged. That would save
you a few questions :/

Best regards,
Krzysztof