Devicetree
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Gregor Herburger <gregor.herburger@linutronix.de>
Cc: Ray Jui <rjui@broadcom.com>, Eric Anholt <eric@anholt.net>,
	 Srinivas Kandagatla <srini@kernel.org>,
	devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	 Florian Fainelli <florian.fainelli@broadcom.com>,
	 Scott Branden <sbranden@broadcom.com>,
	Stefan Wahren <wahrenst@gmx.net>,
	 "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	 linux-rpi-kernel@lists.infradead.org,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-kernel@vger.kernel.org,  Kees Cook <kees@kernel.org>,
	 Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	 Conor Dooley <conor+dt@kernel.org>,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: raspberrypi,bcm2835-firmware: Add bcm2712-firmware compatible
Date: Tue, 05 May 2026 04:00:30 -0500	[thread overview]
Message-ID: <177797163082.1577508.5643979416868173390.robh@kernel.org> (raw)
In-Reply-To: <20260505-rpi-otp-driver-v2-1-e9176ec72837@linutronix.de>


On Tue, 05 May 2026 09:25:09 +0200, Gregor Herburger wrote:
> Add a compatible string for the bcm2712 firmware.
> 
> Signed-off-by: Gregor Herburger <gregor.herburger@linutronix.de>
> ---
>  .../devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml     | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml:26:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260505-rpi-otp-driver-v2-1-e9176ec72837@linutronix.de

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2026-05-05  9:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05  7:25 [PATCH v2 0/4] nvmem: Add Raspberry Pi OTP nvmem driver Gregor Herburger
2026-05-05  7:25 ` [PATCH v2 1/4] dt-bindings: raspberrypi,bcm2835-firmware: Add bcm2712-firmware compatible Gregor Herburger
2026-05-05  9:00   ` Rob Herring (Arm) [this message]
2026-05-05  7:25 ` [PATCH v2 2/4] nvmem: Add the Raspberry Pi OTP driver Gregor Herburger
2026-05-05  7:25 ` [PATCH v2 3/4] firmware: raspberrypi: register nvmem driver Gregor Herburger
2026-05-05  7:25 ` [PATCH v2 4/4] arm64: dts: broadcom: bcm2712: add bcm2712-firmware compatible Gregor Herburger
2026-05-05  9:21   ` Krzysztof Kozlowski
2026-05-05  9:22     ` Krzysztof Kozlowski
2026-05-05 15:07       ` Gregor Herburger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177797163082.1577508.5643979416868173390.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eric@anholt.net \
    --cc=florian.fainelli@broadcom.com \
    --cc=gregor.herburger@linutronix.de \
    --cc=gustavoars@kernel.org \
    --cc=kees@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=srini@kernel.org \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox