From: "Rob Herring (Arm)" <robh@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: stable@vger.kernel.org, devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH stable] scripts/dtc: Remove unused dts_version in dtc-lexer.l
Date: Tue, 5 May 2026 14:44:25 -0500 [thread overview]
Message-ID: <177801026318.3805973.8766967716439336298.robh@kernel.org> (raw)
In-Reply-To: <20260420-stable-dts-unused-but-set-global-v1-1-9bdfba6889bb@kernel.org>
On Mon, 20 Apr 2026 17:36:46 -0700, Nathan Chancellor wrote:
> This patch is for stable only. Commit 5a09df20872c ("scripts/dtc: Update
> to upstream version v1.7.2-69-g53373d135579") upstream applied it as
> part of a regular scripts/dtc sync, which may be unsuitable for older
> versions of stable where the warning it fixes is present.
>
> A recent strengthening of -Wunused-but-set-variable (enabled with -Wall)
> in clang under a new subwarning, -Wunused-but-set-global, points out an
> unused static global variable in dtc-lexer.lex.c (compiled from
> dtc-lexer.l):
>
> scripts/dtc/dtc-lexer.lex.c:641:12: warning: variable 'dts_version' set but not used [-Wunused-but-set-global]
> 641 | static int dts_version = 1;
> | ^
>
> Remove it to clear up the warning, as it is truly unused.
>
> Fixes: 658f29a51e98 ("of/flattree: Update dtc to current mainline.")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> This should apply cleanly to all supported stable branches.
> ---
> scripts/dtc/dtc-lexer.l | 3 ---
> 1 file changed, 3 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
prev parent reply other threads:[~2026-05-05 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 0:36 [PATCH stable] scripts/dtc: Remove unused dts_version in dtc-lexer.l Nathan Chancellor
2026-05-05 19:44 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177801026318.3805973.8766967716439336298.robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=nathan@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox