From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
To: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Chanhong Jung <happycpu@gmail.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] gpio: 74x164: seed the chain from DT at probe time
Date: Wed, 6 May 2026 10:09:00 +0200 [thread overview]
Message-ID: <177805490864.4124.505982607018854833.b4-ty@oss.qualcomm.com> (raw)
In-Reply-To: <20260429035134.1023330-1-happycpu@gmail.com>
On Wed, 29 Apr 2026 12:51:32 +0900, Chanhong Jung wrote:
> This v2 reuses the existing lines-initial-states bitmask, as suggested
> by Linus Walleij, instead of inventing a new property. That sidesteps
> both the v1 review concerns at once: there is no vendor-specific
> property to argue about, and the bit-N-equals-line-N convention is
> already documented for nxp,pcf8575.
>
> Background (carried over from v1):
> The 74HC595 / 74LVC594 family is push-pull output only. There is no
> read-back path, no defined power-on state for the parallel outputs, and
> __gen_74x164_write_config() always shifts the full chain on every
> transaction. The driver therefore publishes whatever sits in
> chip->buffer on the very first ->set() call, and today that buffer is
> fresh from kzalloc(), so all outputs come up low. On boards with active-
> low indicators or other signals whose initial level matters, the 0x00
> publish glitches the chain before user space (or gpio-leds default-state
> walking) gets a chance to run.
>
> [...]
Reluctantly applied.
[1/2] dt-bindings: gpio: fairchild,74hc595: add lines-initial-states property
https://git.kernel.org/brgl/c/d6e1a94888f5a4306c9998944a0f29f7bcd49411
[2/2] gpio: 74x164: support lines-initial-states for boot-time output state
https://git.kernel.org/brgl/c/cb77f8933467d08c8896674cd39ca98550a70fd6
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
next prev parent reply other threads:[~2026-05-06 8:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 16:05 [PATCH v1 0/2] gpio: 74x164: seed the chain from DT at probe time Chanhong Jung
2026-04-22 16:05 ` [PATCH v1 1/2] dt-bindings: gpio: fairchild,74hc595: add registers-default property Chanhong Jung
2026-04-23 8:59 ` Krzysztof Kozlowski
2026-04-23 10:33 ` Chanhong Jung
2026-04-28 8:40 ` Krzysztof Kozlowski
2026-04-28 9:07 ` Linus Walleij
2026-04-29 3:50 ` Chanhong Jung
2026-04-29 9:03 ` Bartosz Golaszewski
2026-05-05 9:45 ` Linus Walleij
2026-05-05 11:00 ` Bartosz Golaszewski
2026-05-05 20:24 ` Rob Herring
2026-04-22 16:05 ` [PATCH v1 2/2] gpio: 74x164: support 'registers-default' DT property for initial state Chanhong Jung
2026-04-29 3:51 ` [PATCH v2 0/2] gpio: 74x164: seed the chain from DT at probe time Chanhong Jung
2026-05-06 8:09 ` Bartosz Golaszewski [this message]
2026-04-29 3:51 ` [PATCH v2 1/2] dt-bindings: gpio: fairchild,74hc595: add lines-initial-states property Chanhong Jung
2026-04-30 12:08 ` Linus Walleij
2026-05-06 1:43 ` Rob Herring (Arm)
2026-04-29 3:51 ` [PATCH v2 2/2] gpio: 74x164: support lines-initial-states for boot-time output state Chanhong Jung
2026-04-30 12:09 ` Linus Walleij
2026-04-30 22:14 ` 정찬홍
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177805490864.4124.505982607018854833.b4-ty@oss.qualcomm.com \
--to=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=happycpu@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox