From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D4C436C0CF; Mon, 25 May 2026 10:43:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779705822; cv=none; b=pXjuNTxgc0xP8CbUK5e14iHU6wT+NSfSn2OEIY+Qns4tfLbFrd/SUwNUxOVQqeKVKYdRrFx1YOrsVUuj2avdFQ61M+80jO7artJUq+XwT7GgCupJZZeUWWhFeSm3ZeHHDcVdYrDPTYgCzX5ZaLyLs4JS2rZQj1yOIe0zAldjErQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779705822; c=relaxed/simple; bh=Fsxrsphi2dCnqeJa7qeWKFhhL3tAPkBX0WZVGYk+vwU=; h=Date:Content-Type:MIME-Version:From:Cc:To:In-Reply-To:References: Message-Id:Subject; b=nqjIHlpK3naLOkSoHhltTSlvXbtF1xatZjA25+opj5f/ISUNuUs8D7Hdv53Eq0LwAqdteK2zXwxLLfXU4PNVrYP0BO9TZ3F9YxyzLC8pYg/WefNclR/mjNHUQiwpatXTErlnai3otpZg6OliLUBLCIJrC5UZEsqfDz2tCbz3+Wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RSCuc8IE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RSCuc8IE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 236C81F000E9; Mon, 25 May 2026 10:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779705819; bh=srjqsu/CzyJPLcISmZtzPE6Hh7zthtKm0bgXC6QNd2o=; h=Date:From:Cc:To:In-Reply-To:References:Subject; b=RSCuc8IEgkJu8PXT7ayTk7inXAFejDcQRYa1aZbfh9Zr7qEit8g4+yFvXyD2Ln7+g 9OV4t9U9fgIFBRXpOm69/x6mEvNakoihDrzcpmp8uGbVbep6Fnk6vMHpqVDhJ2Wphv 4g2O1dpHN09pOAyPNPFRKxXj08oPgcy/B9S+ak78QFmJan8Cno182lbgdTpg8mx8Ef QdXLuCrkKju+UctYLxHWfHhC/0FeZyjCsxNbnGJF1UNFD7EgOwQWw7DziirHb+WI4M TGXJD+thL/kKPrd3uumOvJ/RTcdUn8HFN27gDneoTjGrons6jncQ1neK98OezxyDMx e3mzXtiqN9dbA== Date: Mon, 25 May 2026 05:43:38 -0500 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Rob Herring (Arm)" Cc: Sascha Hauer , imx@lists.linux.dev, Conor Dooley , Guoniu Zhou , linux-media@vger.kernel.org, Mauro Carvalho Chehab , Laurent Pinchart , linux-kernel@vger.kernel.org, Shawn Guo , Fabio Estevam , Frank Li , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Frank Li , devicetree@vger.kernel.org, Pengutronix Kernel Team To: Guoniu Zhou In-Reply-To: <20260525-csi_formatter-v8-1-6b646231224b@oss.nxp.com> References: <20260525-csi_formatter-v8-0-6b646231224b@oss.nxp.com> <20260525-csi_formatter-v8-1-6b646231224b@oss.nxp.com> Message-Id: <177970581844.3566674.15613967035246417411.robh@kernel.org> Subject: Re: [PATCH v8 1/2] media: dt-bindings: Add CSI Pixel Formatter DT bindings On Mon, 25 May 2026 16:12:22 +0800, Guoniu Zhou wrote: > From: Guoniu Zhou > > The i.MX95 CSI pixel formatting module uses packet info, pixel and > non-pixel data from the CSI-2 host controller and reformat them to > match Pixel Link(PL) definition. > > Reviewed-by: Frank Li > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Guoniu Zhou > --- > Changes in v8: > - Use standard port reference instead of video-interfaces.yaml > - Add parent syscon node in example to show device integration > - Add required constraints for port@0 and port@1 in ports node > > Changes in v7: > - Change compatible to imx95-csi-formatter as IP is i.MX95 specific per Marco's suggestion > Link: https://lore.kernel.org/linux-media/20260511-csi_formatter-v6-0-01028e312e2b@oss.nxp.com/T/#mcd135b3de179b3cb69daa1fd6e0e8e27c85b3332 > --- > .../bindings/media/fsl,imx95-csi-formatter.yaml | 92 ++++++++++++++++++++++ > 1 file changed, 92 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.example.dtb: syscon@4ac10000 (nxp,imx95-camera-csr): '#address-cells', '#size-cells', 'formatter@20' do not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/clock/nxp,imx95-blk-ctl.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.example.dtb: syscon@4ac10000 (nxp,imx95-camera-csr): reg: [[0, 1254162432], [0, 65536]] is too long from schema $id: http://devicetree.org/schemas/clock/nxp,imx95-blk-ctl.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.example.dtb: syscon@4ac10000 (nxp,imx95-camera-csr): '#clock-cells' is a required property from schema $id: http://devicetree.org/schemas/clock/nxp,imx95-blk-ctl.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.example.dtb: syscon@4ac10000 (nxp,imx95-camera-csr): 'power-domains' is a required property from schema $id: http://devicetree.org/schemas/clock/nxp,imx95-blk-ctl.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.example.dtb: syscon@4ac10000 (nxp,imx95-camera-csr): 'clocks' is a required property from schema $id: http://devicetree.org/schemas/clock/nxp,imx95-blk-ctl.yaml doc reference errors (make refcheckdocs): See https://patchwork.kernel.org/project/devicetree/patch/20260525-csi_formatter-v8-1-6b646231224b@oss.nxp.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.