Devicetree
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: Saravana Kannan <saravanak@kernel.org>,
	devicetree@vger.kernel.org, linux-hardening@vger.kernel.org,
	Arnd Bergmann <arnd@kernel.org>,
	linux-kernel@vger.kernel.org, Kees Cook <kees@kernel.org>
Subject: Re: [PATCH next v2] drivers/of/overlay: Use memcpy() to copy known length strings
Date: Wed, 10 Jun 2026 13:48:41 -0500	[thread overview]
Message-ID: <178111732108.625216.12806954968096989058.robh@kernel.org> (raw)
In-Reply-To: <20260608185121.22331-1-david.laight.linux@gmail.com>


On Mon, 08 Jun 2026 19:51:21 +0100, David Laight wrote:
> Avoid calls to strcpy().
> The lengths of the strings have been used for the kzalloc(), replace
> the strcpy() calls with memcpy() using the known lengths.
> 
> Signed-off-by: David Laight <david.laight.linux@gmail.com>
> ---
> 
> v2: Improve commit message
> 
> This is one of a group of patches that remove potentially unbounded
> strcpy() calls.
> 
> They are mostly replaced by strscpy() or, when strlen() has just been
> called, with memcpy() (usually including the '\0').
> 
> Calls with copy string literals into arrays are left unchanged.
> They are safe and easily detected as such.
> 
> The changes were made by getting the compiler to detect the calls and
> then fixing the code by hand.
> 
> Note that all the changes are only compile tested.
> 
> Some Makefiles were changed to allow files to contain strcpy().
> As well as 'difficult to fix' files, this included 'show' functions
> as they really need to use sysfs_emit() or seq_printf().
> 
> All the patches are being sent individually to avoid very long cc lists.
> Apologies for the terse commit messages and likely unexpected tags.
> (There are about 100 patches in total.)
> 
>  drivers/of/overlay.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied, thanks!


      reply	other threads:[~2026-06-10 18:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08 18:51 [PATCH next v2] drivers/of/overlay: Use memcpy() to copy known length strings David Laight
2026-06-10 18:48 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178111732108.625216.12806954968096989058.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=arnd@kernel.org \
    --cc=david.laight.linux@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saravanak@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox