Devicetree
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Claudiu Beznea <claudiu.beznea+renesas@tuxon.dev>
Cc: biju.das.jz@bp.renesas.com, linux-can@vger.kernel.org,
	mturquette@baylibre.com, claudiu.beznea@tuxon.dev,
	devicetree@vger.kernel.org, conor+dt@kernel.org,
	linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	fabrizio.castro.jz@renesas.com, linux-kernel@vger.kernel.org,
	magnus.damm@gmail.com, bmasney@redhat.com, mailhol@kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
	mkl@pengutronix.de, geert+renesas@glider.be, krzk+dt@kernel.org,
	sboyd@kernel.org
Subject: Re: [PATCH v3 2/8] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S SoC
Date: Wed, 22 Jul 2026 12:12:03 -0500	[thread overview]
Message-ID: <178474032283.1138528.11209003528871074463.robh@kernel.org> (raw)
In-Reply-To: <20260714173315.1981708-3-claudiu.beznea+renesas@tuxon.dev>


On Tue, 14 Jul 2026 20:33:09 +0300, Claudiu Beznea wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> The CAN FD controller found on the Renesas RZ/G3S SoC is largely compatible
> with the variant present on the RZ/G3E SoC. The main differences are:
> - the RZ/G3S provides only two CAN FD channels
> - the RZ/G3S supports only CAN FD operation; the Channel n CAN FD
>   Configuration Register does not implement the bits used to select
>   classical CAN-only mode (bit 30) or CAN FD-only mode (bit 28);
>   consequently, bit 31 (CAN FD Frame Distinction Enable) of the same
>   register is also not implemented
> - some bits in several registers (mainly reserved or status bits) are
>   read-write on the RZ/G3S but read-only on the RZ/G3E; their behavior is
>   otherwise identical: the bits read back as 0 on both SoCs and software
>   is allowed to write only 0 to them on the RZ/G3S
> - the RZ/G3S provides 256 acceptance filters, compared to 768 on the
>   RZ/G3E
> - the RZ/G3S can use PCLK clock as the CAN FD clock source through an
>   internal clock divider, while also supporting an external CAN FD clock
>   source
> 
> Since:
> - the SoC clock generator provides to the CAN IP only the peripheral and
>   the RAM clocks
> - when sourced from the peripheral clock, the CAN-FD clock is obtained
>   inside the IP itself by dividing the peripheral clock
> - the assigned-clocks and assigned-clock-rates properties are specific to
>   the CAN-FD clock
> the assigned-clocks and assigned-clock-rates properties were dropped from
> the required properties list of the Renesas RZ/G3S SoC.
> 
> Add documentation for the Renesas RZ/G3S SoC.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
> 
> Changes in v3:
> - updated the patch description to reflect RZ/G3S has 256 acceptance
>   filters and RZ/G3E has 768 acceptance filters
> - kept compatibles alphanumerically sorted
> 
> Changes in v2:
> - forbid renesas,no-can-fd and renesas,fd-only since the IP supports
>   only CAN-FD; for this didn't collect Biju's tag
> 
>  .../bindings/net/can/renesas,rcar-canfd.yaml  | 20 +++++++++++++++++--
>  1 file changed, 18 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


  reply	other threads:[~2026-07-22 17:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 17:33 [PATCH v3 0/8] can: rcar_canfd: Add support for Renesas RZ/G3S Claudiu Beznea
2026-07-14 17:33 ` [PATCH v3 1/8] clk: r9a08g045-cpg: Add clocks and resets for CAN-FD Claudiu Beznea
2026-07-15  8:58   ` Geert Uytterhoeven
2026-07-15 10:27     ` Claudiu Beznea
2026-07-14 17:33 ` [PATCH v3 2/8] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S SoC Claudiu Beznea
2026-07-22 17:12   ` Rob Herring (Arm) [this message]
2026-07-14 17:33 ` [PATCH v3 3/8] can: rcar_canfd: Fix typos in macro names Claudiu Beznea
2026-07-14 17:33 ` [PATCH v3 4/8] can: rcar_canfd: Allow the CAN FD clock to be sourced from fck Claudiu Beznea
2026-07-14 17:47   ` sashiko-bot
2026-07-14 17:33 ` [PATCH v3 5/8] can: rcar_canfd: Do not set registers selecting the CAN mode Claudiu Beznea
2026-07-14 17:33 ` [PATCH v3 6/8] can: rcar_canfd: Add support for Renesas RZ/G3S Claudiu Beznea
2026-07-14 17:49   ` sashiko-bot
2026-07-14 17:33 ` [PATCH v3 7/8] arm64: dts: renesas: r9a08g045: Add CAN-FD node Claudiu Beznea
2026-07-14 17:33 ` [PATCH v3 8/8] arm64: dts: renesas: rzg3s-smarc: Enable CAN-FD Claudiu Beznea
2026-07-14 17:54   ` sashiko-bot
2026-07-15  9:01 ` [PATCH v3 0/8] can: rcar_canfd: Add support for Renesas RZ/G3S Geert Uytterhoeven
2026-08-10 13:00 ` Claudiu Beznea
2026-08-17 16:59   ` Marc Kleine-Budde
2026-08-17 21:51     ` Wolfram Sang
2026-08-18 11:30     ` claudiu beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178474032283.1138528.11209003528871074463.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=bmasney@redhat.com \
    --cc=claudiu.beznea+renesas@tuxon.dev \
    --cc=claudiu.beznea.uj@bp.renesas.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mailhol@kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox