Devicetree
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Eduard Bostina <egbostina@gmail.com>
Cc: daniel.baluta@nxp.com, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 goledhruva@gmail.com, m-chawdhry@ti.com,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Linus Walleij <linusw@kernel.org>,
	 linux-gpio@vger.kernel.org, simona.toaca@nxp.com,
	 Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH] dt-bindings: pinctrl: Convert TI DA850 pupd to DT schema
Date: Tue, 11 Aug 2026 05:47:11 -0500	[thread overview]
Message-ID: <178644523153.1349816.655993681272679789.robh@kernel.org> (raw)
In-Reply-To: <20260811092057.687155-1-egbostina@gmail.com>


On Tue, 11 Aug 2026 09:20:57 +0000, Eduard Bostina wrote:
> Convert the Texas Instruments DA850/OMAP-L138/AM18x pullup/down
> controller bindings to DT schema.
> 
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> ---
>  .../bindings/pinctrl/ti,da850-pupd.txt        | 55 --------------
>  .../bindings/pinctrl/ti,da850-pupd.yaml       | 74 +++++++++++++++++++
>  2 files changed, 74 insertions(+), 55 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/pinctrl/ti,da850-pupd.txt
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/ti,da850-pupd.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/pinctrl/ti,da850-pupd.example.dtb: pin-controller@22c00c (ti,da850-pupd): bias-groups:phandle: 1 is valid under each of {'required': ['drive-open-drain']}, {'required': ['drive-push-pull']}, {'required': ['drive-open-source']}
	from schema $id: http://devicetree.org/schemas/pinctrl/ti,da850-pupd.yaml
Documentation/devicetree/bindings/pinctrl/ti,da850-pupd.example.dtb: pin-controller@22c00c (ti,da850-pupd): bias-groups:phandle: 1 is valid under each of {'required': ['bias-bus-hold']}, {'required': ['bias-pull-up']}, {'required': ['bias-pull-down']}, {'required': ['bias-pull-pin-default']}, {'required': ['bias-disable']}
	from schema $id: http://devicetree.org/schemas/pinctrl/ti,da850-pupd.yaml
Documentation/devicetree/bindings/pinctrl/ti,da850-pupd.example.dtb: pin-controller@22c00c (ti,da850-pupd): bias-groups:phandle: 1 is not of type 'object'
	from schema $id: http://devicetree.org/schemas/pinctrl/ti,da850-pupd.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260811092057.687155-1-egbostina@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


      reply	other threads:[~2026-08-11 10:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  9:20 [PATCH] dt-bindings: pinctrl: Convert TI DA850 pupd to DT schema Eduard Bostina
2026-08-11 10:47 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178644523153.1349816.655993681272679789.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=egbostina@gmail.com \
    --cc=goledhruva@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=simona.toaca@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox