Devicetree
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Eduard Bostina <egbostina@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	daniel.baluta@nxp.com, "Uwe Kleine-König" <ukleinek@kernel.org>,
	linux-pwm@vger.kernel.org, m-chawdhry@ti.com,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	goledhruva@gmail.com, simona.toaca@nxp.com,
	"Conor Dooley" <conor+dt@kernel.org>
Subject: Re: [PATCH v2] dt-bindings: pwm: Convert TI PWM Subsystem to DT schema
Date: Wed, 12 Aug 2026 14:28:33 -0500	[thread overview]
Message-ID: <178656291274.677408.8543317562709598309.robh@kernel.org> (raw)
In-Reply-To: <20260812094420.1057067-1-egbostina@gmail.com>


On Wed, 12 Aug 2026 09:44:20 +0000, Eduard Bostina wrote:
> Convert the Texas Instruments SoC PWM Subsystem bindings
> to DT schema.
> 
> During the conversion, the following updates were made:
> - 'counter' node was added to the allowed child nodes
>   list to resolve dtbs_check warnings. Some eqep nodes
>   use 'counter' instead of 'eqep'.
> 
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> ---
> Changes in v2:
> - Renamed the file to ti,am33xx-pwmss.yaml to match the base compatible.
> - Required a 'compatible' property in the child nodes.
> - Reduced the binding to a single example and included the PWM child
>   nodes (ECAP, EQEP, EHRPWM) in it.
> 
> Link to v1: https://lore.kernel.org/all/2026081109d-up2208.687731-1-egbostina@gmail.com/
> 
>  .../devicetree/bindings/pwm/pwm-tipwmss.txt   | 58 --------------
>  .../bindings/pwm/ti,am33xx-pwmss.yaml         | 76 +++++++++++++++++++
>  2 files changed, 76 insertions(+), 58 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-tipwmss.txt
>  create mode 100644 Documentation/devicetree/bindings/pwm/ti,am33xx-pwmss.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/pwm/ti,am33xx-pwmss.example.dtb: pwm@48300100 (ti,am3352-ecap): 'clocks' is a required property
	from schema $id: http://devicetree.org/schemas/pwm/pwm-tiecap.yaml
Documentation/devicetree/bindings/pwm/ti,am33xx-pwmss.example.dtb: pwm@48300100 (ti,am3352-ecap): 'clock-names' is a required property
	from schema $id: http://devicetree.org/schemas/pwm/pwm-tiecap.yaml
Documentation/devicetree/bindings/pwm/ti,am33xx-pwmss.example.dtb: counter@48300180 (ti,am3352-eqep): 'oneOf' conditional failed, one must be fixed:
	'interrupts' is a required property
	'interrupts-extended' is a required property
	from schema $id: http://devicetree.org/schemas/counter/ti-eqep.yaml
Documentation/devicetree/bindings/pwm/ti,am33xx-pwmss.example.dtb: counter@48300180 (ti,am3352-eqep): 'clocks' is a required property
	from schema $id: http://devicetree.org/schemas/counter/ti-eqep.yaml
Documentation/devicetree/bindings/pwm/ti,am33xx-pwmss.example.dtb: pwm@48300200 (ti,am3352-ehrpwm): 'clocks' is a required property
	from schema $id: http://devicetree.org/schemas/pwm/pwm-tiehrpwm.yaml
Documentation/devicetree/bindings/pwm/ti,am33xx-pwmss.example.dtb: pwm@48300200 (ti,am3352-ehrpwm): 'clock-names' is a required property
	from schema $id: http://devicetree.org/schemas/pwm/pwm-tiehrpwm.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260812094420.1057067-1-egbostina@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2026-08-12 19:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12  9:44 [PATCH v2] dt-bindings: pwm: Convert TI PWM Subsystem to DT schema Eduard Bostina
2026-08-12  9:53 ` sashiko-bot
2026-08-12 19:28 ` Rob Herring (Arm) [this message]
2026-08-12 19:35 ` Rob Herring (Arm)
2026-08-12 19:44   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178656291274.677408.8543317562709598309.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=egbostina@gmail.com \
    --cc=goledhruva@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=simona.toaca@nxp.com \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox