* [PATCH 01/17] dt-bindings: display: renesas: du: Increase indent in output table
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
@ 2018-04-26 16:53 ` Kieran Bingham
2018-04-26 20:08 ` Laurent Pinchart
2018-04-26 16:53 ` [PATCH 02/17] dt-bindings: display: renesas: du: Document the R8A77965 bindings Kieran Bingham
` (10 subsequent siblings)
11 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
David Airlie, open list, open list:DRM DRIVERS FOR RENESAS,
Rob Herring, Kieran Bingham, Laurent Pinchart
The DU output table lists the port combinations for each supported DU
type. Newer models of R-Car Gen3 platforms have an increased string
length.
Increase the table indentation in preparation for supporting new target
types.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
.../bindings/display/renesas,du.txt | 26 +++++++++----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index c9cd17f99702..a36a6e7ee54f 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -47,20 +47,20 @@ bindings specified in Documentation/devicetree/bindings/graph.txt.
The following table lists for each supported model the port number
corresponding to each DU output.
- Port0 Port1 Port2 Port3
+ Port0 Port1 Port2 Port3
-----------------------------------------------------------------------------
- R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - -
- R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
- R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
- R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
- R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - -
- R8A7792 (R-Car V2H) DPAD 0 DPAD 1 - -
- R8A7793 (R-Car M2-N) DPAD 0 LVDS 0 - -
- R8A7794 (R-Car E2) DPAD 0 DPAD 1 - -
- R8A7795 (R-Car H3) DPAD 0 HDMI 0 HDMI 1 LVDS 0
- R8A7796 (R-Car M3-W) DPAD 0 HDMI 0 LVDS 0 -
- R8A77970 (R-Car V3M) DPAD 0 LVDS 0 - -
- R8A77995 (R-Car D3) DPAD 0 LVDS 0 LVDS 1 -
+ R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - -
+ R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
+ R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
+ R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
+ R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - -
+ R8A7792 (R-Car V2H) DPAD 0 DPAD 1 - -
+ R8A7793 (R-Car M2-N) DPAD 0 LVDS 0 - -
+ R8A7794 (R-Car E2) DPAD 0 DPAD 1 - -
+ R8A7795 (R-Car H3) DPAD 0 HDMI 0 HDMI 1 LVDS 0
+ R8A7796 (R-Car M3-W) DPAD 0 HDMI 0 LVDS 0 -
+ R8A77970 (R-Car V3M) DPAD 0 LVDS 0 - -
+ R8A77995 (R-Car D3) DPAD 0 LVDS 0 LVDS 1 -
Example: R8A7795 (R-Car H3) ES2.0 DU
--
2.17.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 01/17] dt-bindings: display: renesas: du: Increase indent in output table
2018-04-26 16:53 ` [PATCH 01/17] dt-bindings: display: renesas: du: Increase indent in output table Kieran Bingham
@ 2018-04-26 20:08 ` Laurent Pinchart
0 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2018-04-26 20:08 UTC (permalink / raw)
To: Kieran Bingham
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
David Airlie, open list, open list:DRM DRIVERS FOR RENESAS,
linux-renesas-soc, Rob Herring
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:30 EEST Kieran Bingham wrote:
> The DU output table lists the port combinations for each supported DU
> type. Newer models of R-Car Gen3 platforms have an increased string
> length.
>
> Increase the table indentation in preparation for supporting new target
> types.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> .../bindings/display/renesas,du.txt | 26 +++++++++----------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> b/Documentation/devicetree/bindings/display/renesas,du.txt index
> c9cd17f99702..a36a6e7ee54f 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -47,20 +47,20 @@ bindings specified in
> Documentation/devicetree/bindings/graph.txt. The following table lists for
> each supported model the port number corresponding to each DU output.
>
> - Port0 Port1 Port2 Port3
> + Port0 Port1 Port2 Port3
> ---------------------------------------------------------------------------
> -- - R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - - -
> R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - - -
> R8A7779 (R-Car H1) DPAD 0 DPAD 1 - - -
> R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 - -
> R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - - -
> R8A7792 (R-Car V2H) DPAD 0 DPAD 1 - - -
> R8A7793 (R-Car M2-N) DPAD 0 LVDS 0 - - -
> R8A7794 (R-Car E2) DPAD 0 DPAD 1 - - -
> R8A7795 (R-Car H3) DPAD 0 HDMI 0 HDMI 1 LVDS 0 -
> R8A7796 (R-Car M3-W) DPAD 0 HDMI 0 LVDS 0 - -
> R8A77970 (R-Car V3M) DPAD 0 LVDS 0 - - -
> R8A77995 (R-Car D3) DPAD 0 LVDS 0 LVDS 1 - +
> R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - - +
> R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - - +
> R8A7779 (R-Car H1) DPAD 0 DPAD 1 - - +
> R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 - +
> R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - - +
> R8A7792 (R-Car V2H) DPAD 0 DPAD 1 - - +
> R8A7793 (R-Car M2-N) DPAD 0 LVDS 0 - - +
> R8A7794 (R-Car E2) DPAD 0 DPAD 1 - - +
> R8A7795 (R-Car H3) DPAD 0 HDMI 0 HDMI 1 LVDS 0
> + R8A7796 (R-Car M3-W) DPAD 0 HDMI 0 LVDS 0 - +
> R8A77970 (R-Car V3M) DPAD 0 LVDS 0 - - +
> R8A77995 (R-Car D3) DPAD 0 LVDS 0 LVDS 1 -
>
>
> Example: R8A7795 (R-Car H3) ES2.0 DU
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 02/17] dt-bindings: display: renesas: du: Document the R8A77965 bindings
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
2018-04-26 16:53 ` [PATCH 01/17] dt-bindings: display: renesas: du: Increase indent in output table Kieran Bingham
@ 2018-04-26 16:53 ` Kieran Bingham
2018-04-26 16:57 ` Kieran Bingham
2018-04-26 16:53 ` [PATCH 08/17] arm64: dts: r8a77965: Provide sysc header definitions Kieran Bingham
` (9 subsequent siblings)
11 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
David Airlie, open list, open list:DRM DRIVERS FOR RENESAS,
Rob Herring, Kieran Bingham, Laurent Pinchart
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index a36a6e7ee54f..7c6854bd0a04 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -13,6 +13,7 @@ Required Properties:
- "renesas,du-r8a7794" for R8A7794 (R-Car E2) compatible DU
- "renesas,du-r8a7795" for R8A7795 (R-Car H3) compatible DU
- "renesas,du-r8a7796" for R8A7796 (R-Car M3-W) compatible DU
+ - "renesas,du-r8a77965" for R8A77965 (R-Car M3-N) compatible DU
- "renesas,du-r8a77970" for R8A77970 (R-Car V3M) compatible DU
- "renesas,du-r8a77995" for R8A77995 (R-Car D3) compatible DU
@@ -59,6 +60,7 @@ corresponding to each DU output.
R8A7794 (R-Car E2) DPAD 0 DPAD 1 - -
R8A7795 (R-Car H3) DPAD 0 HDMI 0 HDMI 1 LVDS 0
R8A7796 (R-Car M3-W) DPAD 0 HDMI 0 LVDS 0 -
+ R8A77965 (R-Car M3-N) DPAD 0 HDMI 0 LVDS 0 -
R8A77970 (R-Car V3M) DPAD 0 LVDS 0 - -
R8A77995 (R-Car D3) DPAD 0 LVDS 0 LVDS 1 -
--
2.17.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 02/17] dt-bindings: display: renesas: du: Document the R8A77965 bindings
2018-04-26 16:53 ` [PATCH 02/17] dt-bindings: display: renesas: du: Document the R8A77965 bindings Kieran Bingham
@ 2018-04-26 16:57 ` Kieran Bingham
2018-04-26 20:10 ` Laurent Pinchart
0 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:57 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
David Airlie, open list, open list:DRM DRIVERS FOR RENESAS,
Rob Herring, Laurent Pinchart
Ahem - this one seems to have lost it's commit message.
Apologies :)
--
Kieran
On 26/04/18 17:53, Kieran Bingham wrote:
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
> index a36a6e7ee54f..7c6854bd0a04 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -13,6 +13,7 @@ Required Properties:
> - "renesas,du-r8a7794" for R8A7794 (R-Car E2) compatible DU
> - "renesas,du-r8a7795" for R8A7795 (R-Car H3) compatible DU
> - "renesas,du-r8a7796" for R8A7796 (R-Car M3-W) compatible DU
> + - "renesas,du-r8a77965" for R8A77965 (R-Car M3-N) compatible DU
> - "renesas,du-r8a77970" for R8A77970 (R-Car V3M) compatible DU
> - "renesas,du-r8a77995" for R8A77995 (R-Car D3) compatible DU
>
> @@ -59,6 +60,7 @@ corresponding to each DU output.
> R8A7794 (R-Car E2) DPAD 0 DPAD 1 - -
> R8A7795 (R-Car H3) DPAD 0 HDMI 0 HDMI 1 LVDS 0
> R8A7796 (R-Car M3-W) DPAD 0 HDMI 0 LVDS 0 -
> + R8A77965 (R-Car M3-N) DPAD 0 HDMI 0 LVDS 0 -
> R8A77970 (R-Car V3M) DPAD 0 LVDS 0 - -
> R8A77995 (R-Car D3) DPAD 0 LVDS 0 LVDS 1 -
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 02/17] dt-bindings: display: renesas: du: Document the R8A77965 bindings
2018-04-26 16:57 ` Kieran Bingham
@ 2018-04-26 20:10 ` Laurent Pinchart
2018-04-27 8:40 ` Kieran Bingham
0 siblings, 1 reply; 30+ messages in thread
From: Laurent Pinchart @ 2018-04-26 20:10 UTC (permalink / raw)
To: kieran.bingham
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
David Airlie, open list, open list:DRM DRIVERS FOR RENESAS,
linux-renesas-soc, Rob Herring
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:57:32 EEST Kieran Bingham wrote:
> Ahem - this one seems to have lost it's commit message.
>
> Apologies :)
Apart from that, this looks good to me.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree with the commit message
Document the M3-N (r8a77965) SoC in the R-Car DU bindings
Let me know if you would like a different message.
> On 26/04/18 17:53, Kieran Bingham wrote:
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> > ---
> >
> > Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> > b/Documentation/devicetree/bindings/display/renesas,du.txt index
> > a36a6e7ee54f..7c6854bd0a04 100644
> > --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> >
> > @@ -13,6 +13,7 @@ Required Properties:
> > - "renesas,du-r8a7794" for R8A7794 (R-Car E2) compatible DU
> > - "renesas,du-r8a7795" for R8A7795 (R-Car H3) compatible DU
> > - "renesas,du-r8a7796" for R8A7796 (R-Car M3-W) compatible DU
> > + - "renesas,du-r8a77965" for R8A77965 (R-Car M3-N) compatible DU
> > - "renesas,du-r8a77970" for R8A77970 (R-Car V3M) compatible DU
> > - "renesas,du-r8a77995" for R8A77995 (R-Car D3) compatible DU
> >
> > @@ -59,6 +60,7 @@ corresponding to each DU output.
> >
> > R8A7794 (R-Car E2) DPAD 0 DPAD 1 - -
> > R8A7795 (R-Car H3) DPAD 0 HDMI 0 HDMI 1 LVDS
> > 0
> > R8A7796 (R-Car M3-W) DPAD 0 HDMI 0 LVDS 0 -
> > + R8A77965 (R-Car M3-N) DPAD 0 HDMI 0 LVDS 0 -
> > R8A77970 (R-Car V3M) DPAD 0 LVDS 0 - -
> > R8A77995 (R-Car D3) DPAD 0 LVDS 0 LVDS 1 -
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 02/17] dt-bindings: display: renesas: du: Document the R8A77965 bindings
2018-04-26 20:10 ` Laurent Pinchart
@ 2018-04-27 8:40 ` Kieran Bingham
0 siblings, 0 replies; 30+ messages in thread
From: Kieran Bingham @ 2018-04-27 8:40 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
David Airlie, open list, open list:DRM DRIVERS FOR RENESAS,
linux-renesas-soc, Rob Herring
[-- Attachment #1.1.1: Type: text/plain, Size: 2231 bytes --]
Hi Laurent,
On 26/04/18 21:10, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thursday, 26 April 2018 19:57:32 EEST Kieran Bingham wrote:
>> Ahem - this one seems to have lost it's commit message.
>>
>> Apologies :)
>
> Apart from that, this looks good to me.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> and applied to my tree with the commit message
>
> Document the M3-N (r8a77965) SoC in the R-Car DU bindings
>
That's perfect, thanks - and saves me sending a v1.1
Regards
Kieran
> Let me know if you would like a different message.
>
>> On 26/04/18 17:53, Kieran Bingham wrote:
>>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>> ---
>>>
>>> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
>>> b/Documentation/devicetree/bindings/display/renesas,du.txt index
>>> a36a6e7ee54f..7c6854bd0a04 100644
>>> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
>>> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
>>>
>>> @@ -13,6 +13,7 @@ Required Properties:
>>> - "renesas,du-r8a7794" for R8A7794 (R-Car E2) compatible DU
>>> - "renesas,du-r8a7795" for R8A7795 (R-Car H3) compatible DU
>>> - "renesas,du-r8a7796" for R8A7796 (R-Car M3-W) compatible DU
>>> + - "renesas,du-r8a77965" for R8A77965 (R-Car M3-N) compatible DU
>>> - "renesas,du-r8a77970" for R8A77970 (R-Car V3M) compatible DU
>>> - "renesas,du-r8a77995" for R8A77995 (R-Car D3) compatible DU
>>>
>>> @@ -59,6 +60,7 @@ corresponding to each DU output.
>>>
>>> R8A7794 (R-Car E2) DPAD 0 DPAD 1 - -
>>> R8A7795 (R-Car H3) DPAD 0 HDMI 0 HDMI 1 LVDS
>>> 0
>>> R8A7796 (R-Car M3-W) DPAD 0 HDMI 0 LVDS 0 -
>>> + R8A77965 (R-Car M3-N) DPAD 0 HDMI 0 LVDS 0 -
>>> R8A77970 (R-Car V3M) DPAD 0 LVDS 0 - -
>>> R8A77995 (R-Car D3) DPAD 0 LVDS 0 LVDS 1 -
>
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 08/17] arm64: dts: r8a77965: Provide sysc header definitions
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
2018-04-26 16:53 ` [PATCH 01/17] dt-bindings: display: renesas: du: Increase indent in output table Kieran Bingham
2018-04-26 16:53 ` [PATCH 02/17] dt-bindings: display: renesas: du: Document the R8A77965 bindings Kieran Bingham
@ 2018-04-26 16:53 ` Kieran Bingham
2018-04-26 20:53 ` Laurent Pinchart
2018-04-26 16:53 ` [PATCH 09/17] arm64: dts: r8a77965: Use the correct CPG header Kieran Bingham
` (8 subsequent siblings)
11 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Kieran Bingham, Simon Horman, Magnus Damm, Rob Herring,
Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT AARCH64 ARCHITECTURE, open list
Include the r8a77965-sysc header to provide power domain enumerations
and definitions.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index b12f41755aea..02de36b9e581 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -10,6 +10,7 @@
#include <dt-bindings/clock/renesas-cpg-mssr.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/power/r8a77965-sysc.h>
#define CPG_AUDIO_CLK_I 10
--
2.17.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 08/17] arm64: dts: r8a77965: Provide sysc header definitions
2018-04-26 16:53 ` [PATCH 08/17] arm64: dts: r8a77965: Provide sysc header definitions Kieran Bingham
@ 2018-04-26 20:53 ` Laurent Pinchart
0 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2018-04-26 20:53 UTC (permalink / raw)
To: Kieran Bingham
Cc: linux-renesas-soc, Simon Horman, Magnus Damm, Rob Herring,
Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:37 EEST Kieran Bingham wrote:
> Include the r8a77965-sysc header to provide power domain enumerations
> and definitions.
I think you can squash this with the first patch that will use the header.
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
> b12f41755aea..02de36b9e581 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -10,6 +10,7 @@
>
> #include <dt-bindings/clock/renesas-cpg-mssr.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/power/r8a77965-sysc.h>
>
> #define CPG_AUDIO_CLK_I 10
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 09/17] arm64: dts: r8a77965: Use the correct CPG header
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
` (2 preceding siblings ...)
2018-04-26 16:53 ` [PATCH 08/17] arm64: dts: r8a77965: Provide sysc header definitions Kieran Bingham
@ 2018-04-26 16:53 ` Kieran Bingham
2018-04-26 21:16 ` Laurent Pinchart
2018-04-26 16:53 ` [PATCH 10/17] arm64: dts: r8a77965: Add FCPF and FCPV instances Kieran Bingham
` (7 subsequent siblings)
11 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Kieran Bingham, Simon Horman, Magnus Damm, Rob Herring,
Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT AARCH64 ARCHITECTURE, open list
The SoC dtsi includes the generic renesas-cpg-mssr header, which does
not contain all of the relevant SoC specific definitions.
Adapt this to be the r8a77965 specific header.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 02de36b9e581..894903a59bdc 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -8,7 +8,7 @@
* Copyright (C) 2016 Renesas Electronics Corp.
*/
-#include <dt-bindings/clock/renesas-cpg-mssr.h>
+#include <dt-bindings/clock/r8a77965-cpg-mssr.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/power/r8a77965-sysc.h>
--
2.17.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 09/17] arm64: dts: r8a77965: Use the correct CPG header
2018-04-26 16:53 ` [PATCH 09/17] arm64: dts: r8a77965: Use the correct CPG header Kieran Bingham
@ 2018-04-26 21:16 ` Laurent Pinchart
0 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2018-04-26 21:16 UTC (permalink / raw)
To: Kieran Bingham
Cc: linux-renesas-soc, Simon Horman, Magnus Damm, Rob Herring,
Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:38 EEST Kieran Bingham wrote:
> The SoC dtsi includes the generic renesas-cpg-mssr header, which does
> not contain all of the relevant SoC specific definitions.
>
> Adapt this to be the r8a77965 specific header.
I would squash this with patch 13/17.
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
> 02de36b9e581..894903a59bdc 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -8,7 +8,7 @@
> * Copyright (C) 2016 Renesas Electronics Corp.
> */
>
> -#include <dt-bindings/clock/renesas-cpg-mssr.h>
> +#include <dt-bindings/clock/r8a77965-cpg-mssr.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/r8a77965-sysc.h>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 10/17] arm64: dts: r8a77965: Add FCPF and FCPV instances
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
` (3 preceding siblings ...)
2018-04-26 16:53 ` [PATCH 09/17] arm64: dts: r8a77965: Use the correct CPG header Kieran Bingham
@ 2018-04-26 16:53 ` Kieran Bingham
2018-04-26 21:06 ` Laurent Pinchart
2018-04-26 16:53 ` [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances Kieran Bingham
` (6 subsequent siblings)
11 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Kieran Bingham, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT AARCH64 ARCHITECTURE, open list
The FCPs handle the interface between various IP cores and memory. Add
the instances related to the FDPs and VSP2s.
Based on a similar patch of the R8A7796 device tree
by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
[Kieran: Rebase to top of tree]
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 40 +++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 894903a59bdc..1f44ed7c1b1c 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1001,6 +1001,46 @@
/* placeholder */
};
+ fcpf0: fcp@fe950000 {
+ compatible = "renesas,fcpf";
+ reg = <0 0xfe950000 0 0x200>;
+ clocks = <&cpg CPG_MOD 615>;
+ power-domains = <&sysc R8A77965_PD_A3VP>;
+ resets = <&cpg 615>;
+ };
+
+ fcpvb0: fcp@fe96f000 {
+ compatible = "renesas,fcpv";
+ reg = <0 0xfe96f000 0 0x200>;
+ clocks = <&cpg CPG_MOD 607>;
+ power-domains = <&sysc R8A77965_PD_A3VP>;
+ resets = <&cpg 607>;
+ };
+
+ fcpvi0: fcp@fe9af000 {
+ compatible = "renesas,fcpv";
+ reg = <0 0xfe9af000 0 0x200>;
+ clocks = <&cpg CPG_MOD 611>;
+ power-domains = <&sysc R8A77965_PD_A3VP>;
+ resets = <&cpg 611>;
+ };
+
+ fcpvd0: fcp@fea27000 {
+ compatible = "renesas,fcpv";
+ reg = <0 0xfea27000 0 0x200>;
+ clocks = <&cpg CPG_MOD 603>;
+ power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+ resets = <&cpg 603>;
+ };
+
+ fcpvd1: fcp@fea2f000 {
+ compatible = "renesas,fcpv";
+ reg = <0 0xfea2f000 0 0x200>;
+ clocks = <&cpg CPG_MOD 602>;
+ power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+ resets = <&cpg 602>;
+ };
+
csi20: csi2@fea80000 {
reg = <0 0xfea80000 0 0x10000>;
/* placeholder */
--
2.17.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 10/17] arm64: dts: r8a77965: Add FCPF and FCPV instances
2018-04-26 16:53 ` [PATCH 10/17] arm64: dts: r8a77965: Add FCPF and FCPV instances Kieran Bingham
@ 2018-04-26 21:06 ` Laurent Pinchart
0 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2018-04-26 21:06 UTC (permalink / raw)
To: Kieran Bingham
Cc: linux-renesas-soc, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:39 EEST Kieran Bingham wrote:
> The FCPs handle the interface between various IP cores and memory. Add
> the instances related to the FDPs and VSP2s.
>
> Based on a similar patch of the R8A7796 device tree
> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> [Kieran: Rebase to top of tree]
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 40 +++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
> 894903a59bdc..1f44ed7c1b1c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -1001,6 +1001,46 @@
> /* placeholder */
> };
>
> + fcpf0: fcp@fe950000 {
> + compatible = "renesas,fcpf";
> + reg = <0 0xfe950000 0 0x200>;
> + clocks = <&cpg CPG_MOD 615>;
> + power-domains = <&sysc R8A77965_PD_A3VP>;
> + resets = <&cpg 615>;
> + };
> +
> + fcpvb0: fcp@fe96f000 {
> + compatible = "renesas,fcpv";
> + reg = <0 0xfe96f000 0 0x200>;
> + clocks = <&cpg CPG_MOD 607>;
> + power-domains = <&sysc R8A77965_PD_A3VP>;
> + resets = <&cpg 607>;
> + };
> +
> + fcpvi0: fcp@fe9af000 {
> + compatible = "renesas,fcpv";
> + reg = <0 0xfe9af000 0 0x200>;
> + clocks = <&cpg CPG_MOD 611>;
> + power-domains = <&sysc R8A77965_PD_A3VP>;
> + resets = <&cpg 611>;
> + };
> +
> + fcpvd0: fcp@fea27000 {
> + compatible = "renesas,fcpv";
> + reg = <0 0xfea27000 0 0x200>;
> + clocks = <&cpg CPG_MOD 603>;
> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> + resets = <&cpg 603>;
> + };
> +
> + fcpvd1: fcp@fea2f000 {
> + compatible = "renesas,fcpv";
> + reg = <0 0xfea2f000 0 0x200>;
> + clocks = <&cpg CPG_MOD 602>;
> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> + resets = <&cpg 602>;
> + };
> +
> csi20: csi2@fea80000 {
> reg = <0 0xfea80000 0 0x10000>;
> /* placeholder */
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
` (4 preceding siblings ...)
2018-04-26 16:53 ` [PATCH 10/17] arm64: dts: r8a77965: Add FCPF and FCPV instances Kieran Bingham
@ 2018-04-26 16:53 ` Kieran Bingham
2018-04-26 21:11 ` Laurent Pinchart
2018-04-26 16:53 ` [PATCH 12/17] arm64: dts: r8a77965: Populate the DU instance placeholder Kieran Bingham
` (5 subsequent siblings)
11 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Takeshi Kihara, Simon Horman, Catalin Marinas, Kieran Bingham,
Magnus Damm, open list, Will Deacon, Rob Herring,
moderated list:ARM64 PORT AARCH64 ARCHITECTURE
The r8a77965 has 4 VSP instances.
Based on a similar patch of the R8A7796 device tree
by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
[Kieran: Rebased to top of tree, fixed sort orders]
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 44 +++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 1f44ed7c1b1c..e92e6b03333a 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1009,6 +1009,17 @@
resets = <&cpg 615>;
};
+ vspb: vsp@fe960000 {
+ compatible = "renesas,vsp2";
+ reg = <0 0xfe960000 0 0x8000>;
+ interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 626>;
+ power-domains = <&sysc R8A77965_PD_A3VP>;
+ resets = <&cpg 626>;
+
+ renesas,fcp = <&fcpvb0>;
+ };
+
fcpvb0: fcp@fe96f000 {
compatible = "renesas,fcpv";
reg = <0 0xfe96f000 0 0x200>;
@@ -1017,6 +1028,17 @@
resets = <&cpg 607>;
};
+ vspi0: vsp@fe9a0000 {
+ compatible = "renesas,vsp2";
+ reg = <0 0xfe9a0000 0 0x8000>;
+ interrupts = <GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 631>;
+ power-domains = <&sysc R8A77965_PD_A3VP>;
+ resets = <&cpg 631>;
+
+ renesas,fcp = <&fcpvi0>;
+ };
+
fcpvi0: fcp@fe9af000 {
compatible = "renesas,fcpv";
reg = <0 0xfe9af000 0 0x200>;
@@ -1025,6 +1047,17 @@
resets = <&cpg 611>;
};
+ vspd0: vsp@fea20000 {
+ compatible = "renesas,vsp2";
+ reg = <0 0xfea20000 0 0x4000>;
+ interrupts = <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 623>;
+ power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+ resets = <&cpg 623>;
+
+ renesas,fcp = <&fcpvd0>;
+ };
+
fcpvd0: fcp@fea27000 {
compatible = "renesas,fcpv";
reg = <0 0xfea27000 0 0x200>;
@@ -1033,6 +1066,17 @@
resets = <&cpg 603>;
};
+ vspd1: vsp@fea28000 {
+ compatible = "renesas,vsp2";
+ reg = <0 0xfea28000 0 0x4000>;
+ interrupts = <GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 622>;
+ power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+ resets = <&cpg 622>;
+
+ renesas,fcp = <&fcpvd1>;
+ };
+
fcpvd1: fcp@fea2f000 {
compatible = "renesas,fcpv";
reg = <0 0xfea2f000 0 0x200>;
--
2.17.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances
2018-04-26 16:53 ` [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances Kieran Bingham
@ 2018-04-26 21:11 ` Laurent Pinchart
2018-04-27 16:33 ` Kieran Bingham
2018-06-08 9:29 ` Geert Uytterhoeven
0 siblings, 2 replies; 30+ messages in thread
From: Laurent Pinchart @ 2018-04-26 21:11 UTC (permalink / raw)
To: Kieran Bingham
Cc: linux-renesas-soc, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:40 EEST Kieran Bingham wrote:
> The r8a77965 has 4 VSP instances.
>
> Based on a similar patch of the R8A7796 device tree
> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> [Kieran: Rebased to top of tree, fixed sort orders]
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 44 +++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
> 1f44ed7c1b1c..e92e6b03333a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -1009,6 +1009,17 @@
> resets = <&cpg 615>;
> };
>
> + vspb: vsp@fe960000 {
> + compatible = "renesas,vsp2";
> + reg = <0 0xfe960000 0 0x8000>;
> + interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 626>;
> + power-domains = <&sysc R8A77965_PD_A3VP>;
> + resets = <&cpg 626>;
> +
> + renesas,fcp = <&fcpvb0>;
> + };
> +
> fcpvb0: fcp@fe96f000 {
> compatible = "renesas,fcpv";
> reg = <0 0xfe96f000 0 0x200>;
> @@ -1017,6 +1028,17 @@
> resets = <&cpg 607>;
> };
>
> + vspi0: vsp@fe9a0000 {
> + compatible = "renesas,vsp2";
> + reg = <0 0xfe9a0000 0 0x8000>;
> + interrupts = <GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 631>;
> + power-domains = <&sysc R8A77965_PD_A3VP>;
> + resets = <&cpg 631>;
> +
> + renesas,fcp = <&fcpvi0>;
> + };
> +
> fcpvi0: fcp@fe9af000 {
> compatible = "renesas,fcpv";
> reg = <0 0xfe9af000 0 0x200>;
> @@ -1025,6 +1047,17 @@
> resets = <&cpg 611>;
> };
>
> + vspd0: vsp@fea20000 {
> + compatible = "renesas,vsp2";
> + reg = <0 0xfea20000 0 0x4000>;
RFP2 has a CLUT so the register range needs to be extended. I'd recommend
covering the entire space (0x8000) even if no LUT or CLU module is present.
> + interrupts = <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 623>;
> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> + resets = <&cpg 623>;
> +
> + renesas,fcp = <&fcpvd0>;
> + };
> +
> fcpvd0: fcp@fea27000 {
> compatible = "renesas,fcpv";
> reg = <0 0xfea27000 0 0x200>;
> @@ -1033,6 +1066,17 @@
> resets = <&cpg 603>;
> };
>
> + vspd1: vsp@fea28000 {
> + compatible = "renesas,vsp2";
> + reg = <0 0xfea28000 0 0x4000>;
Same here.
With this fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + interrupts = <GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 622>;
> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> + resets = <&cpg 622>;
> +
> + renesas,fcp = <&fcpvd1>;
> + };
> +
> fcpvd1: fcp@fea2f000 {
> compatible = "renesas,fcpv";
> reg = <0 0xfea2f000 0 0x200>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances
2018-04-26 21:11 ` Laurent Pinchart
@ 2018-04-27 16:33 ` Kieran Bingham
2018-06-08 9:29 ` Geert Uytterhoeven
1 sibling, 0 replies; 30+ messages in thread
From: Kieran Bingham @ 2018-04-27 16:33 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
Hi Laurent,
On 26/04/18 22:11, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thursday, 26 April 2018 19:53:40 EEST Kieran Bingham wrote:
>> The r8a77965 has 4 VSP instances.
>>
>> Based on a similar patch of the R8A7796 device tree
>> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.
>>
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>> [Kieran: Rebased to top of tree, fixed sort orders]
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>> ---
>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 44 +++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
>> 1f44ed7c1b1c..e92e6b03333a 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -1009,6 +1009,17 @@
>> resets = <&cpg 615>;
>> };
>>
>> + vspb: vsp@fe960000 {
>> + compatible = "renesas,vsp2";
>> + reg = <0 0xfe960000 0 0x8000>;
>> + interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 626>;
>> + power-domains = <&sysc R8A77965_PD_A3VP>;
>> + resets = <&cpg 626>;
>> +
>> + renesas,fcp = <&fcpvb0>;
>> + };
>> +
>> fcpvb0: fcp@fe96f000 {
>> compatible = "renesas,fcpv";
>> reg = <0 0xfe96f000 0 0x200>;
>> @@ -1017,6 +1028,17 @@
>> resets = <&cpg 607>;
>> };
>>
>> + vspi0: vsp@fe9a0000 {
>> + compatible = "renesas,vsp2";
>> + reg = <0 0xfe9a0000 0 0x8000>;
>> + interrupts = <GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 631>;
>> + power-domains = <&sysc R8A77965_PD_A3VP>;
>> + resets = <&cpg 631>;
>> +
>> + renesas,fcp = <&fcpvi0>;
>> + };
>> +
>> fcpvi0: fcp@fe9af000 {
>> compatible = "renesas,fcpv";
>> reg = <0 0xfe9af000 0 0x200>;
>> @@ -1025,6 +1047,17 @@
>> resets = <&cpg 611>;
>> };
>>
>> + vspd0: vsp@fea20000 {
>> + compatible = "renesas,vsp2";
>> + reg = <0 0xfea20000 0 0x4000>;
>
> RFP2 has a CLUT so the register range needs to be extended. I'd recommend
> covering the entire space (0x8000) even if no LUT or CLU module is present.
Ah yes, of course.
Updated.
>
>> + interrupts = <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 623>;
>> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
>> + resets = <&cpg 623>;
>> +
>> + renesas,fcp = <&fcpvd0>;
>> + };
>> +
>> fcpvd0: fcp@fea27000 {
>> compatible = "renesas,fcpv";
>> reg = <0 0xfea27000 0 0x200>;
>> @@ -1033,6 +1066,17 @@
>> resets = <&cpg 603>;
>> };
>>
>> + vspd1: vsp@fea28000 {
>> + compatible = "renesas,vsp2";
>> + reg = <0 0xfea28000 0 0x4000>;
>
> Same here.
>
And here...
> With this fixed,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Collected.
--
Kieran
>
>> + interrupts = <GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 622>;
>> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
>> + resets = <&cpg 622>;
>> +
>> + renesas,fcp = <&fcpvd1>;
>> + };
>> +
>> fcpvd1: fcp@fea2f000 {
>> compatible = "renesas,fcpv";
>> reg = <0 0xfea2f000 0 0x200>;
>
>
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances
2018-04-26 21:11 ` Laurent Pinchart
2018-04-27 16:33 ` Kieran Bingham
@ 2018-06-08 9:29 ` Geert Uytterhoeven
2018-06-08 11:00 ` Laurent Pinchart
1 sibling, 1 reply; 30+ messages in thread
From: Geert Uytterhoeven @ 2018-06-08 9:29 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Kieran Bingham, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Takeshi Kihara, Catalin Marinas, Magnus Damm, open list,
Rob Herring, Linux-Renesas, Simon Horman, Will Deacon,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), Sergei Shtylyov
Hi Laurent,
CC Sergei (for V3H/V3M)
On Thu, Apr 26, 2018 at 11:11 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Thursday, 26 April 2018 19:53:40 EEST Kieran Bingham wrote:
>> The r8a77965 has 4 VSP instances.
>>
>> Based on a similar patch of the R8A7796 device tree
>> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.
>>
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>> [Kieran: Rebased to top of tree, fixed sort orders]
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>> ---
>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 44 +++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
>> 1f44ed7c1b1c..e92e6b03333a 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -1025,6 +1047,17 @@
>> resets = <&cpg 611>;
>> };
>>
>> + vspd0: vsp@fea20000 {
>> + compatible = "renesas,vsp2";
>> + reg = <0 0xfea20000 0 0x4000>;
>
> RFP2 has a CLUT so the register range needs to be extended. I'd recommend
> covering the entire space (0x8000) even if no LUT or CLU module is present.
Even on V3H/V3M, which have some part of the CLUT, and could do
with 0x5000?
Note that this makes it overlap with fcpvd0 on all R-Car Gen3 SoCs,
as mentioned by Simon on IRC.
>> + interrupts = <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 623>;
>> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
>> + resets = <&cpg 623>;
>> +
>> + renesas,fcp = <&fcpvd0>;
>> + };
>> +
>> fcpvd0: fcp@fea27000 {
>> compatible = "renesas,fcpv";
>> reg = <0 0xfea27000 0 0x200>;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances
2018-06-08 9:29 ` Geert Uytterhoeven
@ 2018-06-08 11:00 ` Laurent Pinchart
0 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2018-06-08 11:00 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Kieran Bingham, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Takeshi Kihara, Catalin Marinas, Magnus Damm, open list,
Rob Herring, Linux-Renesas, Simon Horman, Will Deacon,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), Sergei Shtylyov
Hi Geert,
On Friday, 8 June 2018 12:29:29 EEST Geert Uytterhoeven wrote:
> On Thu, Apr 26, 2018 at 11:11 PM, Laurent Pinchart wrote:
> > On Thursday, 26 April 2018 19:53:40 EEST Kieran Bingham wrote:
> >> The r8a77965 has 4 VSP instances.
> >>
> >> Based on a similar patch of the R8A7796 device tree
> >> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.
> >>
> >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> >> [Kieran: Rebased to top of tree, fixed sort orders]
> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> >> ---
> >>
> >> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 44 +++++++++++++++++++++++
> >> 1 file changed, 44 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> >> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
> >> 1f44ed7c1b1c..e92e6b03333a 100644
> >> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> >> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> >> @@ -1025,6 +1047,17 @@
> >> resets = <&cpg 611>;
> >> };
> >>
> >> + vspd0: vsp@fea20000 {
> >> + compatible = "renesas,vsp2";
> >> + reg = <0 0xfea20000 0 0x4000>;
> >
> > RFP2 has a CLUT so the register range needs to be extended. I'd recommend
> > covering the entire space (0x8000) even if no LUT or CLU module is
> > present.
>
> Even on V3H/V3M, which have some part of the CLUT, and could do
> with 0x5000?
>
> Note that this makes it overlap with fcpvd0 on all R-Car Gen3 SoCs,
> as mentioned by Simon on IRC.
My bad :-/ I'll submit fixes shortly.
> >> + interrupts = <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>;
> >> + clocks = <&cpg CPG_MOD 623>;
> >> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> >> + resets = <&cpg 623>;
> >> +
> >> + renesas,fcp = <&fcpvd0>;
> >> + };
> >> +
> >> fcpvd0: fcp@fea27000 {
> >> compatible = "renesas,fcpv";
> >> reg = <0 0xfea27000 0 0x200>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 12/17] arm64: dts: r8a77965: Populate the DU instance placeholder
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
` (5 preceding siblings ...)
2018-04-26 16:53 ` [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances Kieran Bingham
@ 2018-04-26 16:53 ` Kieran Bingham
2018-04-26 21:15 ` Laurent Pinchart
2018-04-26 16:53 ` [PATCH 13/17] arm64: dts: r8a77965: Add HDMI encoder instance Kieran Bingham
` (4 subsequent siblings)
11 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Kieran Bingham, Simon Horman, Magnus Damm, Rob Herring,
Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT AARCH64 ARCHITECTURE, open list
The DU entity node has been previously added but only as a placeholder.
Populate the node with the properties to use the device.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index e92e6b03333a..8a40bba53027 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1106,9 +1106,21 @@
};
du: display@feb00000 {
+ compatible = "renesas,du-r8a77965";
reg = <0 0xfeb00000 0 0x80000>,
<0 0xfeb90000 0 0x14>;
- /* placeholder */
+ reg-names = "du", "lvds.0";
+ interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 724>,
+ <&cpg CPG_MOD 723>,
+ <&cpg CPG_MOD 721>,
+ <&cpg CPG_MOD 727>;
+ clock-names = "du.0", "du.1", "du.3", "lvds.0";
+ status = "disabled";
+
+ vsps = <&vspd0 0 &vspd1 0 &vspd0 1>;
ports {
#address-cells = <1>;
--
2.17.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 12/17] arm64: dts: r8a77965: Populate the DU instance placeholder
2018-04-26 16:53 ` [PATCH 12/17] arm64: dts: r8a77965: Populate the DU instance placeholder Kieran Bingham
@ 2018-04-26 21:15 ` Laurent Pinchart
2018-04-27 16:34 ` Kieran Bingham
0 siblings, 1 reply; 30+ messages in thread
From: Laurent Pinchart @ 2018-04-26 21:15 UTC (permalink / raw)
To: Kieran Bingham
Cc: linux-renesas-soc, Simon Horman, Magnus Damm, Rob Herring,
Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:41 EEST Kieran Bingham wrote:
> The DU entity node has been previously added but only as a placeholder.
> Populate the node with the properties to use the device.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
> e92e6b03333a..8a40bba53027 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -1106,9 +1106,21 @@
> };
>
> du: display@feb00000 {
> + compatible = "renesas,du-r8a77965";
> reg = <0 0xfeb00000 0 0x80000>,
> <0 0xfeb90000 0 0x14>;
> - /* placeholder */
> + reg-names = "du", "lvds.0";
The LVDS encoder has been split to a separate node in current bindings. You
can remove the reg-names property and the second reg entry.
> + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 724>,
> + <&cpg CPG_MOD 723>,
> + <&cpg CPG_MOD 721>,
> + <&cpg CPG_MOD 727>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0";
And you can remove the LVDS clock as well (from both clocks and clock-names).
With this fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + status = "disabled";
> +
> + vsps = <&vspd0 0 &vspd1 0 &vspd0 1>;
>
> ports {
> #address-cells = <1>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [PATCH 12/17] arm64: dts: r8a77965: Populate the DU instance placeholder
2018-04-26 21:15 ` Laurent Pinchart
@ 2018-04-27 16:34 ` Kieran Bingham
0 siblings, 0 replies; 30+ messages in thread
From: Kieran Bingham @ 2018-04-27 16:34 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, Simon Horman, Magnus Damm, Rob Herring,
Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
On 26/04/18 22:15, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thursday, 26 April 2018 19:53:41 EEST Kieran Bingham wrote:
>> The DU entity node has been previously added but only as a placeholder.
>> Populate the node with the properties to use the device.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>> ---
>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 14 +++++++++++++-
>> 1 file changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
>> e92e6b03333a..8a40bba53027 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -1106,9 +1106,21 @@
>> };
>>
>> du: display@feb00000 {
>> + compatible = "renesas,du-r8a77965";
>> reg = <0 0xfeb00000 0 0x80000>,
>> <0 0xfeb90000 0 0x14>;
>> - /* placeholder */
>> + reg-names = "du", "lvds.0";
>
> The LVDS encoder has been split to a separate node in current bindings. You
> can remove the reg-names property and the second reg entry.
Done.
>
>> + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 724>,
>> + <&cpg CPG_MOD 723>,
>> + <&cpg CPG_MOD 721>,
>> + <&cpg CPG_MOD 727>;
>> + clock-names = "du.0", "du.1", "du.3", "lvds.0";
>
> And you can remove the LVDS clock as well (from both clocks and clock-names).
>
> With this fixed,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Collected, thanks.
--
Kieran
>
>> + status = "disabled";
>> +
>> + vsps = <&vspd0 0 &vspd1 0 &vspd0 1>;
>>
>> ports {
>> #address-cells = <1>;
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 13/17] arm64: dts: r8a77965: Add HDMI encoder instance
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
` (6 preceding siblings ...)
2018-04-26 16:53 ` [PATCH 12/17] arm64: dts: r8a77965: Populate the DU instance placeholder Kieran Bingham
@ 2018-04-26 16:53 ` Kieran Bingham
2018-04-26 21:17 ` Laurent Pinchart
2018-04-26 16:53 ` [PATCH 14/17] arm64: dts: r8a77965-salvator-x: Add DU external dot clocks Kieran Bingham
` (3 subsequent siblings)
11 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Kieran Bingham, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT AARCH64 ARCHITECTURE, open list
Add the HDMI encoder to the R8A77965 DT in disabled state.
Based on a similar patch of the R8A7796 device tree
by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
[Kieran: Rebase to top of tree]
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 28 +++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 8a40bba53027..972be1460a32 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1105,6 +1105,33 @@
};
};
+ hdmi0: hdmi@fead0000 {
+ compatible = "renesas,r8a77965-hdmi",
+ "renesas,rcar-gen3-hdmi";
+ reg = <0 0xfead0000 0 0x10000>;
+ interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 729>,
+ <&cpg CPG_CORE R8A77965_CLK_HDMI>;
+ clock-names = "iahb", "isfr";
+ power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
+ resets = <&cpg 729>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ dw_hdmi0_in: endpoint {
+ remote-endpoint = <&du_out_hdmi0>;
+ };
+ };
+ port@1 {
+ reg = <1>;
+ };
+ };
+ };
+
du: display@feb00000 {
compatible = "renesas,du-r8a77965";
reg = <0 0xfeb00000 0 0x80000>,
@@ -1134,6 +1161,7 @@
port@1 {
reg = <1>;
du_out_hdmi0: endpoint {
+ remote-endpoint = <&dw_hdmi0_in>;
};
};
port@2 {
--
2.17.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 13/17] arm64: dts: r8a77965: Add HDMI encoder instance
2018-04-26 16:53 ` [PATCH 13/17] arm64: dts: r8a77965: Add HDMI encoder instance Kieran Bingham
@ 2018-04-26 21:17 ` Laurent Pinchart
0 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2018-04-26 21:17 UTC (permalink / raw)
To: Kieran Bingham
Cc: linux-renesas-soc, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:42 EEST Kieran Bingham wrote:
> Add the HDMI encoder to the R8A77965 DT in disabled state.
>
> Based on a similar patch of the R8A7796 device tree
> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> [Kieran: Rebase to top of tree]
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 28 +++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index
> 8a40bba53027..972be1460a32 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -1105,6 +1105,33 @@
> };
> };
>
> + hdmi0: hdmi@fead0000 {
> + compatible = "renesas,r8a77965-hdmi",
> + "renesas,rcar-gen3-hdmi";
> + reg = <0 0xfead0000 0 0x10000>;
> + interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 729>,
> + <&cpg CPG_CORE R8A77965_CLK_HDMI>;
> + clock-names = "iahb", "isfr";
> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> + resets = <&cpg 729>;
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + dw_hdmi0_in: endpoint {
> + remote-endpoint = <&du_out_hdmi0>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + };
> + };
> + };
> +
> du: display@feb00000 {
> compatible = "renesas,du-r8a77965";
> reg = <0 0xfeb00000 0 0x80000>,
> @@ -1134,6 +1161,7 @@
> port@1 {
> reg = <1>;
> du_out_hdmi0: endpoint {
> + remote-endpoint = <&dw_hdmi0_in>;
> };
> };
> port@2 {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 14/17] arm64: dts: r8a77965-salvator-x: Add DU external dot clocks
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
` (7 preceding siblings ...)
2018-04-26 16:53 ` [PATCH 13/17] arm64: dts: r8a77965: Add HDMI encoder instance Kieran Bingham
@ 2018-04-26 16:53 ` Kieran Bingham
2018-04-26 21:18 ` Laurent Pinchart
2018-04-26 16:53 ` [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output Kieran Bingham
` (2 subsequent siblings)
11 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Kieran Bingham, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT AARCH64 ARCHITECTURE, open list
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
The DU1 external dot clock is provided by the fixed frequency clock
generator X21, while the DU0 and DU3 clocks are provided by the
programmable Versaclock5 clock generator.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
index 75d890d91df9..a2b8fb20fef8 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
@@ -19,3 +19,15 @@
reg = <0x0 0x48000000 0x0 0x78000000>;
};
};
+
+&du {
+ clocks = <&cpg CPG_MOD 724>,
+ <&cpg CPG_MOD 723>,
+ <&cpg CPG_MOD 721>,
+ <&cpg CPG_MOD 727>,
+ <&versaclock5 1>,
+ <&x21_clk>,
+ <&versaclock5 2>;
+ clock-names = "du.0", "du.1", "du.3", "lvds.0",
+ "dclkin.0", "dclkin.1", "dclkin.3";
+};
--
2.17.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 14/17] arm64: dts: r8a77965-salvator-x: Add DU external dot clocks
2018-04-26 16:53 ` [PATCH 14/17] arm64: dts: r8a77965-salvator-x: Add DU external dot clocks Kieran Bingham
@ 2018-04-26 21:18 ` Laurent Pinchart
0 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2018-04-26 21:18 UTC (permalink / raw)
To: Kieran Bingham
Cc: linux-renesas-soc, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:43 EEST Kieran Bingham wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> The DU1 external dot clock is provided by the fixed frequency clock
> generator X21, while the DU0 and DU3 clocks are provided by the
> programmable Versaclock5 clock generator.
I think you can squash this with patch 15/17.
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
> b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts index
> 75d890d91df9..a2b8fb20fef8 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
> @@ -19,3 +19,15 @@
> reg = <0x0 0x48000000 0x0 0x78000000>;
> };
> };
> +
> +&du {
> + clocks = <&cpg CPG_MOD 724>,
> + <&cpg CPG_MOD 723>,
> + <&cpg CPG_MOD 721>,
> + <&cpg CPG_MOD 727>,
> + <&versaclock5 1>,
> + <&x21_clk>,
> + <&versaclock5 2>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0",
> + "dclkin.0", "dclkin.1", "dclkin.3";
> +};
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
` (8 preceding siblings ...)
2018-04-26 16:53 ` [PATCH 14/17] arm64: dts: r8a77965-salvator-x: Add DU external dot clocks Kieran Bingham
@ 2018-04-26 16:53 ` Kieran Bingham
2018-04-26 21:21 ` Laurent Pinchart
2018-04-26 16:53 ` [PATCH 16/17] arm64: dts: r8a77965-salvator-xs: Add DU external dot clocks Kieran Bingham
2018-04-26 16:53 ` [PATCH 17/17] arm64: dts: r8a77965-salvator-xs: Enable HDMI output Kieran Bingham
11 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Kieran Bingham, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT AARCH64 ARCHITECTURE, open list
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Enable the HDMI encoder for the M3N Salvator-X board and hook it up to
the HDMI connector.
Based on a similar patches of the the Salvator-X board
on the R8A7796 SoC device tree
by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
.../boot/dts/renesas/r8a77965-salvator-x.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
index a2b8fb20fef8..11e8d43e9e11 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
@@ -31,3 +31,20 @@
clock-names = "du.0", "du.1", "du.3", "lvds.0",
"dclkin.0", "dclkin.1", "dclkin.3";
};
+
+&hdmi0 {
+ status = "okay";
+
+ ports {
+ port@1 {
+ reg = <1>;
+ rcar_dw_hdmi0_out: endpoint {
+ remote-endpoint = <&hdmi0_con>;
+ };
+ };
+ };
+};
+
+&hdmi0_con {
+ remote-endpoint = <&rcar_dw_hdmi0_out>;
+};
--
2.17.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output
2018-04-26 16:53 ` [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output Kieran Bingham
@ 2018-04-26 21:21 ` Laurent Pinchart
2018-04-27 16:22 ` Kieran Bingham
0 siblings, 1 reply; 30+ messages in thread
From: Laurent Pinchart @ 2018-04-26 21:21 UTC (permalink / raw)
To: Kieran Bingham
Cc: linux-renesas-soc, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:44 EEST Kieran Bingham wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> Enable the HDMI encoder for the M3N Salvator-X board and hook it up to
> the HDMI connector.
>
> Based on a similar patches of the the Salvator-X board
> on the R8A7796 SoC device tree
> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
How about adding the VGA output too ? I think you can add both VGA and HDMI in
a single patch that enables display in one go for the board. Same comment for
the Salvator-XS.
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> .../boot/dts/renesas/r8a77965-salvator-x.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
> b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts index
> a2b8fb20fef8..11e8d43e9e11 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
> @@ -31,3 +31,20 @@
> clock-names = "du.0", "du.1", "du.3", "lvds.0",
> "dclkin.0", "dclkin.1", "dclkin.3";
> };
> +
> +&hdmi0 {
> + status = "okay";
> +
> + ports {
> + port@1 {
> + reg = <1>;
> + rcar_dw_hdmi0_out: endpoint {
> + remote-endpoint = <&hdmi0_con>;
> + };
> + };
> + };
> +};
> +
> +&hdmi0_con {
> + remote-endpoint = <&rcar_dw_hdmi0_out>;
> +};
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output
2018-04-26 21:21 ` Laurent Pinchart
@ 2018-04-27 16:22 ` Kieran Bingham
0 siblings, 0 replies; 30+ messages in thread
From: Kieran Bingham @ 2018-04-27 16:22 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
Hi Laurent,
On 26/04/18 22:21, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thursday, 26 April 2018 19:53:44 EEST Kieran Bingham wrote:
>> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>>
>> Enable the HDMI encoder for the M3N Salvator-X board and hook it up to
>> the HDMI connector.
>>
>> Based on a similar patches of the the Salvator-X board
>> on the R8A7796 SoC device tree
>> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks, collected.
>
> How about adding the VGA output too ? I think you can add both VGA and HDMI in
> a single patch that enables display in one go for the board. Same comment for
> the Salvator-XS.
I believe the VGA output is handled by the salvator-common.dtsi, and thus
doesn't need to be included in this patch.
>
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>> ---
>> .../boot/dts/renesas/r8a77965-salvator-x.dts | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts index
>> a2b8fb20fef8..11e8d43e9e11 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> @@ -31,3 +31,20 @@
>> clock-names = "du.0", "du.1", "du.3", "lvds.0",
>> "dclkin.0", "dclkin.1", "dclkin.3";
>> };
>> +
>> +&hdmi0 {
>> + status = "okay";
>> +
>> + ports {
>> + port@1 {
>> + reg = <1>;
>> + rcar_dw_hdmi0_out: endpoint {
>> + remote-endpoint = <&hdmi0_con>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&hdmi0_con {
>> + remote-endpoint = <&rcar_dw_hdmi0_out>;
>> +};
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 16/17] arm64: dts: r8a77965-salvator-xs: Add DU external dot clocks
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
` (9 preceding siblings ...)
2018-04-26 16:53 ` [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output Kieran Bingham
@ 2018-04-26 16:53 ` Kieran Bingham
2018-04-26 21:22 ` Laurent Pinchart
2018-04-26 16:53 ` [PATCH 17/17] arm64: dts: r8a77965-salvator-xs: Enable HDMI output Kieran Bingham
11 siblings, 1 reply; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Kieran Bingham, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT AARCH64 ARCHITECTURE, open list
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
The DU1 external dot clock is provided by the fixed frequency clock
generator X21, while the DU0 and DU3 clocks are provided by the
programmable Versaclock6 clock generator.
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
index a83a00deed9e..2223cc2bd6bc 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
@@ -19,3 +19,15 @@
reg = <0x0 0x48000000 0x0 0x78000000>;
};
};
+
+&du {
+ clocks = <&cpg CPG_MOD 724>,
+ <&cpg CPG_MOD 723>,
+ <&cpg CPG_MOD 721>,
+ <&cpg CPG_MOD 727>,
+ <&versaclock6 1>,
+ <&x21_clk>,
+ <&versaclock6 2>;
+ clock-names = "du.0", "du.1", "du.3", "lvds.0",
+ "dclkin.0", "dclkin.1", "dclkin.3";
+};
--
2.17.0
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH 16/17] arm64: dts: r8a77965-salvator-xs: Add DU external dot clocks
2018-04-26 16:53 ` [PATCH 16/17] arm64: dts: r8a77965-salvator-xs: Add DU external dot clocks Kieran Bingham
@ 2018-04-26 21:22 ` Laurent Pinchart
0 siblings, 0 replies; 30+ messages in thread
From: Laurent Pinchart @ 2018-04-26 21:22 UTC (permalink / raw)
To: Kieran Bingham
Cc: linux-renesas-soc, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE), open list
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:45 EEST Kieran Bingham wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> The DU1 external dot clock is provided by the fixed frequency clock
> generator X21, while the DU0 and DU3 clocks are provided by the
> programmable Versaclock6 clock generator.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
> b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts index
> a83a00deed9e..2223cc2bd6bc 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
> @@ -19,3 +19,15 @@
> reg = <0x0 0x48000000 0x0 0x78000000>;
> };
> };
> +
> +&du {
> + clocks = <&cpg CPG_MOD 724>,
> + <&cpg CPG_MOD 723>,
> + <&cpg CPG_MOD 721>,
> + <&cpg CPG_MOD 727>,
> + <&versaclock6 1>,
> + <&x21_clk>,
> + <&versaclock6 2>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0",
> + "dclkin.0", "dclkin.1", "dclkin.3";
There's no LVDS clock in the DU anymore, you can drop it.
As for patch 14/17, I think you can squash this one with 17/17.
> +};
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 17/17] arm64: dts: r8a77965-salvator-xs: Enable HDMI output
[not found] <20180426165346.494-1-kieran.bingham+renesas@ideasonboard.com>
` (10 preceding siblings ...)
2018-04-26 16:53 ` [PATCH 16/17] arm64: dts: r8a77965-salvator-xs: Add DU external dot clocks Kieran Bingham
@ 2018-04-26 16:53 ` Kieran Bingham
11 siblings, 0 replies; 30+ messages in thread
From: Kieran Bingham @ 2018-04-26 16:53 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Kieran Bingham, Takeshi Kihara, Simon Horman, Magnus Damm,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT AARCH64 ARCHITECTURE, open list
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
This patch enables the HDMI encoder for the Salvator-X 2nd version board
on the R8A77965 SoC and hook it up to the HDMI connector.
Based on code of the Salvator-X 2nd version board
on the R8A7796 SoC device tree
by Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
.../boot/dts/renesas/r8a77965-salvator-xs.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
index 2223cc2bd6bc..dcf1849f1a67 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
@@ -31,3 +31,20 @@
clock-names = "du.0", "du.1", "du.3", "lvds.0",
"dclkin.0", "dclkin.1", "dclkin.3";
};
+
+&hdmi0 {
+ status = "okay";
+
+ ports {
+ port@1 {
+ reg = <1>;
+ rcar_dw_hdmi0_out: endpoint {
+ remote-endpoint = <&hdmi0_con>;
+ };
+ };
+ };
+};
+
+&hdmi0_con {
+ remote-endpoint = <&rcar_dw_hdmi0_out>;
+};
--
2.17.0
^ permalink raw reply related [flat|nested] 30+ messages in thread