Re: [PATCH net-next v3 09/10] dt-bindings: net: renesas,etheravb: Add optional gPTP phandle for Gen4

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Concern (invalidated): the binding documents `ptp-timer` for Gen4
  EtherAVB while the RAVB driver allegedly never reads it and keeps…

--

dt-bindings: net: renesas,etheravb: Add optional gPTP phandle for Gen4

This adds an optional ptp-timer phandle to the EtherAVB binding so that
Gen4 SoCs can point at the external system wide gPTP clock, and adds a
conditional block rejecting the property on non-Gen4 compatibles.

> diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> index 1e00ef5b3acd..fad002492421 100644
> --- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> @@ -97,6 +97,8 @@ properties:
>  
>    phy-handle: true
>  
> +  ptp-timer: true
> +

[Severity: Low]
This isn't a bug, just a note for the record after checking the rest of
the series.

At this patch alone there is no consumer of ptp-timer in
drivers/net/ethernet/renesas/, which initially looked like the binding
was documenting a property the driver would never read.

The later patch in the series, "net: ethernet: ravb: Add gPTP support
for Gen4", does add the consumer in ravb_gen4_ptp_probe():

	priv->of_gptp = of_parse_phandle(priv->pdev->dev.of_node, "ptp-timer", 0);

and switches ravb_gen4_hw_info.ptp from &ravb_gen3_ptp_info to
&ravb_gen4_ptp_info, with the reference released in ravb_remove() via
of_node_put(priv->of_gptp).

So no change is needed here; the property is consumed by the end of the
series.

>    '#address-cells':
>      description: Number of address cells for the MDIO bus.
>      const: 1

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260902084703.3228504-1-niklas.soderlund%2Brenesas%40ragnatech.se