Re: [PATCH net-next v11 1/4] dt-bindings: net: dsa: microchip: Add KSZ8995XA

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Claim: the newly documented `microchip,ksz8995xa` compatible has
  no in-tree consumer — no entry in ksz_dt_ids[]/ksz_spi_ids[], no chip…

--

dt-bindings: net: dsa: microchip: Add KSZ8995XA

This adds a new compatible string microchip,ksz8995xa to the Microchip
KSZ DSA switch binding. The commit message notes the chip was renamed
from KS8995XA and that KSZ8995MA and KSZ8995E are not compatible.

> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index 8d4a3a9a33fc..4ed13870ed3a 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -23,6 +23,7 @@ properties:
>        - microchip,ksz8864  # 4-port version of KSZ8895 family switch
>        - microchip,ksz8873
>        - microchip,ksz8895  # 5-port version of KSZ8895 family switch
> +      - microchip,ksz8995xa

[Severity: Low]
This isn't a bug, just a note for the record: at this patch alone there is
no in-tree consumer for the new compatible, so a device tree using
microchip,ksz8995xa passes dt_binding_check but does not bind.

The driver side arrives in the later patch of the same series, "net: dsa:
microchip: Support Microchip KSZ8995XA / KS8995XA", which adds:

drivers/net/dsa/microchip/ksz_spi.c:ksz_dt_ids[] {
	...
	{
		.compatible = "microchip,ksz8995xa",
		.data = &ksz_switch_chips[KSZ8995XA]
	},
	...
}

and the SPI alias in ksz_spi_ids[]:

	{ "ksz8995xa" },

So the skew only exists between patch 1 and patch 3 of the series, which is
the expected ordering for bindings-first submissions. Is the intent that
both patches land together in the same merge window?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260909-ks8995-to-ksz8-v11-0-0e04411a559d%40kernel.org