From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F00D4A8FE9 for ; Mon, 21 Sep 2026 15:53:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790005982; cv=none; b=fHVPkLMb4aAWaUyrJc5+Yp7eQQ68LRMognodpvsDrmxowZpGTQHgar8D0pIhfyd/YOjkNFrg6aOafnbxva+elNyGMqCtqgjzw1JkLB4IIeJ6KN8yqbI2EU3cqkSwdFSiwxyqj7XYVzpK9YEjHnuHe9koomYutayn4sLA4UuCWCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790005982; c=relaxed/simple; bh=uxSodr+5g5LhPeuMJLPaJWB2Wbyi9PA19/nxsZvoglk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=W3axWNjwrdc7YwXZyOMGFE69brRCIp994u4ovC2uC+c7lQsgfzpM71b86I0VWIHyMwbP9ab9dwmmeD3IWLQzkSUIdA2VzEMGF/Egq0ss8CmPmuT2GHL3zTebJ+z3sTTUVQWqQGRGLoPKLSgBX1NEfIwTXTBeSVTQUB19ws3mnyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CCwdd/EI; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CCwdd/EI" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-484366874b0so1863098f8f.2 for ; Mon, 21 Sep 2026 08:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790005978; x=1790610778; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=G0ME8UIp0+YWwCcJhu2EyuXifWZmH76ARjccb3bgJVA=; b=CCwdd/EI0Gnxf3ehSmpAf+WKHqxJuT/SEdiQz6nfa1BSrXAr3lvGDCbqI4Q+aq7M4M gkNeeewB+SQZM7xPtR1rbcWaP5BJzlA5eK/VNnVLgCqodKO6f40egdqKtB1716YN7W6I ao17i0zNBWaGwe7TehZfRSvJCwSlqz5izCRrMpuxe2IlypAV1yGJ20Xj3QQf50T9c4Qn 9mH8UXQXMJl6gBNJ88qk1zwg8TRfqCfosA68LFVZ7eQVhlkg2HhfoD8dQmf2KTx1ydCX dmBNAifocPTsZDUGwvK/mddW2jOVubu2DUB+ri6LZStUSCBA7/Hvmd6zxBU2YidTrIdS LeUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790005978; x=1790610778; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=G0ME8UIp0+YWwCcJhu2EyuXifWZmH76ARjccb3bgJVA=; b=hE/j+H3m0kxhj6n1CRt4Wghtj/8ZemctAkSj2AJsJ/OVY+jhpmJVSUEn39tOYkNuo0 4AiCRhU4FcfHDsJ4yl4KlH6XWm2DAz48y8W3gdM//0eYLPgElAmysfLPhGB32qMzb16A geFCMs/5PnTMwpgtJIHb9VYpCK2n83yESakchQFcOCNAkH2Mj1yUAMxqB8nnL9abm3Ux qufPUzvkQKB7dxOFwI3cNn4kUq98GYM0gm61TSrBlb+yhHBTbLUGYEgLu7YAZUs5nZHo 1SEIlilhBAJ1uE+DDenAxg7USuwFTkUeqbyztEqKmZ4e0ppS5S6ahi4a9JiWsL0VmnD9 1chw== X-Forwarded-Encrypted: i=1; AKwUvBxIA41UoQPQLNUKYRVZTOfOiRFU0t7QMDT+flbEWKMxEelPW6cfvU9kpQPwBJL9DOVrjpAuhvCkk5bY@vger.kernel.org X-Gm-Message-State: AFuF++l3c/qxOkFW8iWQJfxzu+H2e2n77pIJqc7wxoP5x2EA/rWd1ntq 5RPde86xjfePz6uP/zcpV3Ni+vm3GTyxyCyY/c8OQvjgELcj9gEiKuGXs3ZWy6I/Yjs= X-Gm-Gg: AYBFou0klWf/gzrxZfSgm7I/3GrkPUE1U5biFqQ7MpH6tXSnuzkpUdh/3QRxQ/2IFy1 e9N5jCrkw7y4zw2I4h+ts7pK9uI80UM2NuMBnl98JAX6N665g9QyP1n4Wl89vr3MMFUMn/pVp2l TGb/a6BoUxDnLuS9+ZSK576mitQLe7l3A//UBrq7jnaKcrdxV/tvnY1rgB5GRxtksOy9yD+kZCm GIDzBcucqiKIaxe4/h2DCKxtlq+l1nBqh/RKHFpfwjJRnMs8iPfZtCtqrrrO6L9cUj2ysqHCC+M BnX6WrLsRmt3A6M6HEKDEw40e3yqbEp1+aOu+DOc+sQGI1sp9alIsLH92N41h5J22sc0CJGHgEw y6APydw4LlREtQFai4IJcbmDgwMTZkxtIgenZ1tPRyvqiqwEeLfu3tFrNNkBi4E+uk+3/rHLSke GSW1oLZDueCTxrYxnmok1JsBnaBkQPsWHX25cOOfjr3kL+1hv268Jb3f6GV3ilrLI1wNnxffxQg y3nn97pwUuJD1oNmiBj7Q== X-Received: by 2002:a05:6000:430d:b0:487:27f6:a4d7 with SMTP id ffacd0b85a97d-48727f6a748mr10341971f8f.39.1790005978215; Mon, 21 Sep 2026 08:52:58 -0700 (PDT) Received: from localhost.localdomain ([194.154.195.114]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-4885a0549c3sm11159401f8f.25.2026.09.21.08.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 08:52:57 -0700 (PDT) From: Oleg Keri To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , Bryan O'Donoghue , Guenter Roeck , Bjorn Andersson , Konrad Dybcio , Abel Vesa , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, LKML , platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: Re: [PATCH v3 2/3] platform/arm64: add Lenovo Yoga Slim 7x Gen 11 EC driver Date: Mon, 21 Sep 2026 17:52:49 +0200 Message-ID: <179000596924.25968.9295838488330037392@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <55181989-11d7-ce0d-f9c3-e9dceaaf1fb4@linux.intel.com> References: <55181989-11d7-ce0d-f9c3-e9dceaaf1fb4@linux.intel.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Ilpo, On Mon, Sep 21, 2026, Ilpo Järvinen wrote: > > +Date: August 2026 > > ?? > > > +KernelVersion: 7.3 > > This ship has already sailed. Will be September 2026 and 7.4. All the other points will be in v4 as well: - the missing includes added where the symbols are used - the cache and stale periods defined in milliseconds, with the unit in the name, and converted to jiffies at the call - lockdep_assert_held() in the command path every EC access goes through - each EC read checked right after the call - ARRAY_SIZE() for the cell loop - MILLIDEGREE_PER_DEGREE from units.h instead of the literal - braces on the multi-line returns Plus two things not from your review: a shorter i2c id that fits I2C_NAME_SIZE (the bot's finding), and the symbol prefix renamed to slim7x_ec to match the driver name, which makes the v4 diff larger than the changes are. Thanks, Oleg