From: "Rob Herring (Arm)" <robh@kernel.org>
To: Quchaosheng <quchaosheng000406@163.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vincent Mailhol <mailhol@kernel.org>,
linux-can@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6] dt-bindings: net: can: holt,hi311x: Convert to DT schema
Date: Mon, 21 Sep 2026 12:38:32 -0500 [thread overview]
Message-ID: <179001231152.1040111.15461000721283698523.robh@kernel.org> (raw)
In-Reply-To: <20260916015801.112299-1-quchaosheng000406@163.com>
On Wed, 16 Sep 2026 09:58:01 +0800, Quchaosheng wrote:
> Convert the Holt HI-311X binding from free-form text to DT schema.
>
> Keep the example and the properties as the original text describes them,
> including clocks as a required property.
>
> Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> ---
> v2:
> - Keep clocks required and drop the clock-frequency property.
> - Drop the variant-specific handling that v2 introduced. It documented
> properties the binding never had.
>
> v3:
> - Rewrite the commit message in imperative mood.
>
> v6:
> - No content change. Fix the patch format: the changelog was placed in the
> commit message instead of after the '---' separator, which confused
> Patchwork. Move it back where it belongs.
>
> - Drop an incorrect statement from the v2 changelog: clock-frequency was
> described there as an ACPI-only property of the driver. That is wrong,
> the driver has no ACPI support at all (no acpi_device_id, no ACPI
> headers); device_property_read_u32() reads it from device tree too.
> The property is simply not part of this DT binding, which is why it is
> not documented. Keeping clocks required matches the sibling
> microchip,mcp2510.yaml, whose driver also uses devm_clk_get_optional().
> .../bindings/net/can/holt,hi311x.yaml | 67 +++++++++++++++++++
> .../bindings/net/can/holt_hi311x.txt | 23 -------
> 2 files changed, 67 insertions(+), 23 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
> delete mode 100644 Documentation/devicetree/bindings/net/can/holt_hi311x.txt
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
prev parent reply other threads:[~2026-09-21 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 9:04 [PATCH v3 1/2] dt-bindings: net: can: holt,hi311x: Convert to DT schema Quchaosheng
2026-09-15 10:57 ` Krzysztof Kozlowski
2026-09-16 1:58 ` [PATCH v6] " Quchaosheng
2026-09-21 17:38 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179001231152.1040111.15461000721283698523.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=quchaosheng000406@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox