From: "Rob Herring (Arm)" <robh@kernel.org>
To: Quchaosheng <quchaosheng000406@163.com>
Cc: Vincent Mailhol <mailhol@kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Conor Dooley <conor+dt@kernel.org>,
linux-can@vger.kernel.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH v6] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema
Date: Mon, 21 Sep 2026 12:40:02 -0500 [thread overview]
Message-ID: <179001240193.1044469.15908523529395448607.robh@kernel.org> (raw)
In-Reply-To: <20260916015805.112354-1-quchaosheng000406@163.com>
On Wed, 16 Sep 2026 09:58:05 +0800, Quchaosheng wrote:
> Convert the IFI CAN-FD controller binding from free-form text to DT
> schema, and reference the common can-controller.yaml schema.
>
> The driver matches on the "ifi,canfd-1.0" compatible and obtains its
> interrupt through platform_get_irq(), so interrupts is required.
>
> The example uses the GIC and irq header defines instead of the raw
> numbers from the original text, which keeps the values unchanged
> (GIC_SPI is 0, IRQ_TYPE_NONE is 0 and 1 is IRQ_TYPE_EDGE_RISING). The
> node name is changed from "canfd" to "can" so that it matches the
> $nodename pattern required by can-controller.yaml.
>
> Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> ---
> v2:
> - Correct the description: this is a soft IP block typically synthesised
> into an FPGA or CPLD, not a controller found on Renesas SoCs.
> Wording now follows the driver's Kconfig entry.
>
> v3:
> - Use unevaluatedProperties: false instead of additionalProperties: false.
> As can-controller.yaml is referenced through allOf, additionalProperties
> would have rejected properties defined by that common schema, such as
> termination-gpios and termination-ohms.
>
> v4:
> - Use defines instead of raw numbers in the example, and rename the
> example node from canfd to can. No functional change.
>
> v5:
> - Re-send the patch on its own. The v4 posting accidentally included
> unrelated changes to the xilinx-xadc binding and did not remove
> ifi_canfd.txt. Only the intended change is present now.
>
> v6:
> - No content change. Fix the patch format: the changelog was placed in the
> commit message instead of after the '---' separator, which confused
> Patchwork. Move it back where it belongs.
> .../bindings/net/can/ifi,canfd.yaml | 46 +++++++++++++++++++
> .../devicetree/bindings/net/can/ifi_canfd.txt | 15 ------
> 2 files changed, 46 insertions(+), 15 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
> delete mode 100644 Documentation/devicetree/bindings/net/can/ifi_canfd.txt
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
prev parent reply other threads:[~2026-09-21 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 3:01 [PATCH v5] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema Quchaosheng
2026-09-16 1:58 ` [PATCH v6] " Quchaosheng
2026-09-21 17:40 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179001240193.1044469.15908523529395448607.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=quchaosheng000406@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox