From: "Rob Herring (Arm)" <robh@kernel.org>
To: Kendall Willis <k-willis@ti.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
msp@baylibre.com, s-tripathi1@ti.com, vishalm@ti.com,
linux-input@vger.kernel.org, a-kaur@ti.com, s-kochidanadu@ti.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: input: gpio-keys: add pinctrl states
Date: Thu, 1 Oct 2026 15:01:33 -0500 [thread overview]
Message-ID: <179088489296.1749674.5492156640851777675.robh@kernel.org> (raw)
In-Reply-To: <20261001-upstream-gpio-wakeup-v3-1-6f3bcde367a3@ti.com>
On Thu, 01 Oct 2026 10:50:33 -0500, Kendall Willis wrote:
> Document pinctrl properties on the gpio-keys device node. The default
> pinctrl state describes the default pin configuration. The wakeup state
> configures pins to be able to wakeup the system from suspend if GPIO is a
> wakeup source.
>
> The pinctrl sleep state is not defined here despite being used to configure
> pins for system suspend to save power. It is not defined since no
> gpio-key device tree nodes utilize it. If the sleep state was added, a
> device could use both the wakeup state and sleep state. The sleep state
> would be entered upon suspend when wakeup is disabled for the device,
> whereas the wakeup state would be entered upon suspend if wakeup is enabled
> for the device. For now only the wakeup state is defined since it is
> used specifically to enable pin configurations that can wakeup the
> system from suspend.
>
> Signed-off-by: Kendall Willis <k-willis@ti.com>
> ---
> Documentation/devicetree/bindings/input/gpio-keys.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2026-10-01 20:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 15:50 [PATCH v3 0/2] Input: gpio-keys - support wakeup pinctrl state Kendall Willis
2026-10-01 15:50 ` [PATCH v3 1/2] dt-bindings: input: gpio-keys: add pinctrl states Kendall Willis
2026-10-01 15:59 ` sashiko-bot
2026-10-01 16:11 ` Kendall Willis
2026-10-01 20:01 ` Rob Herring (Arm) [this message]
2026-10-01 15:50 ` [PATCH v3 2/2] Input: gpio-keys - support wakeup pinctrl state on suspend Kendall Willis
2026-10-01 16:02 ` sashiko-bot
2026-10-01 16:12 ` Kendall Willis
2026-10-03 5:26 ` Dmitry Torokhov
2026-10-05 20:42 ` Kendall Willis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179088489296.1749674.5492156640851777675.robh@kernel.org \
--to=robh@kernel.org \
--cc=a-kaur@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=k-willis@ti.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=s-kochidanadu@ti.com \
--cc=s-tripathi1@ti.com \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox