Devicetree
 help / color / mirror / Atom feed
From: Bob Hui <bg9oxa@163.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH v8 2/2] arm64: dts: rockchip: Add ALIENTEK QuarkPi-CA2
Date: Wed, 07 Oct 2026 14:24:43 +0800	[thread overview]
Message-ID: <179135428374.23998.13252521177249770220@163.com> (raw)
In-Reply-To: <sashiko-outbox-162642@kernel.org>

Hi,

Thank you for the review, that is a good catch on the wording.

To answer the question: the board does have two LEDs.  One is the work LED
(GPIO1_D7, heartbeat trigger) that the gpio-leds node describes; the second
one is a power indicator that is hardwired and not software controllable,
so it has no device tree node.  Nothing is missing from the description -
the sentence is accurate, it just reads as if both LEDs were
software-controlled.

I will make the wording explicit if another revision becomes necessary, but
no functional change is needed here.

Thanks,
Bob


      reply	other threads:[~2026-10-07  6:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07  5:18 [PATCH v8 0/2] arm64: dts: rockchip: Add ALIENTEK QuarkPi-CA2 Bob Hui
2026-10-07  5:18 ` [PATCH v8 1/2] dt-bindings: arm: " Bob Hui
2026-10-07  9:52   ` Conor Dooley
2026-10-07  5:18 ` [PATCH v8 2/2] arm64: dts: " Bob Hui
2026-10-07  5:29   ` sashiko-bot
2026-10-07  6:24     ` Bob Hui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179135428374.23998.13252521177249770220@163.com \
    --to=bg9oxa@163.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox