From: "Rob Herring (Arm)" <robh@kernel.org>
To: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Cc: Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
Bharath Kumar <quic_bkumar@quicinc.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
Bjorn Andersson <andersson@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Chenna Kesava Raju <quic_chennak@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Srinivas Kandagatla <srini@kernel.org>,
Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: misc: qcom,fastrpc: Allow hex digits in compute-cb node names
Date: Wed, 7 Oct 2026 15:45:56 -0500 [thread overview]
Message-ID: <179140595600.238028.12326483402772161970.robh@kernel.org> (raw)
In-Reply-To: <20261007-glymur-dtfix-v4-1-31f7143e759b@oss.qualcomm.com>
On Wed, 07 Oct 2026 15:51:17 +0530, Ekansh Gupta wrote:
> The patternProperties key for compute-cb subnodes used [0-9]* which
> only matches decimal digits. However, per DTS convention, node unit
> addresses must be the lowercase hexadecimal representation of the reg
> value. For compute-cb nodes with reg values >= 10 (e.g. 12, 13, 14),
> the correct node names are compute-cb@c, compute-cb@d, compute-cb@e
> respectively, which are not matched by the current pattern.
>
> Extend the pattern to [0-9a-f]+ to allow lowercase hex digits, making
> it consistent with DTS unit address conventions. Also change * to +
> to require at least one digit in the unit address.
>
> Reviewed-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
> Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2026-10-07 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 10:21 [PATCH v4 0/2] arm64: dts: qcom: glymur: Fix fastrpc compute-cb reg values for cdsp Ekansh Gupta
2026-10-07 10:21 ` [PATCH v4 1/2] dt-bindings: misc: qcom,fastrpc: Allow hex digits in compute-cb node names Ekansh Gupta
2026-10-07 20:45 ` Rob Herring (Arm) [this message]
2026-10-07 10:21 ` [PATCH v4 2/2] arm64: dts: qcom: glymur: Fix fastrpc compute-cb reg values for cdsp Ekansh Gupta
2026-10-07 20:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179140595600.238028.12326483402772161970.robh@kernel.org \
--to=robh@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ekansh.gupta@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=quic_bkumar@quicinc.com \
--cc=quic_chennak@quicinc.com \
--cc=sibi.sankar@oss.qualcomm.com \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox