Re: [PATCH v4 7/7] riscv: dts: ultrarisc: Add Milk-V Titan board device tree

[Xincheng Ji <jixincheng@ultrarisc.com>]

Hi Conor,
On 2026-10-21 17:51 +0100, Conor Dooley wrote:
> > > 
> > > Because led_parse_fwnode_props() returns early when label is present, the
> > > color and function properties on led@1 and led@2 are never parsed and are
> > > completely ignored at runtime.
> > > 
> > > In addition, Documentation/devicetree/bindings/leds/common.yaml deprecates
> > > label for new bindings in favor of color and function.
> > > 
> > > Would it make sense to remove label from both nodes so that the LED core
> > > uses color and function to compose the standard LED names?
> You're asking a bot that will never reply to you.
> 
> I'd say that if the analysis provided is correct, then yes you should
> since the deprecated property overrides the replacement properties.

Thanks for the clarification and for reviewing the patch. Sorry for
addressing my previous question to the bot; I hadn't realised it would
not respond to follow-up questions.

I'll remove the two LED label properties in the next revision so that
color and function are used for naming.

Best regards,
Xincheng

-- 
Xincheng Ji <jixincheng@ultrarisc.com>