From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sibi Sankar Subject: Re: [PATCH 22/22] arm64: dts: qcom: sm8150: Add APSS shared mailbox Date: Tue, 20 Aug 2019 11:50:25 +0530 Message-ID: <179635ff3f55d5d121008d6193ea4120@codeaurora.org> References: <20190814125012.8700-1-vkoul@kernel.org> <20190814125012.8700-23-vkoul@kernel.org> <20190814171743.C38C4206C1@mail.kernel.org> <20190819174107.GM12733@vkoul-mobl.Dlink> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190819174107.GM12733@vkoul-mobl.Dlink> Sender: linux-kernel-owner@vger.kernel.org To: Vinod Koul Cc: Stephen Boyd , Bjorn Andersson , Andy Gross , linux-arm-msm@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Hey Vinod, There seems to be a mismatch between the commit description and the dt node (This is the aoss qmp node not the APPS shared node). On 2019-08-19 23:11, Vinod Koul wrote: > On 14-08-19, 10:17, Stephen Boyd wrote: >> Quoting Vinod Koul (2019-08-14 05:50:12) >> > @@ -338,6 +339,16 @@ >> > #interrupt-cells = <2>; >> > }; >> > >> > + aoss_qmp: qmp@c300000 { >> >> Node name of 'clock-controller', or 'power-controller'? > > The orignal entry for sdm845 has no such statement, but yes it doesn > makes sense. I am thinking power-controller.. Bjorn? aoss_qmp registers both pd and clock providers. -- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.