From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tommaso Merciai <tomm.merciai@gmail.com>
Cc: jacopo.mondi@ideasonboard.com, laurent.pinchart@ideasonboard.com,
martin.hecht@avnet.eu, michael.roeder@avnet.eu,
linuxfancy@googlegroups.com,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Marco Felsch" <m.felsch@pengutronix.de>,
"Gerald Loacker" <gerald.loacker@wolfvision.net>,
"Mikhail Rudenko" <mike.rudenko@gmail.com>,
"Nicholas Roth" <nicholas@rothemail.net>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Shawn Tu" <shawnx.tu@intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] media: dt-bindings: alvium: add document YAML binding
Date: Wed, 7 Jun 2023 16:18:48 +0200 [thread overview]
Message-ID: <17971357-523c-f907-13a9-8f7abce90c24@linaro.org> (raw)
In-Reply-To: <20230607131936.382406-3-tomm.merciai@gmail.com>
On 07/06/2023 15:19, Tommaso Merciai wrote:
> Add documentation of device tree in YAML schema for the ALVIUM
> Camera from Allied Vision Inc.
>
> References:
> - https://www.alliedvision.com/en/products/embedded-vision-solutions
>
> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v1:
> - Fixed build error as suggested by RHerring bot
>
> Changes since v2:
> - Fixed License as suggested by KKozlowski/CDooley
> - Removed rotation property as suggested by CDooley/LPinchart
> - Fixed example node name as suggested by CDooley
> - Fixed title as suggested by LPinchart
> - Fixed compatible name as suggested by LPinchart
> - Removed clock as suggested by LPinchart
> - Removed gpios not as suggested by LPinchart
> - Renamed property name streamon-delay into alliedvision,lp2hs-delay-us
> - Fixed vendor prefix, unit append as suggested by KKozlowski
> - Fixed data-lanes
> - Fixed blank space + example indentation (from 6 -> 4 space) as suggested by KKozlowski
> - Dropped status into example as suggested by KKozlowski
> - Added vcc-ext-in supply as suggested by LPinchart
> - Dropped pinctrl into example as suggested by LPinchart
>
> Changes since v3:
> - Fixed vcc-ext-in-supply description as suggested by LPinchart
> - Fixed alliedvision,lp2hs-delay-us description as suggested by LPinchart
> - Added maximum to alliedvision,lp2hs-delay-us as suggested by LPinchart
> - Collected Reviewed-by tag from LPinchart
You still did not test it before sending. Four versions of which none
were tested :(
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-07 14:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230607131936.382406-1-tomm.merciai@gmail.com>
2023-06-07 13:19 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add prefix alliedvision Tommaso Merciai
2023-06-07 13:19 ` [PATCH v4 2/3] media: dt-bindings: alvium: add document YAML binding Tommaso Merciai
2023-06-07 14:06 ` Laurent Pinchart
2023-06-07 14:19 ` Tommaso Merciai
2023-06-07 14:18 ` Krzysztof Kozlowski [this message]
2023-06-07 15:20 ` Tommaso Merciai
2023-06-07 16:11 ` Krzysztof Kozlowski
2023-06-07 19:38 ` Tommaso Merciai
2023-06-07 14:20 ` Rob Herring
2023-06-07 17:16 ` Conor Dooley
2023-06-07 19:49 ` Tommaso Merciai
2023-06-07 20:46 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17971357-523c-f907-13a9-8f7abce90c24@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=benjamin.mugnier@foss.st.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxfancy@googlegroups.com \
--cc=m.felsch@pengutronix.de \
--cc=martin.hecht@avnet.eu \
--cc=mchehab@kernel.org \
--cc=michael.riesch@wolfvision.net \
--cc=michael.roeder@avnet.eu \
--cc=mike.rudenko@gmail.com \
--cc=nicholas@rothemail.net \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnx.tu@intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).