* [PATCH v3 3/3] ARM: dts: Specify VMMC and VQMMC on rk3288-evb
[not found] <1418689340-29517-1-git-send-email-dianders@chromium.org>
@ 2014-12-16 0:22 ` Doug Anderson
2015-01-06 17:44 ` Heiko Stübner
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2014-12-16 0:22 UTC (permalink / raw)
To: Ulf Hansson, Heiko Stuebner, Jaehoon Chung, Seungwon Jeon
Cc: Mark Brown, Alexandru Stan, Alim Akhtar, Sonny Rao,
Andrew Bresticker, linux-rockchip, linux-arm-kernel,
Doug Anderson, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
galak, linux, devicetree, linux-kernel
Specifying these rails should eventually let us do UHS.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v3: None
Changes in v2:
- Fix subject line
arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index 3e067dd..d660fe6 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -114,6 +114,8 @@
pinctrl-names = "default";
pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
status = "okay";
+ vmmc-supply = <&vcc_io>;
+ vqmmc-supply = <&vccio_sd>;
};
&i2c0 {
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 3/3] ARM: dts: Specify VMMC and VQMMC on rk3288-evb
2014-12-16 0:22 ` [PATCH v3 3/3] ARM: dts: Specify VMMC and VQMMC on rk3288-evb Doug Anderson
@ 2015-01-06 17:44 ` Heiko Stübner
2015-03-11 22:13 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stübner @ 2015-01-06 17:44 UTC (permalink / raw)
To: Doug Anderson
Cc: mark.rutland, devicetree, Ulf Hansson, linux, Alexandru Stan,
pawel.moll, linux-rockchip, Seungwon Jeon, ijc+devicetree,
linux-kernel, robh+dt, Jaehoon Chung, Andrew Bresticker,
Mark Brown, Alim Akhtar, galak, Sonny Rao, linux-arm-kernel
Hi Doug,
Am Montag, 15. Dezember 2014, 16:22:20 schrieb Doug Anderson:
> Specifying these rails should eventually let us do UHS.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> Changes in v3: None
> Changes in v2:
> - Fix subject line
>
> arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
> b/arch/arm/boot/dts/rk3288-evb.dtsi index 3e067dd..d660fe6 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -114,6 +114,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
> status = "okay";
> + vmmc-supply = <&vcc_io>;
according to the schematics there is a switch between the card and vcc_io with
a controlling pin called SDMMC_PWR providing a supply called vcc_sd.
So there should probably be a fixed-regulator get introduced for this, like the
older rockchip boards do.
Heiko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 3/3] ARM: dts: Specify VMMC and VQMMC on rk3288-evb
2015-01-06 17:44 ` Heiko Stübner
@ 2015-03-11 22:13 ` Doug Anderson
0 siblings, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2015-03-11 22:13 UTC (permalink / raw)
To: Heiko Stübner
Cc: Ulf Hansson, Jaehoon Chung, Seungwon Jeon, Mark Brown,
Alexandru Stan, Alim Akhtar, Sonny Rao, Andrew Bresticker,
open list:ARM/Rockchip SoC...,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Heiko,
On Tue, Jan 6, 2015 at 9:44 AM, Heiko Stübner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> wrote:
> Hi Doug,
>
> Am Montag, 15. Dezember 2014, 16:22:20 schrieb Doug Anderson:
>> Specifying these rails should eventually let us do UHS.
>>
>> Signed-off-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>> ---
>> Changes in v3: None
>> Changes in v2:
>> - Fix subject line
>>
>> arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
>> b/arch/arm/boot/dts/rk3288-evb.dtsi index 3e067dd..d660fe6 100644
>> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
>> @@ -114,6 +114,8 @@
>> pinctrl-names = "default";
>> pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
>> status = "okay";
>> + vmmc-supply = <&vcc_io>;
>
> according to the schematics there is a switch between the card and vcc_io with
> a controlling pin called SDMMC_PWR providing a supply called vcc_sd.
>
> So there should probably be a fixed-regulator get introduced for this, like the
> older rockchip boards do.
OK, I found the problem. I've got a 1.0 board and the associated
schematics. Supporting your 2.0 board with the extra regulator should
be no problem though.
Patch coming up shortly.
-Doug
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-11 22:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1418689340-29517-1-git-send-email-dianders@chromium.org>
2014-12-16 0:22 ` [PATCH v3 3/3] ARM: dts: Specify VMMC and VQMMC on rk3288-evb Doug Anderson
2015-01-06 17:44 ` Heiko Stübner
2015-03-11 22:13 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).