From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v3 3/3] ARM: dts: Specify VMMC and VQMMC on rk3288-evb Date: Tue, 06 Jan 2015 18:44:13 +0100 Message-ID: <1798568.RumoICfKOO@phil> References: <1418689340-29517-1-git-send-email-dianders@chromium.org> <1418689340-29517-3-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1418689340-29517-3-git-send-email-dianders@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Doug Anderson Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Ulf Hansson , linux@arm.linux.org.uk, Alexandru Stan , pawel.moll@arm.com, linux-rockchip@lists.infradead.org, Seungwon Jeon , ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Jaehoon Chung , Andrew Bresticker , Mark Brown , Alim Akhtar , galak@codeaurora.org, Sonny Rao , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Doug, Am Montag, 15. Dezember 2014, 16:22:20 schrieb Doug Anderson: > Specifying these rails should eventually let us do UHS. > > Signed-off-by: Doug Anderson > --- > Changes in v3: None > Changes in v2: > - Fix subject line > > arch/arm/boot/dts/rk3288-evb.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi > b/arch/arm/boot/dts/rk3288-evb.dtsi index 3e067dd..d660fe6 100644 > --- a/arch/arm/boot/dts/rk3288-evb.dtsi > +++ b/arch/arm/boot/dts/rk3288-evb.dtsi > @@ -114,6 +114,8 @@ > pinctrl-names = "default"; > pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>; > status = "okay"; > + vmmc-supply = <&vcc_io>; according to the schematics there is a switch between the card and vcc_io with a controlling pin called SDMMC_PWR providing a supply called vcc_sd. So there should probably be a fixed-regulator get introduced for this, like the older rockchip boards do. Heiko