Re: [PATCH v3 6/8] arm64: dts: bst: add support for Black Sesame Technologies C1200 CDCU1.0 board

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/09/2025 09:06, Albert Yang wrote:
>>
>> No, you need to finally read and follow DTS coding style.
>>
>>>             gic: interrupt-controller@32800000 {
>>>                     compatible = "arm,gic-v3";
>>>
> 
> Thank you for pointing out the DTS coding style requirements. I have now
> carefully reviewed the documentation and updated the GIC node as follows.
> 
> I have a question regarding the property ordering. According to the DTS
> coding style documentation at:
> https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
> 
> The preferred order of properties in device nodes is:
> 
> 1.“compatible”
> 2.“reg”
> 3.“ranges”
> 4.Standard/common properties (defined by common bindings, e.g. without vendor-prefixes)
> 5.Vendor-specific properties
> 6.“status” (if applicable)
> 7.Child nodes, where each node is preceded with a blank line
> 
> However, I'm uncertain about how to order properties that start with "#".
> I have treated them as standard/common properties and updated the node as follows.
> Could you please confirm if this approach is correct?

They go as standard common properties. Whether you group all '#'
together or sort by name skipping '#' is up to you, because common style
does not define that.

> 
> 
> 		gic: interrupt-controller@32800000 {
> 			compatible = "arm,gic-v3";
> 			reg = <0x0 0x32800000 0x0 0x10000>,
> 			      <0x0 0x32880000 0x0 0x100000>;
> 			ranges;
> 			#address-cells = <2>;
> 			#interrupt-cells = <3>;
> 			interrupt-controller;
> 			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
> 			#size-cells = <2>;

I would keep #size-cells after #address-cells, because they describe
same thing - addressing of children.



Best regards,
Krzysztof