devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: neil.armstrong@linaro.org, Arnd Bergmann <arnd@arndb.de>,
	Olof Johansson <olof@lixom.net>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Daniel Vetter <daniel@ffwll.ch>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Nicolas Belin <nbelin@baylibre.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org,
	David Airlie <airlied@gmail.com>, Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids
Date: Mon, 15 May 2023 18:32:24 +0200	[thread overview]
Message-ID: <17bfc33b-029f-a0f1-564d-e8c8d0a8695c@linaro.org> (raw)
In-Reply-To: <9cba6384-123b-1cd1-ed02-08365a0ed529@linaro.org>

On 15/05/2023 18:22, neil.armstrong@linaro.org wrote:
>>> Meson is the only or almost the only platform making such changes. I
>>> don't get why, because the conflict could be easily avoided with using
>>> different names for defines in bindings and local clock. Approach of
>>> having bindings strictly tied with driver commit is never desired.
> 
> If we did it now, we would have make it differently and expose all the clock
> IDs on the bindings like on Qcom, be sure of that.

No, you just keep different names. The only problem here is that your
clock name is the same thus you cannot split bindings into separate patch.

> 
>>
>> Also one more argument maybe not relevant here but for other cases -
>> this makes literally impossible to include the clock ID in DTS in the
>> same kernel revision, because you must not merge driver branch to DTS
>> branch. SoC folks were complaining about this many times.
> 
> Actually we handle this very simply by having such patches merged in a immutable
> branch merged in the clock and DT pull-requests, it worked perfectly so far
> and neither Stephen or Arnd complained about that.

Arnd, Olof,

Any changes in the policies? Do you allow now driver branches (with
driver code) to be merged into DT branch?

Best regards,
Krzysztof


  reply	other threads:[~2023-05-15 16:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12 13:11 [PATCH v4 00/13] drm/meson: add support for MIPI DSI Display Neil Armstrong
2023-05-12 13:11 ` [PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids Neil Armstrong
2023-05-13 18:28   ` Krzysztof Kozlowski
2023-05-15 16:06     ` Neil Armstrong
2023-05-15 16:13       ` Krzysztof Kozlowski
2023-05-15 16:15         ` Krzysztof Kozlowski
2023-05-15 16:22           ` neil.armstrong
2023-05-15 16:32             ` Krzysztof Kozlowski [this message]
2023-05-16  8:44             ` Arnd Bergmann
2023-05-16  9:00               ` Neil Armstrong
2023-05-30  8:06                 ` Jerome Brunet
2023-05-12 13:11 ` [PATCH v4 02/13] clk: meson: g12a: add CTS_ENCL & CTS_ENCL_SEL clocks Neil Armstrong
2023-05-12 13:11 ` [PATCH v4 03/13] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF Neil Armstrong
2023-05-12 13:11 ` [PATCH v4 04/13] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings Neil Armstrong
2023-05-12 21:35   ` Conor Dooley
2023-05-13 18:32   ` Krzysztof Kozlowski
2023-05-15 16:15     ` Neil Armstrong
2023-05-15 16:22       ` Krzysztof Kozlowski
2023-05-15 16:28         ` neil.armstrong
2023-05-15 16:42           ` Krzysztof Kozlowski
2023-05-12 13:11 ` [PATCH v4 05/13] dt-bindings: display: meson-vpu: add third DPI output port Neil Armstrong
2023-05-12 13:11 ` [PATCH v4 06/13] drm/meson: fix unbind path if HDMI fails to bind Neil Armstrong
2023-05-12 13:11 ` [PATCH v4 07/13] drm/meson: venc: add ENCL encoder setup for MIPI-DSI output Neil Armstrong
2023-05-12 13:11 ` [PATCH v4 08/13] drm/meson: add DSI encoder Neil Armstrong
2023-05-12 13:11 ` [PATCH v4 09/13] drm/meson: add support for MIPI-DSI transceiver Neil Armstrong
2023-05-12 13:11 ` [PATCH v4 10/13] phy: amlogic: phy-meson-g12a-mipi-dphy-analog: fix CNTL2_DIF_TX_CTL0 value Neil Armstrong
2023-05-16 13:04   ` Vinod Koul
2023-05-12 13:11 ` [PATCH v4 11/13] drm/panel: khadas-ts050: update timings to achieve 60Hz refresh rate Neil Armstrong
2023-05-12 13:11 ` [PATCH v4 12/13] arm64: meson: g12-common: add the MIPI DSI nodes Neil Armstrong
2023-05-12 13:11 ` [PATCH v4 13/13] DONOTMERGE: arm64: meson: khadas-vim3l: add DSI panel Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17bfc33b-029f-a0f1-564d-e8c8d0a8695c@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=airlied@gmail.com \
    --cc=arnd@arndb.de \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=kishon@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mturquette@baylibre.com \
    --cc=nbelin@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=olof@lixom.net \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=sboyd@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).