From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA6D0C433F5 for ; Wed, 15 Dec 2021 12:00:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234234AbhLOMAO (ORCPT ); Wed, 15 Dec 2021 07:00:14 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:21458 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234188AbhLOMAN (ORCPT ); Wed, 15 Dec 2021 07:00:13 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20211215120011euoutp02f056972fb7585c0061123666b15c0b84~A6_AMHOF60367903679euoutp020 for ; Wed, 15 Dec 2021 12:00:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20211215120011euoutp02f056972fb7585c0061123666b15c0b84~A6_AMHOF60367903679euoutp020 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1639569611; bh=zb575BIi6vADQbuBPaEgGZN/PvNqmE4WKYZlVlSe+eg=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=ppsoZ08bDN+FtLFqKU+2ifEZkK71NUnOGJulTnwOLAk72aN0OVAs//TKM6NheFudR Y7GG9vhWSomxLEleutgDH6LxsLEg43sSxxtGNnKwsvQMJWyvayUrzJ5Cj8whos2gGo Xo+nWeaheO16PDHZM6HbIm83nMGHR6sqorUvq41w= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20211215120011eucas1p2a8075e810bc13a6f98d2c769e3782d12~A69--fzPD1234612346eucas1p2r; Wed, 15 Dec 2021 12:00:11 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 8D.2E.09887.BC8D9B16; Wed, 15 Dec 2021 12:00:11 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20211215120009eucas1p2fc85c4a4279a73e4d36cc8c144a8cc58~A69_D3BEZ3170731707eucas1p2e; Wed, 15 Dec 2021 12:00:09 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20211215120009eusmtrp27b029aa8f5f8c796a06854be5048a278~A69_C1STA2185321853eusmtrp2L; Wed, 15 Dec 2021 12:00:09 +0000 (GMT) X-AuditID: cbfec7f4-45bff7000000269f-ff-61b9d8cb1558 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 94.8D.09404.9C8D9B16; Wed, 15 Dec 2021 12:00:09 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20211215120008eusmtip2065b7644432a31ed10de3424a8ef2501~A699Znhn40487504875eusmtip2B; Wed, 15 Dec 2021 12:00:08 +0000 (GMT) Message-ID: <17cca00a-85a0-465f-201b-ac4c61b5ae0a@samsung.com> Date: Wed, 15 Dec 2021 13:00:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2] drm: bridge: tc358764: Use drm panel_bridge API Content-Language: en-US To: Jagan Teki , Neil Armstrong , Robert Foss , Laurent Pinchart , Andrzej Hajda Cc: devicetree@vger.kernel.org, linux-amarula@amarulasolutions.com From: Marek Szyprowski In-Reply-To: <20211215100459.44196-1-jagan@amarulasolutions.com> Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMKsWRmVeSWpSXmKPExsWy7djPc7qnb+xMNGhbYGNxf/FnFov5R86x WnzZNIHNonPiEnaL5RP2sVkc6ou2+DTrIbMDu8faj/dZPd7faGX3mN0xk9Vj8Z6XTB53ru1h 8/i8SS6ALYrLJiU1J7MstUjfLoEr48jyIywFTZcYK9a/UGxg3LuDsYuRk0NCwERi/pV3zF2M XBxCAisYJTacameBcL4wSnz8NIMVwvnMKLH++2/2LkYOsJb75wsh4ssZJSZ8PcgO4XxklOg9 1AY2l1fATuJ0w3ZWEJtFQFWi6+NMqLigxMmZT1hAbFGBJInWjj9MILawgLvE9t7JYPXMAuIS t57MZwIZKiLwgFHiwekHzCCbmQWcJKY0yILUsAkYSnS97WIDsTkFHCTa9+xlguiVl2jeOhvs HwmBFxwSDdufsEE86iJx8dpiZghbWOLV8S3sELaMxP+dEMskBJoZJR6eW8sO4fQwSlxumgEN JmuJO+d+sUFcoSmxfpc+RNhRYu7n6ayQYOGTuPFWEOIIPolJ26YzQ4R5JTrahCCq1SRmHV8H t/bghUvMExiVZiEFyywk789C8s4shL0LGFlWMYqnlhbnpqcWG+WllusVJ+YWl+al6yXn525i BKaj0/+Of9nBuPzVR71DjEwcjIcYJTiYlUR4lxrsTBTiTUmsrEotyo8vKs1JLT7EKM3BoiTO m5y5IVFIID2xJDU7NbUgtQgmy8TBKdXA1LzCeYtfQNLjBTLH+yu4/JnaxK8vd7g96drR5RtX O2qyT10yT4FVRFzgXHKPvdxSE4+ojZkSbXdWMQnLKnhuavzeJXop8/9X7+U5PFMO5z86/6Cs ad3Lv1Xs5Rt2rf4wuY1lu7iDWOhTE1nLs1z7F/8uOcXo7t21zF68d3HIfNmbZouEvXZqdest mCDGqzZx2e/Eb5OXpmzmkOrePtnY6VFeUmrhu0UZT52VixN3dmZnS7zV3j1JtkfUWr7Ci3tO benqiP0u77neaTuYzPZq37bh2bIpFdmhPUy5nHItW7ZF/crnnvR6xZYL7EbR55JmLdgV2Zug 7hcTMlnucb2054XpkU12x+ufPfx++MlpJZbijERDLeai4kQA8oigwrYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t/xe7onb+xMNLh7UNvi/uLPLBbzj5xj tfiyaQKbRefEJewWyyfsY7M41Bdt8WnWQ2YHdo+1H++zery/0cruMbtjJqvH4j0vmTzuXNvD 5vF5k1wAW5SeTVF+aUmqQkZ+cYmtUrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+ XYJexpHlR1gKmi4xVqx/odjAuHcHYxcjB4eEgInE/fOFXYxcHEICSxkl1t17xNbFyAkUl5E4 Oa2BFcIWlvhzrYsNoug9o8Sb90vBingF7CRON2wHK2IRUJXo+jiTESIuKHFy5hMWEFtUIEli 97qtYPXCAu4S23sng9UzC4hL3HoynwlkqIjAI0aJH/O3soJcxCzgJDGlQRZi2WSgZWuXMIE0 sAkYSnS97QIbxCngING+Zy8TxCAzia6tXYwQtrxE89bZzBMYhWYhuWMWkn2zkLTMQtKygJFl FaNIamlxbnpusZFecWJucWleul5yfu4mRmD8bTv2c8sOxpWvPuodYmTiYDzEKMHBrCTCu9Rg Z6IQb0piZVVqUX58UWlOavEhRlNgYExklhJNzgcmgLySeEMzA1NDEzNLA1NLM2MlcV7Pgo5E IYH0xJLU7NTUgtQimD4mDk6pBqbJGhHP2xprv4W3rg5JWHX9HAuHz/SvR/M4blvG2EWILxA7 3ebuarinOkQjzyhqfvS6PyyHKz/EbF2wTEf77It/2azPst9U7JYR2d7G5Vi288nE3pTtQhYP qy9faNr4JSXz5sLf3NPSE1tC7zQKPtYvtnVxclvNlfgtzPDCH+5G1UKXzD5PH9aMifZvzoau LpRqnzspY+215tU2ItfWvyrTFW5597Ji5yemA5+toi6an/14/fduwxTfNTGPj3o+rA5eEcv2 cUnrxdWd5/y4nk4KKry68RvH5gilx5HOirsOLdYoqP+u+ih7Bbedvm/OZFdO3gUypaLPZPzv Gx278+3iibPnjV9yM7eYLFZnTlFiKc5INNRiLipOBABOe7DZSAMAAA== X-CMS-MailID: 20211215120009eucas1p2fc85c4a4279a73e4d36cc8c144a8cc58 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20211215100518eucas1p1c3020dd07a9e27e1280d507fa709f09f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20211215100518eucas1p1c3020dd07a9e27e1280d507fa709f09f References: <20211215100459.44196-1-jagan@amarulasolutions.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Jagan, On 15.12.2021 11:04, Jagan Teki wrote: > Replace the manual panel handling code by a drm panel_bridge via > devm_drm_of_get_bridge(). > > Adding panel_bridge handling, > > - Drops drm_connector and related operations as drm_bridge_attach > creates connector during attachment. > > - Drops panel pointer and panel healpers. > > This simplifies the driver and allows all components in the display > pipeline to be treated as bridges. > > Signed-off-by: Jagan Teki I just tested it on top of linux-next with "drm: of: Lookup if child node has panel or bridge" patch. Sadly it still doesn't work on Exynos5250-based Arndale board: OF: graph: no port node found in /soc/hdmi@14530000 [drm] Exynos DRM: using 14400000.fimd device for DMA mapping operations exynos-drm exynos-drm: bound 14400000.fimd (ops fimd_component_ops) exynos-drm exynos-drm: bound 14450000.mixer (ops mixer_component_ops) OF: graph: no port node found in /soc/dsi@14500000 exynos-drm exynos-drm: bound 14500000.dsi (ops exynos_dsi_component_ops) exynos-drm exynos-drm: bound 14530000.hdmi (ops hdmi_component_ops) exynos-drm exynos-drm: [drm] Cannot find any crtc or sizes exynos-drm exynos-drm: [drm] Cannot find any crtc or sizes [drm] Initialized exynos 1.1.0 20180330 for exynos-drm on minor 0 panfrost 11800000.gpu: clock rate = 533000000 panfrost 11800000.gpu: mali-t600 id 0x600 major 0x0 minor 0x0 status 0x1 panfrost 11800000.gpu: features: 00000000,10206000, issues: 00000000,31b4dfff panfrost 11800000.gpu: Features: L2:0x07110206 Shader:0x00000000 Tiler:0x00000809 Mem:0x1 MMU:0x00002830 AS:0xf JS:0x7 panfrost 11800000.gpu: shader_present=0xf l2_present=0x1 [drm] Initialized panfrost 1.2.0 20180908 for 11800000.gpu on minor 1 ------------[ cut here ]------------ WARNING: CPU: 1 PID: 7 at drivers/gpu/drm/drm_atomic_state_helper.c:494 drm_atomic_helper_connector_duplicate_state+0x60/0x68 Modules linked in: CPU: 1 PID: 7 Comm: kworker/u4:0 Not tainted 5.16.0-rc5-next-20211214-00004-gac0282c4faed #11089 Hardware name: Samsung Exynos (Flattened Device Tree) Workqueue: events_unbound deferred_probe_work_func [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack_lvl+0x58/0x70) [] (dump_stack_lvl) from [] (__warn+0x238/0x23c) [] (__warn) from [] (warn_slowpath_fmt+0xac/0xb4) [] (warn_slowpath_fmt) from [] (drm_atomic_helper_connector_duplicate_state+0x60/0x68) [] (drm_atomic_helper_connector_duplicate_state) from [] (drm_atomic_get_connector_state+0xd8/0x190) [] (drm_atomic_get_connector_state) from [] (__drm_atomic_helper_set_config+0x2a0/0x368) [] (__drm_atomic_helper_set_config) from [] (drm_client_modeset_commit_atomic+0x178/0x27c) [] (drm_client_modeset_commit_atomic) from [] (drm_client_modeset_commit_locked+0x48/0x1d0) [] (drm_client_modeset_commit_locked) from [] (drm_client_modeset_commit+0x24/0x40) [] (drm_client_modeset_commit) from [] (__drm_fb_helper_restore_fbdev_mode_unlocked+0x64/0xc8) [] (__drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x38/0x64) [] (drm_fb_helper_set_par) from [] (fbcon_init+0x48c/0x510) [] (fbcon_init) from [] (visual_init+0xc0/0x108) [] (visual_init) from [] (do_bind_con_driver+0x1ac/0x388) [] (do_bind_con_driver) from [] (do_take_over_console+0x13c/0x1c8) [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xcc) [] (do_fbcon_takeover) from [] (register_framebuffer+0x1c8/0x2d8) [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x440/0x65c) [] (__drm_fb_helper_initial_config_and_unlock) from [] (drm_kms_helper_hotplug_event+0x24/0x30) [] (drm_kms_helper_hotplug_event) from [] (exynos_dsi_host_attach+0x170/0x2a4) [] (exynos_dsi_host_attach) from [] (tc358764_probe+0xe8/0x160) [] (tc358764_probe) from [] (really_probe+0x190/0x450) [] (really_probe) from [] (__driver_probe_device+0xa4/0x204) [] (__driver_probe_device) from [] (driver_probe_device+0x34/0xd4) [] (driver_probe_device) from [] (__device_attach_driver+0xb0/0x11c) [] (__device_attach_driver) from [] (bus_for_each_drv+0x70/0xb4) [] (bus_for_each_drv) from [] (__device_attach+0xe0/0x178) [] (__device_attach) from [] (bus_probe_device+0x88/0x90) [] (bus_probe_device) from [] (deferred_probe_work_func+0x4c/0xe8) [] (deferred_probe_work_func) from [] (process_one_work+0x2c8/0x7ec) [] (process_one_work) from [] (worker_thread+0x50/0x584) [] (worker_thread) from [] (kthread+0x13c/0x19c) [] (kthread) from [] (ret_from_fork+0x14/0x2c) Exception stack(0xc1cc1fb0 to 0xc1cc1ff8) 1fa0:                                     00000000 00000000 00000000 00000000 1fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 1fe0: 00000000 00000000 00000000 00000000 00000013 00000000 irq event stamp: 21503 hardirqs last  enabled at (21509): [] vprintk_emit+0x270/0x2b4 hardirqs last disabled at (21514): [] vprintk_emit+0x22c/0x2b4 softirqs last  enabled at (18950): [] __do_softirq+0x4cc/0x5ec softirqs last disabled at (18945): [] irq_exit+0x1cc/0x200 ---[ end trace 0000000000000000 ]--- ------------[ cut here ]------------ WARNING: CPU: 1 PID: 7 at drivers/gpu/drm/drm_atomic_state_helper.c:494 drm_atomic_helper_connector_duplicate_state+0x60/0x68 Modules linked in: CPU: 1 PID: 7 Comm: kworker/u4:0 Tainted: G        W 5.16.0-rc5-next-20211214-00004-gac0282c4faed #11089 Hardware name: Samsung Exynos (Flattened Device Tree) Workqueue: events_unbound deferred_probe_work_func [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack_lvl+0x58/0x70) [] (dump_stack_lvl) from [] (__warn+0x238/0x23c) [] (__warn) from [] (warn_slowpath_fmt+0xac/0xb4) [] (warn_slowpath_fmt) from [] (drm_atomic_helper_connector_duplicate_state+0x60/0x68) [] (drm_atomic_helper_connector_duplicate_state) from [] (drm_atomic_get_connector_state+0xd8/0x190) [] (drm_atomic_get_connector_state) from [] (__drm_atomic_helper_set_config+0x2a0/0x368) [] (__drm_atomic_helper_set_config) from [] (drm_client_modeset_commit_atomic+0x178/0x27c) [] (drm_client_modeset_commit_atomic) from [] (drm_client_modeset_commit_locked+0x48/0x1d0) [] (drm_client_modeset_commit_locked) from [] (drm_fb_helper_pan_display+0x90/0x1c4) [] (drm_fb_helper_pan_display) from [] (fb_pan_display+0xcc/0x138) [] (fb_pan_display) from [] (bit_update_start+0x14/0x30) [] (bit_update_start) from [] (fbcon_switch+0x2d0/0x3e4) [] (fbcon_switch) from [] (redraw_screen+0x15c/0x22c) [] (redraw_screen) from [] (fbcon_prepare_logo+0x2d4/0x450) [] (fbcon_prepare_logo) from [] (fbcon_init+0x3b4/0x510) [] (fbcon_init) from [] (visual_init+0xc0/0x108) [] (visual_init) from [] (do_bind_con_driver+0x1ac/0x388) [] (do_bind_con_driver) from [] (do_take_over_console+0x13c/0x1c8) [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xcc) [] (do_fbcon_takeover) from [] (register_framebuffer+0x1c8/0x2d8) [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x440/0x65c) [] (__drm_fb_helper_initial_config_and_unlock) from [] (drm_kms_helper_hotplug_event+0x24/0x30) [] (drm_kms_helper_hotplug_event) from [] (exynos_dsi_host_attach+0x170/0x2a4) [] (exynos_dsi_host_attach) from [] (tc358764_probe+0xe8/0x160) [] (tc358764_probe) from [] (really_probe+0x190/0x450) [] (really_probe) from [] (__driver_probe_device+0xa4/0x204) [] (__driver_probe_device) from [] (driver_probe_device+0x34/0xd4) [] (driver_probe_device) from [] (__device_attach_driver+0xb0/0x11c) [] (__device_attach_driver) from [] (bus_for_each_drv+0x70/0xb4) [] (bus_for_each_drv) from [] (__device_attach+0xe0/0x178) [] (__device_attach) from [] (bus_probe_device+0x88/0x90) [] (bus_probe_device) from [] (deferred_probe_work_func+0x4c/0xe8) [] (deferred_probe_work_func) from [] (process_one_work+0x2c8/0x7ec) [] (process_one_work) from [] (worker_thread+0x50/0x584) [] (worker_thread) from [] (kthread+0x13c/0x19c) [] (kthread) from [] (ret_from_fork+0x14/0x2c) Exception stack(0xc1cc1fb0 to 0xc1cc1ff8) 1fa0:                                     00000000 00000000 00000000 00000000 1fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 1fe0: 00000000 00000000 00000000 00000000 00000013 00000000 irq event stamp: 21591 hardirqs last  enabled at (21597): [] vprintk_emit+0x270/0x2b4 hardirqs last disabled at (21602): [] vprintk_emit+0x22c/0x2b4 softirqs last  enabled at (18950): [] __do_softirq+0x4cc/0x5ec softirqs last disabled at (18945): [] irq_exit+0x1cc/0x200 ---[ end trace 0000000000000000 ]--- Console: switching to colour frame buffer device 146x42 ------------[ cut here ]------------ WARNING: CPU: 1 PID: 7 at drivers/gpu/drm/drm_atomic_state_helper.c:494 drm_atomic_helper_connector_duplicate_state+0x60/0x68 Modules linked in: CPU: 1 PID: 7 Comm: kworker/u4:0 Tainted: G        W 5.16.0-rc5-next-20211214-00004-gac0282c4faed #11089 Hardware name: Samsung Exynos (Flattened Device Tree) Workqueue: events_unbound deferred_probe_work_func [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack_lvl+0x58/0x70) [] (dump_stack_lvl) from [] (__warn+0x238/0x23c) [] (__warn) from [] (warn_slowpath_fmt+0xac/0xb4) [] (warn_slowpath_fmt) from [] (drm_atomic_helper_connector_duplicate_state+0x60/0x68) [] (drm_atomic_helper_connector_duplicate_state) from [] (drm_atomic_get_connector_state+0xd8/0x190) [] (drm_atomic_get_connector_state) from [] (__drm_atomic_helper_set_config+0x2a0/0x368) [] (__drm_atomic_helper_set_config) from [] (drm_client_modeset_commit_atomic+0x178/0x27c) [] (drm_client_modeset_commit_atomic) from [] (drm_client_modeset_commit_locked+0x48/0x1d0) [] (drm_client_modeset_commit_locked) from [] (drm_fb_helper_pan_display+0x90/0x1c4) [] (drm_fb_helper_pan_display) from [] (fb_pan_display+0xcc/0x138) [] (fb_pan_display) from [] (bit_update_start+0x14/0x30) [] (bit_update_start) from [] (fbcon_switch+0x2d0/0x3e4) [] (fbcon_switch) from [] (redraw_screen+0x15c/0x22c) [] (redraw_screen) from [] (do_bind_con_driver+0x2b8/0x388) [] (do_bind_con_driver) from [] (do_take_over_console+0x13c/0x1c8) [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xcc) [] (do_fbcon_takeover) from [] (register_framebuffer+0x1c8/0x2d8) [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x440/0x65c) [] (__drm_fb_helper_initial_config_and_unlock) from [] (drm_kms_helper_hotplug_event+0x24/0x30) [] (drm_kms_helper_hotplug_event) from [] (exynos_dsi_host_attach+0x170/0x2a4) [] (exynos_dsi_host_attach) from [] (tc358764_probe+0xe8/0x160) [] (tc358764_probe) from [] (really_probe+0x190/0x450) [] (really_probe) from [] (__driver_probe_device+0xa4/0x204) [] (__driver_probe_device) from [] (driver_probe_device+0x34/0xd4) [] (driver_probe_device) from [] (__device_attach_driver+0xb0/0x11c) [] (__device_attach_driver) from [] (bus_for_each_drv+0x70/0xb4) [] (bus_for_each_drv) from [] (__device_attach+0xe0/0x178) [] (__device_attach) from [] (bus_probe_device+0x88/0x90) [] (bus_probe_device) from [] (deferred_probe_work_func+0x4c/0xe8) [] (deferred_probe_work_func) from [] (process_one_work+0x2c8/0x7ec) [] (process_one_work) from [] (worker_thread+0x50/0x584) [] (worker_thread) from [] (kthread+0x13c/0x19c) [] (kthread) from [] (ret_from_fork+0x14/0x2c) Exception stack(0xc1cc1fb0 to 0xc1cc1ff8) 1fa0:                                     00000000 00000000 00000000 00000000 1fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 1fe0: 00000000 00000000 00000000 00000000 00000013 00000000 irq event stamp: 21675 hardirqs last  enabled at (21681): [] vprintk_emit+0x270/0x2b4 hardirqs last disabled at (21686): [] vprintk_emit+0x22c/0x2b4 softirqs last  enabled at (18950): [] __do_softirq+0x4cc/0x5ec softirqs last disabled at (18945): [] irq_exit+0x1cc/0x200 ---[ end trace 0000000000000000 ]--- exynos-drm exynos-drm: [drm] fb0: exynosdrmfb frame buffer device # ./modetest -Mexynos  ------------[ cut here ]------------  WARNING: CPU: 1 PID: 1312 at drivers/gpu/drm/drm_atomic_state_helper.c:494 drm_atomic_helper_connector_duplicate_state+0x60/0x68  Modules linked in: s5p_mfc exynos_gsc v4l2_mem2mem videobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common videodev mc  CPU: 1 PID: 1312 Comm: modetest Tainted: G        W 5.16.0-rc5-next-20211214-00004-gac0282c4faed #11089  Hardware name: Samsung Exynos (Flattened Device Tree)  [] (unwind_backtrace) from [] (show_stack+0x10/0x14)  [] (show_stack) from [] (dump_stack_lvl+0x58/0x70)  [] (dump_stack_lvl) from [] (__warn+0x238/0x23c)  [] (__warn) from [] (warn_slowpath_fmt+0xac/0xb4)  [] (warn_slowpath_fmt) from [] (drm_atomic_helper_connector_duplicate_state+0x60/0x68)  [] (drm_atomic_helper_connector_duplicate_state) from [] (drm_atomic_get_connector_state+0xd8/0x190)  [] (drm_atomic_get_connector_state) from [] (__drm_atomic_helper_set_config+0x2a0/0x368)  [] (__drm_atomic_helper_set_config) from [] (drm_client_modeset_commit_atomic+0x178/0x27c)  [] (drm_client_modeset_commit_atomic) from [] (drm_client_modeset_commit_locked+0x48/0x1d0)  [] (drm_client_modeset_commit_locked) from [] (drm_client_modeset_commit+0x24/0x40)  [] (drm_client_modeset_commit) from [] (__drm_fb_helper_restore_fbdev_mode_unlocked+0x64/0xc8)  [] (__drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_lastclose+0x30/0x4c)  [] (drm_lastclose) from [] (drm_release+0x110/0x114)  [] (drm_release) from [] (__fput+0x88/0x258)  [] (__fput) from [] (task_work_run+0x8c/0xc8)  [] (task_work_run) from [] (do_work_pending+0x534/0x63c)  [] (do_work_pending) from [] (slow_work_pending+0xc/0x20)  Exception stack(0xc1d31fb0 to 0xc1d31ff8)  1fa0:                                     00000000 0000001f e8fd3e00 00000000  1fc0: 00000001 00000003 00000000 00000006 00022188 00000000 b6fbd000 00000000  1fe0: b6ebeaa0 bea09aa8 0000e7c4 b6ebeac0 60000010 00000003  irq event stamp: 3205  hardirqs last  enabled at (3213): [] __up_console_sem+0x50/0x60  hardirqs last disabled at (3236): [] __schedule+0x554/0x964  softirqs last  enabled at (3232): [] __do_softirq+0x4cc/0x5ec  softirqs last disabled at (3221): [] irq_exit+0x1cc/0x200  ---[ end trace 0000000000000000 ]--- could not get [  426.570917] ------------[ cut here ]------------  WARNING: CPU: 1 PID: 1312 at drivers/gpu/drm/drm_atomic_state_helper.c:494 drm_atomic_helper_connector_duplicate_state+0x60/0x68  Modules linked in: s5p_mfc exynos_gsc v4l2_mem2mem videobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common videodev mc  CPU: 1 PID: 1312 Comm: modetest Tainted: G        W 5.16.0-rc5-next-20211214-00004-gac0282c4faed #11089  Hardware name: Samsung Exynos (Flattened Device Tree)  [] (unwind_backtrace) from [] (show_stack+0x10/0x14)  [] (show_stack) from [] (dump_stack_lvl+0x58/0x70)  [] (dump_stack_lvl) from [] (__warn+0x238/0x23c)  [] (__warn) from [] (warn_slowpath_fmt+0xac/0xb4)  [] (warn_slowpath_fmt) from [] (drm_atomic_helper_connector_duplicate_state+0x60/0x68)  [] (drm_atomic_helper_connector_duplicate_state) from [] (drm_atomic_get_connector_state+0xd8/0x190)  [] (drm_atomic_get_connector_state) from [] (__drm_atomic_helper_set_config+0x2a0/0x368)  [] (__drm_atomic_helper_set_config) from [] (drm_client_modeset_commit_atomic+0x178/0x27c)  [] (drm_client_modeset_commit_atomic) from [] (drm_client_modeset_commit_locked+0x48/0x1d0)  [] (drm_client_modeset_commit_locked) from [] (drm_client_modeset_commit+0x24/0x40)  [] (drm_client_modeset_commit) from [] (__drm_fb_helper_restore_fbdev_mode_unlocked+0x64/0xc8)  [] (__drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_lastclose+0x30/0x4c)  [] (drm_lastclose) from [] (drm_release+0x110/0x114)  [] (drm_release) from [] (__fput+0x88/0x258)  [] (__fput) from [] (task_work_run+0x8c/0xc8)  [] (task_work_run) from [] (do_exit+0x3f8/0xc1c)  [] (do_exit) from [] (do_group_exit+0x2c/0xa0)  [] (do_group_exit) from [] (get_signal+0x1d0/0xe6c)  [] (get_signal) from [] (do_work_pending+0x11c/0x63c)  [] (do_work_pending) from [] (slow_work_pending+0xc/0x20)  Exception stack(0xc1d31fb0 to 0xc1d31ff8)  1fa0:                                     00000008 0000005f 00000002 00023388  1fc0: 00000001 000232a8 00000000 00023398 0000003e 00000000 00023360 00000000  1fe0: 00023590 bea09af8 00009ec0 00009e9c 80000010 ffffffff  irq event stamp: 3693  hardirqs last  enabled at (3701): [] __up_console_sem+0x50/0x60  hardirqs last disabled at (3710): [] __up_console_sem+0x3c/0x60  softirqs last  enabled at (3688): [] __do_softirq+0x4cc/0x5ec  softirqs last disabled at (3661): [] irq_exit+0x1cc/0x200  ---[ end trace 0000000000000000 ]--- connector 62: No such file or directory Segmentation fault > --- > Changes for v2: > - s/panel_bridge/next_bridge > - drop unneeded headers > > drivers/gpu/drm/bridge/tc358764.c | 104 ++---------------------------- > 1 file changed, 6 insertions(+), 98 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c > index c1e35bdf9232..dca41ed32f8a 100644 > --- a/drivers/gpu/drm/bridge/tc358764.c > +++ b/drivers/gpu/drm/bridge/tc358764.c > @@ -16,14 +16,9 @@ > #include