From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FFEEB64DD for ; Thu, 3 Aug 2023 14:30:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235349AbjHCOaN (ORCPT ); Thu, 3 Aug 2023 10:30:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233595AbjHCOaM (ORCPT ); Thu, 3 Aug 2023 10:30:12 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 637DFF0 for ; Thu, 3 Aug 2023 07:30:11 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-52307552b03so1380712a12.0 for ; Thu, 03 Aug 2023 07:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691073010; x=1691677810; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TLGQIBcmnPlkP1H90L4arPiKiIXchPemEGcuJPAOma0=; b=V+wQrfpbow5/ttxZyUaV1RdKWQBC7AlUZ+3pcXXgdBtzPOqOmhWAJj48MQ2U9Uu1Uh 0hnPC98eznmSl92mH0pwquOMr4wm2BVnKGHKU9b6cP2b9g0NzW5jsIZ9WigeqeG5wMpP WAKPsyO7mcI6WXaLmxpP13y2dwywJxIuOQbO7Voz9sPm7KK4bdzTpEhKCamLxREpsZDK u/s1C64p5ogdHE6+0YMBAlD+f1hiY6xh6x+Xg65Erhk9UkBCxZ+pqKQXXIjXy4r9pHOR XC/z3K4SP2DpXMumtmvd5xcVevAlg0cNvG7rQ2ljBVr6wsL9uq222QCYvEBiUnzG3gyA Xx7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691073010; x=1691677810; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TLGQIBcmnPlkP1H90L4arPiKiIXchPemEGcuJPAOma0=; b=ZHrXBEdtPxpJb5V+fc4n/gmbEEqV6lRkyBmj06pk2JCTqXsZ2hkVGjYj6gEtJpNLng J/MQK/Ps/S61X4vcwMvrEOSRyZneMVtMfORXkzTeZcEhD1GtwAqay0nHpy40QTGOc3ho 2BwCTiB7YTeGTbt0Tqk4NSnriX8EBzWEqPJh6vvD4PQc98aRWClTXBf/2J2RkUrv0OfA I6KcsdRfd2JFbbCbuFbBnuq3r69SMPhy00yWgrpIYa3qWAHXWmXV2RH26Hp7z+ucULoq YYLzaa9OI46RjLox1XpCOPOe0zE5kzf9zf0A5lWvtHVTPR37bbdbveQAY4LDi4AkwL8i lZ7A== X-Gm-Message-State: ABy/qLav4eE3CgSHlKcDUm/jZAxyK0NDDZZMDTrpPZsApXuhZ8Xhsvz/ SbdR6ekz/g3dINKeiWfOAG4PkQ== X-Google-Smtp-Source: APBJJlHOlI75QhDtYFAg9HERhBvyV2JLY/tIUjauBt+B1yJGtKwFW58txzygi3y9gEXeh2orqraKGw== X-Received: by 2002:aa7:d705:0:b0:521:e502:baf8 with SMTP id t5-20020aa7d705000000b00521e502baf8mr7841254edq.11.1691073009875; Thu, 03 Aug 2023 07:30:09 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.245]) by smtp.gmail.com with ESMTPSA id d7-20020a056402078700b005221ce96801sm10344275edy.35.2023.08.03.07.30.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 07:30:09 -0700 (PDT) Message-ID: <17dec3fb-1bce-77ff-9917-7f565049954d@linaro.org> Date: Thu, 3 Aug 2023 16:30:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v1 6/6] arm64: dts: allwinner: h616: Add BigTreeTech Pi support Content-Language: en-US To: Martin Botka Cc: Konrad Dybcio , AngeloGioacchino Del Regno , Marijn Suijten , Jami Kettunen , Paul Bouchara , Martin Botka , Andre Przywara , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andrew Lunn , Icenowy Zheng , Ludwig Kormann , Heiko Stuebner , Shawn Guo , Bjorn Andersson , Chris Morgan , Jagan Teki , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20230802220309.163804-1-martin@biqu3d.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/08/2023 00:02, Martin Botka wrote: > The BigTreeTech Pi is an H616 based board based on CB1. > Just in Rpi format board. > > It features the same internals as BTT CB1 but adds: > - Fan port > - IR receiver > - 24V DC power supply via terminal plugs > - USB to CAN module connector (The actual USB to CAN happens on the external module) > > List of currently working things is the same as BTT CB1. > > Signed-off-by: Martin Botka > --- > .../allwinner/sun50i-h616-bigtreetech-pi.dts | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > new file mode 100644 > index 000000000000..05f39b3606ba > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > @@ -0,0 +1,44 @@ > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > +/* > + * Copyright (C) 2023 Martin Botka . > + */ > + > +/dts-v1/; > + > +#include "sun50i-h616-bigtreetech-cb1.dtsi" If this is using CB1 DTSI, does it mean it uses CB1 SoM? If so, I think this should be reflected in the compatibles. It's a bit confusing because in previous patch you call it "CB1 board" but then with name "Manta"... So what is CB1? Best regards, Krzysztof