From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A31721F03C5; Fri, 24 Oct 2025 07:58:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761292730; cv=none; b=fkcmfFOuFb09PEVIInamdFlSgMpZ7eyWEPkhWlbNSfDX3T95S6ncJAvF6O3f77tvoLJ9qOTp7KYBEgop4rWGl1PsabFF23UFzMYXKN8cHjEgcD952U7d27Azw+4bb7fY+h0+G+yRhctpZyIUSCcYPTP163hM73q6T111e7OdV9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761292730; c=relaxed/simple; bh=ujRgliuJ9opWyA1dA8HvH6KZTXat+2uy7+UPCFas1j0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=Xl762dTzDHsaJJkVb6zDfnYESbZN7UYwE5Zlp2G5UHbztRquPvu+CEETBdqF9PUjH1QL6tX6NMY1C1WW/sQHJo6GZEOwjdz/kJsaOL0W0k/MixmBaFtp+gmUbHe0Uuvez2sdisij6oMcHBuzhKrXk03xc6a/olP5+CvVIJmPS1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UKCBUcnz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UKCBUcnz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26EF2C4CEF1; Fri, 24 Oct 2025 07:58:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761292730; bh=ujRgliuJ9opWyA1dA8HvH6KZTXat+2uy7+UPCFas1j0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=UKCBUcnzJQr76xTGhoIzETFC5ITuiydigeyH8N/rw4KB4W6JdbSQnUERuSlthla5Z f8QW/EYHzNyY2+by/N2dXpA/TyML6BT95DdHTwTjER+6WV+NeEjvdTT/u7IOIrpDWt RnDcvWNZ7H7A5ov4EG1rjXH6+AUqeGVMQGwCBwsfoze/E53KunnICvGtjC27tY4uKk qTCjv9Spb7y+DNGhpa/bMZ+f98K9ICt3i1L3dNwtdsvz/5wuYPJvJmqaiN/MZKRRA5 aKlmZirHKa5leHEzSb/oaw5GMrEMUGcx/nUFLyXSbOQIhj9zS/4lYWEzmhTcMNlHeH 4inoakiXP0KyA== Message-ID: <17ebfe0f-ec3b-4f93-9146-f191d9c6a7fc@kernel.org> Date: Fri, 24 Oct 2025 09:58:46 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mailbox: renesas: Support MFIS mailbox driver To: Kuninori Morimoto , Conor Dooley , Geert Uytterhoeven , Jassi Brar , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <87frb8n7kl.wl-kuninori.morimoto.gx@renesas.com> <87cy6cn7jg.wl-kuninori.morimoto.gx@renesas.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <87cy6cn7jg.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/10/2025 08:22, Kuninori Morimoto wrote: > From: Masashi Ozaki > > Add Renesas MFIS mailbox driver for R8A78000 (X5H) > > Signed-off-by: Masashi Ozaki > Signed-off-by: Vinh Nguyen > Signed-off-by: Kuninori Morimoto > --- > drivers/mailbox/Kconfig | 10 +- > drivers/mailbox/Makefile | 2 + > drivers/mailbox/rcar-mfis-mailbox.c | 137 ++++++++++++++++++++++++++++ > 3 files changed, 148 insertions(+), 1 deletion(-) > create mode 100644 drivers/mailbox/rcar-mfis-mailbox.c > > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > index e47cb68989267..07e6bf06effe3 100644 > --- a/drivers/mailbox/Kconfig > +++ b/drivers/mailbox/Kconfig > @@ -379,6 +379,15 @@ config BCM74110_MAILBOX > processor and coprocessor that handles various power management task > and more. > > +config RCAR_MFIS_MBOX > + bool "Renesas R-Car Multifunctional Interface Mailbox Support" > + depends on ARM_SCMI_PROTOCOL && ARCH_RENESAS I don't see any build restrictions, why no compile test? > + help > + This driver provides support for SCMI interface transport with > + MFIS(Multifunctional Interface). > + It is used to send short message between CPU cores and > + SCP(System Control Processor). > + > config RISCV_SBI_MPXY_MBOX > tristate "RISC-V SBI Message Proxy (MPXY) Mailbox" > depends on RISCV_SBI > @@ -389,5 +398,4 @@ config RISCV_SBI_MPXY_MBOX > remote processor through the SBI implementation (M-mode firmware > or HS-mode hypervisor). Say Y here if you want to have this support. > If unsure say N. > - Does not look as intended change. ... > + > +static int mfis_startup(struct mbox_chan *link) > +{ > + struct mbox_controller *mbox = link->mbox; > + struct device *dev = mbox->dev; > + int irq; > + int ret; > + > + irq = of_irq_get(dev->of_node, 0); > + > + ret = request_irq(irq, mfis_rx_interrupt, > + IRQF_SHARED, "mfis-mbox", link); > + if (ret) { > + dev_err(dev, > + "Unable to acquire IRQ %d\n", irq); Please don't wrap lines when not necessary. This only hurts readability. > + return ret; > + } > + > + ret = mbox_controller_register(mbox); > + if (ret) > + return ret; > + > + platform_set_drvdata(pdev, mbox); > + dev_info(dev, "MFIS mailbox is probed\n"); This does not look like useful printk message. Drivers should be silent on success: https://elixir.bootlin.com/linux/v6.15-rc7/source/Documentation/process/coding-style.rst#L913 https://elixir.bootlin.com/linux/v6.15-rc7/source/Documentation/process/debugging/driver_development_debugging_guide.rst#L79 > + > + return 0; > +} > + > +static const struct of_device_id mfis_mbox_of_match[] = { > + { .compatible = "renesas,mfis-mbox", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, mfis_mbox_of_match); > + > +static struct platform_driver mfis_mbox_driver = { > + .driver = { > + .name = "renesas-mfis-mbox", > + .of_match_table = mfis_mbox_of_match, > + }, > + .probe = mfis_mbox_probe, > +}; > +module_platform_driver(mfis_mbox_driver); > +MODULE_DESCRIPTION("Renesas MFIS mailbox driver"); > +MODULE_LICENSE("GPL v2"); Best regards, Krzysztof