From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error Date: Wed, 22 May 2019 14:34:58 +0200 Message-ID: <1805430.MCm2xJzUXA@phil> References: <1556618986-18923-1-git-send-email-zhangqing@rock-chips.com> <2174314.1vfUlvne1O@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Daniel Lezcano Cc: Enric Balletbo Serra , Elaine Zhang , Mark Rutland , "devicetree@vger.kernel.org" , huangtao@rock-chips.com, Linux PM list , xxx@rock-chips.com, xf@rock-chips.com, linux-kernel , Eduardo Valentin , "open list:ARM/Rockchip SoC..." , Rob Herring , Zhang Rui , Linux ARM , Doug Anderson , vicencb@gmail.com List-Id: devicetree@vger.kernel.org Am Mittwoch, 22. Mai 2019, 14:30:16 CEST schrieb Daniel Lezcano: > On 22/05/2019 14:27, Heiko Stuebner wrote: > > [ ... ] > > >> As this change is now in mainline and is causing veyron to hang I'd > >> suggest reverting this change for now. Even fixing the root cause > >> (maybe the one I pointed above) after this patch we will have the > >> thermal driver to fail because "gpio" and "otpout" states are not > >> defined nor documented (a change on this will need some reviews and > >> acks and time I guess). > > > > I definitly agree here. Handling + checking the binding change > > as well as needed fallback code is definitly not material for -rc-kernels > > so we should just revert for now and let Elaine fix the issues for 5.3. > > > > Anyone volunteering for sending a revert-patch to Eduardo? :-) > > I can't right now :/ ok, I'll do the revert patch then, so that we get this sorted. Heiko