From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] arm64: dts: rockchip: add USB 2.0 and 3.0 support on Ficus board Date: Thu, 12 Jul 2018 23:45:29 +0200 Message-ID: <1807608.jKivtyaJVm@phil> References: <20180712160008.30972-1-ezequiel@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180712160008.30972-1-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Ezequiel Garcia Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Enric Balletbo i Serra , kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, Am Donnerstag, 12. Juli 2018, 18:00:08 CEST schrieb Ezequiel Garcia: > From: Enric Balletbo i Serra > > The board exposes two types A ports, one is USB 3.0, up to 5.0Gbps and > another one is USB 2.0 up to 480Mbps. Enable the USB PHYs and the USB > controllers to enable theses devices. > > Signed-off-by: Enric Balletbo i Serra > Signed-off-by: Ezequiel Garcia > --- > Heiko, > > Enric finally had some time to take a look at the schematics, > and help with the USB stuff. Thanks to him, USB host > is working now! \o/ great to hear that One issue below though. > USB Type-C will have to wait until we have some spare time > to debug the fusb302 driver. > > arch/arm64/boot/dts/rockchip/rk3399-ficus.dts | 85 +++++++++++++++++++ > 1 file changed, 85 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts b/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts > index 0d14183dd4a9..d0631c02749c 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts > @@ -61,6 +61,16 @@ > vin-supply = <&vcc3v3_sys>; > }; > > + vcc5v0_host: vcc5v0-host-regulator { > + compatible = "regulator-fixed"; > + enable-active-high; > + gpio = <&gpio4 27 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&host_vbus_drv>; > + regulator-name = "vcc5v0_host"; > + regulator-always-on; missing voltages and also a vin-supply. These 5V don't come from thin air ;-) and I really like seeing sane regulator trees. Thanks Heiko