From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87B9BECAAD5 for ; Mon, 5 Sep 2022 10:02:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236676AbiIEKCV (ORCPT ); Mon, 5 Sep 2022 06:02:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237090AbiIEKCK (ORCPT ); Mon, 5 Sep 2022 06:02:10 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E389140BDB for ; Mon, 5 Sep 2022 03:02:04 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id s15so8690694ljp.5 for ; Mon, 05 Sep 2022 03:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=kv+9RhK6Phq32sz2Yl+XWwSP6NnSDQP/fc+4aYg9QaQ=; b=ZWJDH3e423PJDPRLzmSyD3kH4yLHsRKkoZAQg7qEEKZ9RNXzxE9cUZG3NHAy2XzPxM tS0KsQyYPss6M2fB4G9t8bPvkBnKM52Ym++N2/cWgauaUTDzmH3Kd7U48yjz0JCIGBrg YglWSQ76yhFjdkjsiiJCiTNUM70lc52cm3gSA/MprgGR3j8kgYNVP5NtQLbiEXYi/YdH 98ktB88CPskOD1+V9eFbuGb5qeq4ZFEeiVgNZPB90X6Cr+X8fprBd26Smt+a5hDopDY1 hN5wpcMz1qvSwothFQqo15Dy+9QetABLnP3pE36OQ/jF71TmUlSefaSaXKmQw27C0KQx lLrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=kv+9RhK6Phq32sz2Yl+XWwSP6NnSDQP/fc+4aYg9QaQ=; b=Kr6cVmlcsQcZ3OSICQX/hNbJFFhLTxHB/xb4tbWpnPaFQTruzOFZr1KL77K0NMEcvL sIHcRmVeFnb6XPtlCuSA5r2mQnhDrN/KZKP5qcOk9MZ+SPiAIAkrBXPFVb0YyZf+Ke6T CuR99Zt0hpD12PKJgia/6OyP4xSWrkFvSbArCm3aR0RN1y+jfcwK2uo3kSn7ANX7iPqD LjFYL531Ilxy0MeGwCzzPOYgfHiHi5zQPwDBccPpHKo2fL1tASUCkTqO2Op2KB7d5DaX ave4hxLwLei9rQFlAVfvkM1s3i4aQIIFV/bolEo2mUmoMokwd/d+a9246wWlb2f5fEsT D+zw== X-Gm-Message-State: ACgBeo3HWNU3NYZUbeLEixsykqRgf2/rvGwGLBPzl7O4FMBRoMzjJil0 SVt3MR0gIzD7BzB4AZNmZQKtVw== X-Google-Smtp-Source: AA6agR7OB5Exv3WD5wTyvP9jb8gQY+3szQ3dx1oxNUhvpIRU05qPWHnuzZVps5Q7ha3Ji3sgyVsUmA== X-Received: by 2002:a05:651c:1507:b0:268:d775:4e52 with SMTP id e7-20020a05651c150700b00268d7754e52mr4761186ljf.258.1662372122738; Mon, 05 Sep 2022 03:02:02 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id o22-20020ac24e96000000b00494a2a0f6cfsm1140371lfr.183.2022.09.05.03.02.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 03:02:02 -0700 (PDT) Message-ID: <180f706d-3304-3a5a-82b7-f37948e5d100@linaro.org> Date: Mon, 5 Sep 2022 12:02:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 09/14] arm64: dts: qcom: sm6115: Add UFS nodes Content-Language: en-US To: Iskren Chernev , Bjorn Andersson , Rob Herring Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , linux-kernel@vger.kernel.org References: <20220901072414.1923075-1-iskren.chernev@gmail.com> <20220901072414.1923075-10-iskren.chernev@gmail.com> <488be3d3-d4c4-6200-be99-b85e6ac72c34@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <488be3d3-d4c4-6200-be99-b85e6ac72c34@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/09/2022 19:04, Iskren Chernev wrote: > > > On 9/1/22 19:13, Krzysztof Kozlowski wrote: >> On 01/09/2022 10:24, Iskren Chernev wrote: >>> The SM6115 comes with UFS support, so add the related UFS and UFS PHY >>> nodes. >>> >>> Signed-off-by: Iskren Chernev >>> --- >>> arch/arm64/boot/dts/qcom/sm6115.dtsi | 70 ++++++++++++++++++++++++++++ >>> 1 file changed, 70 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi >>> index cde963c56ac9..491fffff8aa1 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi >>> @@ -620,6 +620,76 @@ opp-202000000 { >>> }; >>> }; >>> >>> + ufs_mem_hc: ufshc@4804000 { >>> + compatible = "qcom,sm6115-ufshc", "qcom,ufshc", >>> + "jedec,ufs-2.0"; >>> + reg = <0x4804000 0x3000>, <0x4810000 0x8000>; >>> + reg-names = "std", "ice"; >> >> I could imagine that testing DTS against existing bindings might miss a >> lot, because we have still a lot of errors. But at least I would expect >> you test your DTS against your own bindings, which you submit here (and >> previously). >> >> You just wrote that ice is not allowed. > > OK, I'm an idiot. I didn't run the bindings checks, not against existing > bindings or my bindings or whatever. It's my fault. > > Ice should be allowed, I fixed the bindings in v2. > > For the record, running dtbs_checks is a PITA, not only because of the > thousands of warnings in unrelated code, but because it takes forever. You can limit it per schema and/or limit it per target, which would speed up things. Of course it depends on computer you have, but I don't find it slow on my laptop and I run them a lot... > > Maybe the docs should be updated with instructions on how to run it on a single > (or a small subset) of DTBs. I had to comment out a lot of Makefile lines to > focus it on mine. It would really help if the binding check works more like > a compiler, not some magic spell hidden in a bunch of Makefiles. crosc.... make -j8 DT_SCHEMA_FILES=exynos-srom.yaml CHECK_DTBS=y qcom/sm8450-hdk.dtb > > I'll list all remaining issues with description/explanation in v2. The fact > that some bindings break on all DTBs present doesn't help either. We're working on this... It's quite a lot of effort, especially when new warnings are being added. :) Best regards, Krzysztof