From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?UGF3ZcWC?= Chmiel Subject: Re: [PATCH 0/5] mtd: onenand/samsung: Add device tree support Date: Mon, 29 Apr 2019 16:42:47 +0200 Message-ID: <1813629.D8pu8sOiIg@acerlaptop> References: <20190426164224.11327-1-pawel.mikolaj.chmiel@gmail.com> <20190429101928.265998b5@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190429101928.265998b5@xps13> Sender: linux-kernel-owner@vger.kernel.org To: Miquel Raynal Cc: kyungmin.park@samsung.com, bbrezillon@kernel.org, richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On poniedzia=C5=82ek, 29 kwietnia 2019 10:19:28 CEST Miquel Raynal wrote: > Hi Pawe=C5=82, >=20 > Pawe=C5=82 Chmiel wrote on Fri, 26 Apr 2= 019 > 18:42:19 +0200: >=20 > > This patchset adds device tree support to Samsung OneNAND driver. > > It was tested on Samsung Galaxy S and Samsung Galaxy S Fascinate 4G, > > an Samsung S5PV210 based mobile phones. > >=20 > > Tomasz Figa (5): > > mtd: onenand/samsung: Unify resource order for controller variants > > mtd: onenand/samsung: Make sure that bus clock is enabled > > mtd: onenand/samsung: Add device tree support > > dt-binding: mtd: onenand/samsung: Add device tree support > > mtd: onenand/samsung: Set name field of mtd_info struct > >=20 > > .../bindings/mtd/samsung-onenand.txt | 46 +++++++++ > > drivers/mtd/nand/onenand/samsung.c | 94 +++++++++++++------ > > 2 files changed, 113 insertions(+), 27 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/mtd/samsung-onena= nd.txt > >=20 >=20 > I think you should use "mtd: onenand: samsung:" as prefix. >=20 > Thanks, > Miqu=C3=A8l >=20 Hi Miqu=C3=A8l I'll fix all issues and send new version of patchset. Thanks for review and comments