From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
kernel@pengutronix.de, devicetree@vger.kernel.org,
p.zabel@pengutronix.de, javierm@redhat.com,
sakari.ailus@linux.intel.com, afshin.nasser@gmail.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3 2/9] media: tvp5150: fix irq_request error path during probe
Date: Wed, 31 Oct 2018 01:21:20 +0200 [thread overview]
Message-ID: <1822001.PqOh1AofYR@avalon> (raw)
In-Reply-To: <20180918131453.21031-3-m.felsch@pengutronix.de>
Hi Marco,
Thank you for the patch.
On Tuesday, 18 September 2018 16:14:46 EEST Marco Felsch wrote:
> Commit 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
> introduced the interrupt handling. But we have to free the
> v4l2_ctrl_handler before we can return the error code.
>
> Fixes: 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/tvp5150.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index 133073518744..40aaa8ca0b63 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -1650,7 +1650,7 @@ static int tvp5150_probe(struct i2c_client *c,
> tvp5150_isr, IRQF_TRIGGER_HIGH |
> IRQF_ONESHOT, "tvp5150", core);
> if (res)
> - return res;
> + goto err;
> }
>
> res = v4l2_async_register_subdev(sd);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-10-30 23:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 13:14 [PATCH v3 0/9] TVP5150 fixes and new features Marco Felsch
2018-09-18 13:14 ` [PATCH v3 1/9] partial revert of "[media] tvp5150: add HW input connectors support" Marco Felsch
2018-09-25 15:20 ` Rob Herring
2018-09-18 13:14 ` [PATCH v3 2/9] media: tvp5150: fix irq_request error path during probe Marco Felsch
2018-10-30 23:21 ` Laurent Pinchart [this message]
2018-09-18 13:14 ` [PATCH v3 3/9] media: tvp5150: add input source selection of_graph support Marco Felsch
2018-09-18 13:14 ` [PATCH v3 4/9] media: dt-bindings: tvp5150: Add input port connectors DT bindings Marco Felsch
2018-09-26 22:49 ` Rob Herring
2018-09-18 13:14 ` [PATCH v3 5/9] media: v4l2-subdev: add stubs for v4l2_subdev_get_try_* Marco Felsch
2018-09-18 13:14 ` [PATCH v3 6/9] media: v4l2-subdev: fix v4l2_subdev_get_try_* dependency Marco Felsch
2018-09-19 10:45 ` Sakari Ailus
2018-09-19 12:37 ` Marco Felsch
2018-09-18 13:14 ` [PATCH v3 7/9] media: tvp5150: add FORMAT_TRY support for get/set selection handlers Marco Felsch
2018-09-18 13:14 ` [PATCH v3 8/9] media: tvp5150: initialize subdev before parsing device tree Marco Felsch
2018-09-18 13:14 ` [PATCH v3 9/9] media: tvp5150: add s_power callback Marco Felsch
2018-10-29 18:41 ` [PATCH v3 0/9] TVP5150 fixes and new features Marco Felsch
2018-11-09 13:46 ` Marco Felsch
2018-12-05 9:57 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1822001.PqOh1AofYR@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=afshin.nasser@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=javierm@redhat.com \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).