* [PATCH v2 0/2] Convert Rockchip CDN DP binding to yaml
@ 2025-05-09 7:02 Chaoyi Chen
2025-05-09 7:02 ` [PATCH v2 1/2] arm64: dts: rockchip: Improve coding style for rk3399 cdn_dp Chaoyi Chen
2025-05-09 7:02 ` [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml Chaoyi Chen
0 siblings, 2 replies; 9+ messages in thread
From: Chaoyi Chen @ 2025-05-09 7:02 UTC (permalink / raw)
To: Sandy Huang, Heiko Stuebner, Andy Yan, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Chaoyi Chen, Dragan Simic, dri-devel, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
This series convert cdn-dp-rockchip.txt to yaml.
PATCH 1 try to improve coding style on the existing rk3399 cdn-dp
node.
PATCH 2 try to convert cdn-dp-rockchip.txt to yaml.
Changes in v2:
- Link to V1: https://lore.kernel.org/all/20250508064304.670-1-kernel@airkyi.com/
- Rename binding file name to match compatible
- Add more description about grf/phy/extcon
- Fix coding style
Chaoyi Chen (2):
arm64: dts: rockchip: Improve coding style for rk3399 cdn_dp
dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
.../display/rockchip/cdn-dp-rockchip.txt | 74 --------
.../rockchip/rockchip,rk3399-cdn-dp.yaml | 158 ++++++++++++++++++
arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 10 +-
3 files changed, 167 insertions(+), 75 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt
create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml
--
2.49.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/2] arm64: dts: rockchip: Improve coding style for rk3399 cdn_dp
2025-05-09 7:02 [PATCH v2 0/2] Convert Rockchip CDN DP binding to yaml Chaoyi Chen
@ 2025-05-09 7:02 ` Chaoyi Chen
2025-05-09 7:02 ` [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml Chaoyi Chen
1 sibling, 0 replies; 9+ messages in thread
From: Chaoyi Chen @ 2025-05-09 7:02 UTC (permalink / raw)
To: Sandy Huang, Heiko Stuebner, Andy Yan, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Chaoyi Chen, Dragan Simic, dri-devel, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
Let's make the ports nodes of cdn_dp in the same style as the other
display interface, and match the style of ports's yaml.
Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
---
(no changes since v1)
arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
index 9d5f5b083e3c..e340b6df7445 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
@@ -618,7 +618,11 @@ cdn_dp: dp@fec00000 {
status = "disabled";
ports {
- dp_in: port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dp_in: port@0 {
+ reg = <0>;
#address-cells = <1>;
#size-cells = <0>;
@@ -632,6 +636,10 @@ dp_in_vopl: endpoint@1 {
remote-endpoint = <&vopl_out_dp>;
};
};
+
+ dp_out: port@1 {
+ reg = <1>;
+ };
};
};
--
2.49.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
2025-05-09 7:02 [PATCH v2 0/2] Convert Rockchip CDN DP binding to yaml Chaoyi Chen
2025-05-09 7:02 ` [PATCH v2 1/2] arm64: dts: rockchip: Improve coding style for rk3399 cdn_dp Chaoyi Chen
@ 2025-05-09 7:02 ` Chaoyi Chen
2025-05-09 7:11 ` Krzysztof Kozlowski
2025-05-09 13:45 ` Rob Herring (Arm)
1 sibling, 2 replies; 9+ messages in thread
From: Chaoyi Chen @ 2025-05-09 7:02 UTC (permalink / raw)
To: Sandy Huang, Heiko Stuebner, Andy Yan, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Chaoyi Chen, Dragan Simic, dri-devel, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
Convert cdn-dp-rockchip.txt to yaml.
Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
---
Changes in v2:
- Rename binding file name to match compatible
- Add more description about grf/phy/extcon
- Fix coding style
.../display/rockchip/cdn-dp-rockchip.txt | 74 --------
.../rockchip/rockchip,rk3399-cdn-dp.yaml | 158 ++++++++++++++++++
2 files changed, 158 insertions(+), 74 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt
create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml
diff --git a/Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt
deleted file mode 100644
index 8df7d2e393d6..000000000000
--- a/Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt
+++ /dev/null
@@ -1,74 +0,0 @@
-Rockchip RK3399 specific extensions to the cdn Display Port
-================================
-
-Required properties:
-- compatible: must be "rockchip,rk3399-cdn-dp"
-
-- reg: physical base address of the controller and length
-
-- clocks: from common clock binding: handle to dp clock.
-
-- clock-names: from common clock binding:
- Required elements: "core-clk" "pclk" "spdif" "grf"
-
-- resets : a list of phandle + reset specifier pairs
-- reset-names : string of reset names
- Required elements: "apb", "core", "dptx", "spdif"
-- power-domains : power-domain property defined with a phandle
- to respective power domain.
-- assigned-clocks: main clock, should be <&cru SCLK_DP_CORE>
-- assigned-clock-rates : the DP core clk frequency, shall be: 100000000
-
-- rockchip,grf: this soc should set GRF regs, so need get grf here.
-
-- ports: contain a port nodes with endpoint definitions as defined in
- Documentation/devicetree/bindings/media/video-interfaces.txt.
- contained 2 endpoints, connecting to the output of vop.
-
-- phys: from general PHY binding: the phandle for the PHY device.
-
-- extcon: extcon specifier for the Power Delivery
-
-- #sound-dai-cells = it must be 1 if your system is using 2 DAIs: I2S, SPDIF
-
--------------------------------------------------------------------------------
-
-Example:
- cdn_dp: dp@fec00000 {
- compatible = "rockchip,rk3399-cdn-dp";
- reg = <0x0 0xfec00000 0x0 0x100000>;
- interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&cru SCLK_DP_CORE>, <&cru PCLK_DP_CTRL>,
- <&cru SCLK_SPDIF_REC_DPTX>, <&cru PCLK_VIO_GRF>;
- clock-names = "core-clk", "pclk", "spdif", "grf";
- assigned-clocks = <&cru SCLK_DP_CORE>;
- assigned-clock-rates = <100000000>;
- power-domains = <&power RK3399_PD_HDCP>;
- phys = <&tcphy0_dp>, <&tcphy1_dp>;
- resets = <&cru SRST_DPTX_SPDIF_REC>;
- reset-names = "spdif";
- extcon = <&fusb0>, <&fusb1>;
- rockchip,grf = <&grf>;
- #address-cells = <1>;
- #size-cells = <0>;
- #sound-dai-cells = <1>;
-
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- dp_in: port {
- #address-cells = <1>;
- #size-cells = <0>;
- dp_in_vopb: endpoint@0 {
- reg = <0>;
- remote-endpoint = <&vopb_out_dp>;
- };
-
- dp_in_vopl: endpoint@1 {
- reg = <1>;
- remote-endpoint = <&vopl_out_dp>;
- };
- };
- };
- };
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml
new file mode 100644
index 000000000000..99d1f0ad9cda
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml
@@ -0,0 +1,158 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/rockchip/rockchip,cdn-dp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip RK3399 specific extensions to the CDN Display Port
+
+maintainers:
+ - Andy Yan <andy.yan@rock-chip.com>
+ - Heiko Stuebner <heiko@sntech.de>
+ - Sandy Huang <hjc@rock-chips.com>
+
+allOf:
+ - $ref: /schemas/sound/dai-common.yaml#
+
+properties:
+ compatible:
+ items:
+ - const: rockchip,rk3399-cdn-dp
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: DP core work clock
+ - description: APB clock
+ - description: SPDIF interface clock
+ - description: GRF clock
+
+ clock-names:
+ items:
+ - const: core-clk
+ - const: pclk
+ - const: spdif
+ - const: grf
+
+ extcon:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description:
+ Phandle to the extcon device providing the cable state for the DP PHY.
+
+ interrupts:
+ maxItems: 1
+
+ phys:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description:
+ Phandle to the PHY device for DP output.
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Input of the CDN DP
+ properties:
+ endpoint@0:
+ description: Connection to the VOPB
+ endpoint@1:
+ description: Connection to the VOPL
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description: Output of the CDN DP
+
+ required:
+ - port@0
+ - port@1
+
+ power-domains:
+ maxItems: 1
+
+ resets:
+ maxItems: 4
+
+ reset-names:
+ items:
+ - const: spdif
+ - const: dptx
+ - const: apb
+ - const: core
+
+ rockchip,grf:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ Phandle to GRF register to control HPD.
+
+ "#sound-dai-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - interrupts
+ - phys
+ - ports
+ - resets
+ - reset-names
+ - rockchip,grf
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/rk3399-cru.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/rk3399-power.h>
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ dp@fec00000 {
+ compatible = "rockchip,rk3399-cdn-dp";
+ reg = <0x0 0xfec00000 0x0 0x100000>;
+ assigned-clocks = <&cru SCLK_DP_CORE>;
+ assigned-clock-rates = <100000000>;
+ interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru SCLK_DP_CORE>, <&cru PCLK_DP_CTRL>, <&cru SCLK_SPDIF_REC_DPTX>,
+ <&cru PCLK_VIO_GRF>;
+ clock-names = "core-clk", "pclk", "spdif", "grf";
+ power-domains = <&power RK3399_PD_HDCP>;
+ phys = <&tcphy0_dp>, <&tcphy1_dp>;
+ resets = <&cru SRST_DPTX_SPDIF_REC>, <&cru SRST_P_UPHY0_DPTX>,
+ <&cru SRST_P_UPHY0_APB>, <&cru SRST_DP_CORE>;
+ reset-names = "spdif", "dptx", "apb", "core";
+ rockchip,grf = <&grf>;
+ #sound-dai-cells = <1>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dp_in: port@0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dp_in_vopb: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&vopb_out_dp>;
+ };
+
+ dp_in_vopl: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&vopl_out_dp>;
+ };
+ };
+
+ dp_out: port@1 {
+ reg = <1>;
+ };
+ };
+ };
+ };
--
2.49.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
2025-05-09 7:02 ` [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml Chaoyi Chen
@ 2025-05-09 7:11 ` Krzysztof Kozlowski
2025-05-09 7:34 ` Chaoyi Chen
2025-05-09 13:45 ` Rob Herring (Arm)
1 sibling, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-09 7:11 UTC (permalink / raw)
To: Chaoyi Chen, Sandy Huang, Heiko Stuebner, Andy Yan,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Chaoyi Chen, Dragan Simic, dri-devel, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
On 09/05/2025 09:02, Chaoyi Chen wrote:
> +
> + clock-names:
> + items:
> + - const: core-clk
> + - const: pclk
> + - const: spdif
> + - const: grf
> +
> + extcon:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description:
> + Phandle to the extcon device providing the cable state for the DP PHY.
> +
> + interrupts:
> + maxItems: 1
> +
> + phys:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
Just phandle. If this is an array (but why?), you need maxItems for
outer and inner dimensions.
> + description:
> + Phandle to the PHY device for DP output.
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Input of the CDN DP
> + properties:
> + endpoint@0:
> + description: Connection to the VOPB
> + endpoint@1:
> + description: Connection to the VOPL
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Output of the CDN DP
> +
> + required:
> + - port@0
> + - port@1
> +
> + power-domains:
> + maxItems: 1
> +
> + resets:
> + maxItems: 4
> +
> + reset-names:
> + items:
> + - const: spdif
> + - const: dptx
> + - const: apb
> + - const: core
> +
> + rockchip,grf:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + Phandle to GRF register to control HPD.
> +
> + "#sound-dai-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
> + - phys
> + - ports
> + - resets
> + - reset-names
> + - rockchip,grf
> +
> +additionalProperties: false
Well, if you added dai-common $ref then this could have stayed as
unevaluatedProperties, so you will allow names for the DAI as well.
>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
2025-05-09 7:11 ` Krzysztof Kozlowski
@ 2025-05-09 7:34 ` Chaoyi Chen
2025-05-09 7:46 ` Heiko Stübner
2025-05-09 9:21 ` Krzysztof Kozlowski
0 siblings, 2 replies; 9+ messages in thread
From: Chaoyi Chen @ 2025-05-09 7:34 UTC (permalink / raw)
To: Krzysztof Kozlowski, Chaoyi Chen, Sandy Huang, Heiko Stuebner,
Andy Yan, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Dragan Simic, dri-devel, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
Hi Krzysztof,
On 2025/5/9 15:11, Krzysztof Kozlowski wrote:
> On 09/05/2025 09:02, Chaoyi Chen wrote:
>> +
>> + clock-names:
>> + items:
>> + - const: core-clk
>> + - const: pclk
>> + - const: spdif
>> + - const: grf
>> +
>> + extcon:
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> + description:
>> + Phandle to the extcon device providing the cable state for the DP PHY.
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + phys:
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
> Just phandle. If this is an array (but why?), you need maxItems for
> outer and inner dimensions.
I think it could be phandle or phandle-array. Since the RK3399 DP has
two PHYs, if we put in two PHYs here, the driver will pick one PHY port
that is already plugged into the DP for output. If we fill in only one
PHY here, then output is only allowed on the corresponding PHY.
Will add restrictions and add more descriptions in v3.
>
>> + description:
>> + Phandle to the PHY device for DP output.
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Input of the CDN DP
>> + properties:
>> + endpoint@0:
>> + description: Connection to the VOPB
>> + endpoint@1:
>> + description: Connection to the VOPL
>> + port@1:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Output of the CDN DP
>> +
>> + required:
>> + - port@0
>> + - port@1
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + resets:
>> + maxItems: 4
>> +
>> + reset-names:
>> + items:
>> + - const: spdif
>> + - const: dptx
>> + - const: apb
>> + - const: core
>> +
>> + rockchip,grf:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + Phandle to GRF register to control HPD.
>> +
>> + "#sound-dai-cells":
>> + const: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - clock-names
>> + - interrupts
>> + - phys
>> + - ports
>> + - resets
>> + - reset-names
>> + - rockchip,grf
>> +
>> +additionalProperties: false
> Well, if you added dai-common $ref then this could have stayed as
> unevaluatedProperties, so you will allow names for the DAI as well.
Thanks for your clarification. Will fix in v3.
>
>
> Best regards,
> Krzysztof
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
2025-05-09 7:34 ` Chaoyi Chen
@ 2025-05-09 7:46 ` Heiko Stübner
2025-05-09 9:21 ` Krzysztof Kozlowski
1 sibling, 0 replies; 9+ messages in thread
From: Heiko Stübner @ 2025-05-09 7:46 UTC (permalink / raw)
To: Krzysztof Kozlowski, Chaoyi Chen, Sandy Huang, Andy Yan,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chaoyi Chen
Cc: Dragan Simic, dri-devel, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
Am Freitag, 9. Mai 2025, 09:34:47 Mitteleuropäische Sommerzeit schrieb Chaoyi Chen:
> Hi Krzysztof,
>
> On 2025/5/9 15:11, Krzysztof Kozlowski wrote:
> > On 09/05/2025 09:02, Chaoyi Chen wrote:
> >> +
> >> + clock-names:
> >> + items:
> >> + - const: core-clk
> >> + - const: pclk
> >> + - const: spdif
> >> + - const: grf
> >> +
> >> + extcon:
> >> + $ref: /schemas/types.yaml#/definitions/phandle-array
> >> + description:
> >> + Phandle to the extcon device providing the cable state for the DP PHY.
> >> +
> >> + interrupts:
> >> + maxItems: 1
> >> +
> >> + phys:
> >> + $ref: /schemas/types.yaml#/definitions/phandle-array
> > Just phandle. If this is an array (but why?), you need maxItems for
> > outer and inner dimensions.
>
> I think it could be phandle or phandle-array. Since the RK3399 DP has
> two PHYs, if we put in two PHYs here, the driver will pick one PHY port
> that is already plugged into the DP for output. If we fill in only one
> PHY here, then output is only allowed on the corresponding PHY.
>
> Will add restrictions and add more descriptions in v3.
Just looked that up in the documentation.
Only the rk3399 has used this controller at all so far. There is one
cdn-dp controller on it, but two phys for the two type-c blocks on
the soc.
The controller can then select which one to drive. So yep, there
are two phys.
Heiko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
2025-05-09 7:34 ` Chaoyi Chen
2025-05-09 7:46 ` Heiko Stübner
@ 2025-05-09 9:21 ` Krzysztof Kozlowski
2025-05-09 9:32 ` Chaoyi Chen
1 sibling, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-09 9:21 UTC (permalink / raw)
To: Chaoyi Chen, Chaoyi Chen, Sandy Huang, Heiko Stuebner, Andy Yan,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Dragan Simic, dri-devel, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
On 09/05/2025 09:34, Chaoyi Chen wrote:
> Hi Krzysztof,
>
> On 2025/5/9 15:11, Krzysztof Kozlowski wrote:
>> On 09/05/2025 09:02, Chaoyi Chen wrote:
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: core-clk
>>> + - const: pclk
>>> + - const: spdif
>>> + - const: grf
>>> +
>>> + extcon:
>>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>>> + description:
>>> + Phandle to the extcon device providing the cable state for the DP PHY.
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + phys:
>>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> Just phandle. If this is an array (but why?), you need maxItems for
>> outer and inner dimensions.
Uh, sorry, that was supposed to be under extcon.
>
> I think it could be phandle or phandle-array. Since the RK3399 DP has
Here it is obviously not needed, that's a dtschema type.
> two PHYs, if we put in two PHYs here, the driver will pick one PHY port
> that is already plugged into the DP for output. If we fill in only one
> PHY here, then output is only allowed on the corresponding PHY.
>
> Will add restrictions and add more descriptions in v3.
>
>
>>
>>> + description:
>>> + Phandle to the PHY device for DP output.
You need to list the items with description iinstead.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
2025-05-09 9:21 ` Krzysztof Kozlowski
@ 2025-05-09 9:32 ` Chaoyi Chen
0 siblings, 0 replies; 9+ messages in thread
From: Chaoyi Chen @ 2025-05-09 9:32 UTC (permalink / raw)
To: Krzysztof Kozlowski, Chaoyi Chen, Sandy Huang, Heiko Stuebner,
Andy Yan, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Dragan Simic, dri-devel, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
Hi Krzysztof,
On 2025/5/9 17:21, Krzysztof Kozlowski wrote:
> On 09/05/2025 09:34, Chaoyi Chen wrote:
>> Hi Krzysztof,
>>
>> On 2025/5/9 15:11, Krzysztof Kozlowski wrote:
>>> On 09/05/2025 09:02, Chaoyi Chen wrote:
>>>> +
>>>> + clock-names:
>>>> + items:
>>>> + - const: core-clk
>>>> + - const: pclk
>>>> + - const: spdif
>>>> + - const: grf
>>>> +
>>>> + extcon:
>>>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>>>> + description:
>>>> + Phandle to the extcon device providing the cable state for the DP PHY.
>>>> +
>>>> + interrupts:
>>>> + maxItems: 1
>>>> +
>>>> + phys:
>>>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>>> Just phandle. If this is an array (but why?), you need maxItems for
>>> outer and inner dimensions.
> Uh, sorry, that was supposed to be under extcon.
Oh, this also applies to extcon. Each extcon is used to indicate the
status of the PHY.
>
>> I think it could be phandle or phandle-array. Since the RK3399 DP has
> Here it is obviously not needed, that's a dtschema type.
Do you mean that there is no need to explicitly specify something like
"$ref: /schemas/types.yaml#/definitions/phandle" ?
>
>> two PHYs, if we put in two PHYs here, the driver will pick one PHY port
>> that is already plugged into the DP for output. If we fill in only one
>> PHY here, then output is only allowed on the corresponding PHY.
>>
>> Will add restrictions and add more descriptions in v3.
>>
>>
>>>> + description:
>>>> + Phandle to the PHY device for DP output.
> You need to list the items with description iinstead.
Okay, will fix in v3.
>
>
>
> Best regards,
> Krzysztof
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml
2025-05-09 7:02 ` [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml Chaoyi Chen
2025-05-09 7:11 ` Krzysztof Kozlowski
@ 2025-05-09 13:45 ` Rob Herring (Arm)
1 sibling, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2025-05-09 13:45 UTC (permalink / raw)
To: Chaoyi Chen
Cc: David Airlie, dri-devel, Simona Vetter, Conor Dooley,
Krzysztof Kozlowski, Andy Yan, Chaoyi Chen, linux-rockchip,
linux-kernel, Sandy Huang, linux-arm-kernel, Heiko Stuebner,
Dragan Simic, Thomas Zimmermann, devicetree, Maarten Lankhorst,
Maxime Ripard
On Fri, 09 May 2025 15:02:47 +0800, Chaoyi Chen wrote:
> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
>
> Convert cdn-dp-rockchip.txt to yaml.
>
> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> ---
>
> Changes in v2:
> - Rename binding file name to match compatible
> - Add more description about grf/phy/extcon
> - Fix coding style
>
>
> .../display/rockchip/cdn-dp-rockchip.txt | 74 --------
> .../rockchip/rockchip,rk3399-cdn-dp.yaml | 158 ++++++++++++++++++
> 2 files changed, 158 insertions(+), 74 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/rockchip/cdn-dp-rockchip.txt
> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
$id: http://devicetree.org/schemas/display/rockchip/rockchip,cdn-dp.yaml
file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3399-cdn-dp.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250509070247.868-3-kernel@airkyi.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-05-09 15:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-09 7:02 [PATCH v2 0/2] Convert Rockchip CDN DP binding to yaml Chaoyi Chen
2025-05-09 7:02 ` [PATCH v2 1/2] arm64: dts: rockchip: Improve coding style for rk3399 cdn_dp Chaoyi Chen
2025-05-09 7:02 ` [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml Chaoyi Chen
2025-05-09 7:11 ` Krzysztof Kozlowski
2025-05-09 7:34 ` Chaoyi Chen
2025-05-09 7:46 ` Heiko Stübner
2025-05-09 9:21 ` Krzysztof Kozlowski
2025-05-09 9:32 ` Chaoyi Chen
2025-05-09 13:45 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).