From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3793D3128A2; Wed, 27 Aug 2025 12:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298038; cv=none; b=hU6dNi0rJI3B94+fWVBpcfe8uOqoujRojVwEdKYxoBnzncVHRcpjJwLkXEjYCFBJ1jHq/8xwRe9tRuQA/Q4pPS67F8BQxWdyHRjfixKG+vX+Io0t66NcPNcPEIaBxc5K2JA/j7WTi3mdaclPHL3QDrkkELP5e+/DUGrdMd8ttrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756298038; c=relaxed/simple; bh=EMk0faYz8xJaX5aw4XPFGv8hRTtC4GU6Tnps39VJKdE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pEAm286Y41jwEz/nKkVlX22yTa2TX7ECto212ccGMaPJSbKvAnffgqt/xDIF9lWTGkg2qjw3ai59/vImvCNIoOgIBBVLQq1oVv3bZLytqocb6QqtQQtLlc+SQKQFEEGEzDwxbNU42QoM/KN015Lc+e26vhNqCtUR8PaVAu+cSYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z6Mf1Uwh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z6Mf1Uwh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4826CC4CEF4; Wed, 27 Aug 2025 12:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756298037; bh=EMk0faYz8xJaX5aw4XPFGv8hRTtC4GU6Tnps39VJKdE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Z6Mf1UwhwQ1IhN9kJ9zW+Lg5BBTOw28tpcK8eJxGvwBSPxF6Z8hq/bWtLmyLKbc8M quwtaSaTBUQ0JMla4Qg03wqQ+B+5ucH/7vijaWqrq97HMbykxBexRgKoi+aOJeg9Vv Suv9RZFbyhqhfjuxCbncEw+pNvD1Smx1OfgJtK5olu+NbbboPR/Grz0igNg5l+u+yw OK4TxyUGHL0pcqj5WXC3MjgwodoJgp6/muDtJcjAk4GbAj3bz8p1G2yvnjFuKwfn3i TCmmfy/2DZhlZ65RceHofuSEi2lMGxTb/5mmDdmCdSR3l6wj53EkWVS/E8qyubjySN JnrMs5d4LZ7Gw== Message-ID: <182444f3-6d94-46de-94d2-afa70d863db5@kernel.org> Date: Wed, 27 Aug 2025 14:33:54 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: mxl: Add MxL LGM Network Processor SoC To: Jack Ping CHNG , netdev@vger.kernel.org, devicetree@vger.kernel.org Cc: davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, yzhu@maxlinear.com, sureshnagaraj@maxlinear.com References: <20250826031044.563778-1-jchng@maxlinear.com> <20250826031044.563778-2-jchng@maxlinear.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20250826031044.563778-2-jchng@maxlinear.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/08/2025 05:10, Jack Ping CHNG wrote: > +maintainers: > + - Jack Ping Chng > + > +description: > + Binding for MaxLinear LGM Ethernet controller > + > +properties: > + compatible: > + enum: > + - mxl,lgm-eth No such vendor prefix. > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: ethif > + > + resets: > + maxItems: 1 > + > + '#address-cells': > + const: 1 Blank line > + '#size-cells': > + const: 0 > + > +patternProperties: > + "^interface@[1-4]$": Use consistent quotes, either ' or " I don't quite get what's this node is for. > + type: object > + properties: > + compatible: > + const: mxl,lgm-mac > + > + reg: > + minimum: 1 > + maximum: 4 > + > + required: > + - compatible > + - reg > + > +required: > + - compatible > + - clocks > + - clock-names > + - '#address-cells' > + - '#size-cells' > + > +additionalProperties: false > + > +examples: > + - | > + eth { ethernet? How is it called everywhere else? Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "mxl,lgm-eth"; > + clocks = <&cgu0 32>; > + clock-names = "ethif"; > + resets = <&rcu0 0x70 8>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + mac: interface@1 { > + compatible = "mxl,eth-mac"; > + reg = <1>; No resources here, so this is not really a subnode... unless you wanted to reference something from ethernet controllers. This looks pretty incomplete. > + }; > + }; Best regards, Krzysztof