devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
To: Jyri Sarha <jsarha-l0cyMroinI0@public.gmane.org>
Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	airlied-cv59FeDIM0c@public.gmane.org,
	daniel-/w4YWyX8dFk@public.gmane.org,
	tomi.valkeinen-l0cyMroinI0@public.gmane.org,
	robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
	khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
	bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v2 2/3] drm/bridge: Add ti-tfp410 DVI transmitter driver
Date: Thu, 17 Nov 2016 11:45:12 +0200	[thread overview]
Message-ID: <1829466.vPTafcVR8L@avalon> (raw)
In-Reply-To: <506ba969-d753-d026-5357-3329a750ceaf-l0cyMroinI0@public.gmane.org>

Hi Jyri,

On Wednesday 16 Nov 2016 16:39:28 Jyri Sarha wrote:
> On 11/16/16 15:33, Rob Herring wrote:
> >> +Optional properties
> >> 
> >>> +	- reg: I2C address. If and only if present the driver node

I assume you meant device node, not driver node ?

> >>> +	  should be placed into the i2c controller node where the
> >>> +	  tfp410 i2c is connected to (the current implementation does
> >>> +	  not yet support this).
> > 
> > So this chip can work without programming I guess?
> 
> Yes. Just powering it up is enough for most application.
> 
> > reg should only be not present if I2C is not connected in the design. It
> > can't be a function of what the driver supports. In otherwords, you
> > can't be moving this node around based on when you add I2C control.
> 
> Ok, I'll try to implement a dummy i2c driver at the same time too. I can
> not test anything related to it because I do not have a piece of HW with
> tfp410 i2c wires connected, but it should not matter as long as I am
> able to probe it as a i2c client.

I think that Rob's point was that whether the current implementation supports 
this or not is irrelevant from a DT bindings point of view. It should not be 
mentioned in the bindings document.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-11-17  9:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 16:54 [PATCH v2 0/3] drm/tilcdc: Add bridge support and sync-lost flood recovery Jyri Sarha
2016-11-14 16:54 ` [PATCH v2 1/3] drm/tilcdc: Recover from sync lost error flood by resetting the LCDC Jyri Sarha
     [not found] ` <cover.1479142062.git.jsarha-l0cyMroinI0@public.gmane.org>
2016-11-14 16:54   ` [PATCH v2 2/3] drm/bridge: Add ti-tfp410 DVI transmitter driver Jyri Sarha
2016-11-16 13:33     ` Rob Herring
2016-11-16 14:39       ` Jyri Sarha
2016-11-17  7:07         ` Tomi Valkeinen
     [not found]         ` <506ba969-d753-d026-5357-3329a750ceaf-l0cyMroinI0@public.gmane.org>
2016-11-17  9:45           ` Laurent Pinchart [this message]
2016-11-23 22:30             ` Rob Herring
2016-11-14 16:54 ` [PATCH v2 3/3] drm/tilcdc: Add drm bridge support for attaching drm bridge drivers Jyri Sarha
     [not found]   ` <12cd62cc9ea0f79d0f399c76bfa715125a0816ce.1479142062.git.jsarha-l0cyMroinI0@public.gmane.org>
2016-11-15 17:36     ` Bartosz Golaszewski
2016-11-15 20:46       ` Jyri Sarha
     [not found]         ` <36c37a00-0684-a758-219b-6dc71b3131ef-l0cyMroinI0@public.gmane.org>
2016-11-16  9:27           ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1829466.vPTafcVR8L@avalon \
    --to=laurent.pinchart-rylnwiuwjnjg/c1bvhzhaw@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=daniel-/w4YWyX8dFk@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=jsarha-l0cyMroinI0@public.gmane.org \
    --cc=khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=tomi.valkeinen-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).