From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C31CC76195 for ; Mon, 20 Mar 2023 17:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233210AbjCTRFX (ORCPT ); Mon, 20 Mar 2023 13:05:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233405AbjCTRFE (ORCPT ); Mon, 20 Mar 2023 13:05:04 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73039BBA4 for ; Mon, 20 Mar 2023 09:59:41 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id i5so2486050eda.0 for ; Mon, 20 Mar 2023 09:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679331497; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kFJSUgHgBA6fVjFOsVCUCNBjQjOx28L2GR1TCgVlFOc=; b=pnF/cF9ugfUMjXT3pZ5hURNG7tUXJVj7l9PQMUaDdv1timH8AaccUdiywmM47hefom biTbQrr5wuKUV4f/wcLAoQGioC1NT4y93jyPKV4FLmRto6mfQaAPP3ZnaELqrX30QNKk p0G1Y0FpNn82ODxnj9LZnD/uqTURleKQh/HJlind6EHAjyPb5zsyzgQKGDBB/B52JivY JWhA8fX+xssG7cRn3t6szH6NdaErWOIBNmsbSiS8WNc0jVtHXt0G3gbPOgP/X6shLdNC It3SWjyO2sYtQ9/QFGmQkkTlBxyhRdM+EaX067tQvKC7EbPxFQuvWTRVhxPJRjkcpBUD sXdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679331497; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kFJSUgHgBA6fVjFOsVCUCNBjQjOx28L2GR1TCgVlFOc=; b=L5e3TTusPiYkF5qMgiL2CfJeNN8WQRYD+VLgg9obAhryTTLrG7nRWF3EHd0EhOho8e rc5z23IiX82VyHZzylbh32LuaVbWEXvDpkQj8GGylWdII5usv3yT61UMMErnhIyKr2PH tmCT8GnBnX3XP40d1YXAVqZ75P7kai9LIENe3qFB8jTkBm2wvr+VlCBxu1l2VpXW7sN6 lja9cq7G1XuqNnxmldgMPiDGZntyXsmBctoCdNqa8ktnXz4peoHoQzDWInKtla6P3u0Q +qTUNN5Lk5+SomauA4ep9wNUj3EetfIdp1m6zgCsw0iGISG9IfXqiN+tZLxMsmKAJPwB F3Dw== X-Gm-Message-State: AO0yUKWZzJIVQ2sGSOnrhIuCZJD0GsTHFSFFQJEbIilz8y0nzDxV4Btq d5qQp53jE5YNcUmuggm4ITh/Fm7RqE9H/pAReM0= X-Google-Smtp-Source: AK7set8b9t2ZFlGF1WY07Zu3lWziOZGj1aKUfLhWe2QE7mDcO8rGB3IIiBBozLUDLT39ruGI1pOJeQ== X-Received: by 2002:a05:6402:150e:b0:4fe:96a9:ab0a with SMTP id f14-20020a056402150e00b004fe96a9ab0amr207881edw.1.1679331022727; Mon, 20 Mar 2023 09:50:22 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:458e:64e7:8cf1:78b0? ([2a02:810d:15c0:828:458e:64e7:8cf1:78b0]) by smtp.gmail.com with ESMTPSA id i20-20020a508714000000b004fc649481basm5185947edb.58.2023.03.20.09.50.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 09:50:22 -0700 (PDT) Message-ID: <182d39e4-fa11-c914-7015-80bd68c91596@linaro.org> Date: Mon, 20 Mar 2023 17:50:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 01/10] dt: bindings: clock: add mtmips SoCs clock device tree binding documentation Content-Language: en-US To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Sergio Paracuellos , linux-clk@vger.kernel.org Cc: linux-mips@vger.kernel.org, tsbogend@alpha.franken.de, john@phrozen.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, devicetree@vger.kernel.org References: <20230320161823.1424278-1-sergio.paracuellos@gmail.com> <20230320161823.1424278-2-sergio.paracuellos@gmail.com> <1e2f67b4-3bfb-d394-4f60-e6f63ce6a2fd@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/03/2023 17:43, Arınç ÜNAL wrote: > On 20.03.2023 19:36, Krzysztof Kozlowski wrote: >> On 20/03/2023 17:18, Sergio Paracuellos wrote: >>> Adds device tree binding documentation for clocks and resets in the >>> Mediatek MIPS and Ralink SOCs. This covers RT2880, RT3050, RT3052, RT3350, >>> RT3883, RT5350, MT7620, MT7628 and MT7688 SoCs. >> >> Use subject prefixes matching the subsystem (which you can get for >> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >> your patch is touching). >> >> Subject: drop second/last, redundant "device tree binding >> documentation". The "dt-bindings" prefix is already stating that these >> are bindings. >> (BTW, that's the longest redundant component I ever saw) >> >>> >>> Signed-off-by: Sergio Paracuellos >>> --- >>> .../bindings/clock/mtmips-clock.yaml | 68 +++++++++++++++++++ >>> 1 file changed, 68 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/mtmips-clock.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/clock/mtmips-clock.yaml b/Documentation/devicetree/bindings/clock/mtmips-clock.yaml >>> new file mode 100644 >>> index 000000000000..c92969ce231d >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/mtmips-clock.yaml >> >> Filename matching compatible, so vendor prefix and device name (or >> family of names). > > I influenced Sergio to use MTMIPS here as I want to designate it the > family name for the MediaTek MIPS and Ralink SoCs. I don't know how to respond to this. Is it argument for not using naming style? > We can't change the > compatible string as it's established from my pinctrl patch series we > don't do that. The patch did not say it is documenting existing compatibles in the kernel DTS. And if we are at this, ralink,rt2880-reset does not look like single clock nor like clock controller. Best regards, Krzysztof