public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexander Koskovich <akoskovich@pm.me>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Akhil P Oommen <akhilpo@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Luca Weiss <luca.weiss@fairphone.com>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] arm64: dts: qcom: milos: Add Adreno 810 GPU and GMU nodes
Date: Thu, 2 Apr 2026 10:22:39 +0200	[thread overview]
Message-ID: <182d58c1-21fb-4cab-8ce7-26f07d63d246@kernel.org> (raw)
In-Reply-To: <20260402-military-arrogant-woodpecker-4ab9b5@quoll>

On 02/04/2026 10:19, Krzysztof Kozlowski wrote:
> On Wed, Apr 01, 2026 at 02:17:44AM +0000, Alexander Koskovich wrote:
>> Add GPU and GMU devicetree nodes for the Adreno 810 GPU found on
>> Qualcomm SM7635 (Milos) based devices.
>>
>> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
>> ---
>>  arch/arm64/boot/dts/qcom/milos.dtsi | 148 ++++++++++++++++++++++++++++++++++++
>>  1 file changed, 148 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
>> index 621f05820826..a8feb0339804 100644
>> --- a/arch/arm64/boot/dts/qcom/milos.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi
>> @@ -7,6 +7,7 @@
>>  #include <dt-bindings/clock/qcom,milos-dispcc.h>
>>  #include <dt-bindings/clock/qcom,milos-gcc.h>
>>  #include <dt-bindings/clock/qcom,milos-gpucc.h>
>> +#include <dt-bindings/clock/qcom,kaanapali-gxclkctl.h>
> 
> Why? My next from 27th Match does not have Milos in that binding. Was it
> added? It's worth mentioning in commit msg.
> 

Now I checked in the cover letter - that patch was rejected. You cannot
depend on rejected patch and still claim that this patchset is ready for
merging. This patchset should be somehow marked that it depends on stuff
which is wrong, usually I recommend marking it as RFC with explanation
in cover letter WHY this is RFC (because it cannot be merged).

Best regards,
Krzysztof

  reply	other threads:[~2026-04-02  8:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01  2:16 [PATCH 0/6] Add support for Adreno 810 GPU Alexander Koskovich
2026-04-01  2:16 ` [PATCH 1/6] dt-bindings: display/msm/gmu: Document Adreno 810 GMU Alexander Koskovich
2026-04-02  8:17   ` Krzysztof Kozlowski
2026-04-01  2:17 ` [PATCH 2/6] drm/msm/adreno: rename llc_mmio to cx_mmio Alexander Koskovich
2026-04-01  8:40   ` Konrad Dybcio
2026-04-01  2:17 ` [PATCH 3/6] drm/msm/adreno: set cx_mmio regardless of if platform has LLCC Alexander Koskovich
2026-04-01  8:46   ` Konrad Dybcio
2026-04-01  2:17 ` [PATCH 4/6] drm/msm/a8xx: use pipe protect slot 15 for last-span-unbound feature Alexander Koskovich
2026-04-01  9:32   ` Konrad Dybcio
2026-04-01  2:17 ` [PATCH 5/6] drm/msm/adreno: add Adreno 810 GPU support Alexander Koskovich
2026-04-01 10:02   ` Konrad Dybcio
2026-04-02 22:14     ` Alexander Koskovich
2026-04-01  2:17 ` [PATCH 6/6] arm64: dts: qcom: milos: Add Adreno 810 GPU and GMU nodes Alexander Koskovich
2026-04-01 10:29   ` Konrad Dybcio
2026-04-02  8:19   ` Krzysztof Kozlowski
2026-04-02  8:22     ` Krzysztof Kozlowski [this message]
2026-04-02 16:36       ` Alexander Koskovich
2026-04-02 16:38         ` Krzysztof Kozlowski
2026-04-02 14:28     ` Alexander Koskovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=182d58c1-21fb-4cab-8ce7-26f07d63d246@kernel.org \
    --to=krzk@kernel.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=akhilpo@oss.qualcomm.com \
    --cc=akoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox