From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Komal Bajaj <quic_kbajaj@quicinc.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_nainmeht@quicinc.com
Subject: Re: [RFC PATCH 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 idp and rb3 board
Date: Sun, 5 Nov 2023 14:08:24 +0100 [thread overview]
Message-ID: <1830fc44-7bac-4db5-af59-112410d73a64@linaro.org> (raw)
In-Reply-To: <CAA8EJprNyu0r_mV9hbKA1fSvoEvTHuk5umxU8H64Voj_cnZcFQ@mail.gmail.com>
On 03/11/2023 23:22, Dmitry Baryshkov wrote:
> On Fri, 3 Nov 2023 at 20:49, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>>
>> Add qcm6490 devicetree file for QCM6490 IDP and QCM6490 RB3
>> platform. QCM6490 is derived from SC7280 meant for various
>> form factor including IoT.
>>
>> Supported features are, as of now:
>> * Debug UART
>> * eMMC (only in IDP)
>> * USB
>>
...
>> +
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-iot-common.dtsi b/arch/arm64/boot/dts/qcom/qcm6490-iot-common.dtsi
>> new file mode 100644
>> index 000000000000..01adc97789d0
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-iot-common.dtsi
>
> I have mixed feelings towards this file. Usually we add such 'common'
> files only for the phone platforms where most of the devices are
> common.
> Do you expect that IDP and RB3 will have a lot of common code other
> than these regulator settings?
I agree here. What exactly is common in the real hardware between IDP
and RB3? Commit msg does not explain it, so I do not see enough
justification for common file. Just because some DTS looks similar for
different hardware does not mean you should creat common file.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-05 13:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 18:46 [RFC PATCH 0/2] Add support for qcm6490 idp and rb3 board Komal Bajaj
2023-11-03 18:46 ` [RFC PATCH 1/2] dt-bindings: arm: qcom: Add QCM6490 IDP and RB3 board Komal Bajaj
2023-11-05 13:06 ` Krzysztof Kozlowski
2023-11-03 18:46 ` [RFC PATCH 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 idp and rb3 board Komal Bajaj
2023-11-03 22:22 ` Dmitry Baryshkov
2023-11-05 13:08 ` Krzysztof Kozlowski [this message]
2023-11-06 11:41 ` Mukesh Ojha
2023-11-06 11:54 ` Dmitry Baryshkov
2023-11-06 14:45 ` Mukesh Ojha
2023-11-06 22:32 ` Dmitry Baryshkov
2023-11-07 8:10 ` Mukesh Ojha
2023-11-13 15:51 ` Luca Weiss
2023-11-14 12:48 ` Mukesh Ojha
2023-11-14 12:53 ` Dmitry Baryshkov
2023-11-06 13:05 ` Krzysztof Kozlowski
2023-11-06 14:51 ` Mukesh Ojha
[not found] ` <4d8c094f-07b0-2b38-4680-145eb2d7c4f5@quicinc.com>
2023-11-17 9:33 ` Dmitry Baryshkov
2023-11-17 12:43 ` Komal Bajaj
2023-11-04 12:32 ` Konrad Dybcio
2023-11-17 12:49 ` Komal Bajaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1830fc44-7bac-4db5-af59-112410d73a64@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kbajaj@quicinc.com \
--cc=quic_nainmeht@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).