From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH] of: Add dummy for of_node_is_root if not CONFIG_OF Date: Tue, 7 May 2019 15:17:53 -0700 Message-ID: <18324244-cca8-a836-5c2e-c626ca8771aa@gmail.com> References: <20190507044801.250396-1-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: Rob Herring , Kees Cook , "open list:ARM/Rockchip SoC..." , Julius Werner , Guenter Roeck , Brian Norris , devicetree@vger.kernel.org, LKML List-Id: devicetree@vger.kernel.org On 5/7/19 10:59 AM, Doug Anderson wrote: > Hi, > > > On Tue, May 7, 2019 at 10:52 AM Frank Rowand wrote: >> >> On 5/6/19 9:48 PM, Douglas Anderson wrote: >>> We'll add a dummy to just return false. >> >> A more complete explanation of why this is needed please. >> >> My one guess would be compile testing of arch/sparc/kernel/prom_64.c >> fails??? > > Ah, sorry. Needed for: > > https://lkml.kernel.org/r/CAD=FV=Vxp-U7mZUNmAAOja5pt-8rZqPryEvwTg_Dv3ChuH_TrA@mail.gmail.com Got it. I went and looked at that. I think a better approach would be to check parent node not "/reserved-memory". I am making this suggestion in that email thread. -Frank > > > > -Doug > . >